github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-09 10:45:04 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #1964] [MERGED] Mobile category modal menu #4048

New Issue
Closed
opened 2026-02-28 20:50:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:50:45 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1964
Author: @joel-jeremy
Created: 11/23/2023
Status: ✅ Merged
Merged: 12/22/2023
Merged by: @joel-jeremy

Base: master ← Head: mobile-category-menu

📝 Commits (10+)

  • 63f1963 Mobile category modal menu
  • 6faeb27 Release notes
  • fa544b3 Apply category and group modals
  • 0df65e5 Category modal updates + notes
  • f97ff58 Reduce notes modal view height
  • 5783b8e Update CategoryGroupMenu modal view height
  • e054161 Update CategoryMenu modal view height
  • be7f1f0 Fix lint error
  • 6c6d541 No notes text
  • ea4ff21 Add budget-table testid on edit mode

📊 Changes

21 files changed (+1162 additions, -836 deletions)

View changed files

📝 packages/desktop-client/src/components/Modals.tsx (+44 -2)
➕ packages/desktop-client/src/components/Notes.tsx (+133 -0)
📝 packages/desktop-client/src/components/NotesButton.tsx (+8 -104)
📝 packages/desktop-client/src/components/budget/MobileBudget.jsx (+114 -72)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.jsx (+92 -625)
📝 packages/desktop-client/src/components/common/Menu.tsx (+10 -3)
📝 packages/desktop-client/src/components/common/Modal.tsx (+97 -19)
➕ packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx (+261 -0)
➕ packages/desktop-client/src/components/modals/CategoryMenu.tsx (+230 -0)
📝 packages/desktop-client/src/components/modals/EditRule.jsx (+1 -1)
📝 packages/desktop-client/src/components/modals/ManageRulesModal.tsx (+0 -2)
➕ packages/desktop-client/src/components/modals/Notes.tsx (+99 -0)
📝 packages/desktop-client/src/components/modals/SingleInput.tsx (+13 -2)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.jsx (+1 -1)
📝 packages/desktop-client/src/components/reports/reports/CustomReportCard.jsx (+1 -1)
📝 packages/desktop-client/src/components/util/GenericInput.jsx (+1 -1)
📝 packages/loot-core/src/client/actions/modals.ts (+4 -0)
📝 packages/loot-core/src/client/constants.ts (+1 -0)
📝 packages/loot-core/src/client/reducers/modals.ts (+12 -1)
📝 packages/loot-core/src/client/state-types/modals.d.ts (+34 -2)

...and 1 more files

📄 Description

Category Groups

image

image

image

image

Categories

image

image

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1964 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 11/23/2023 **Status:** ✅ Merged **Merged:** 12/22/2023 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `mobile-category-menu` --- ### 📝 Commits (10+) - [`63f1963`](https://github.com/actualbudget/actual/commit/63f19631ffc34f865b59565da4d44839b38473f2) Mobile category modal menu - [`6faeb27`](https://github.com/actualbudget/actual/commit/6faeb27bdb1594cdfe39d0d15dabf21952bad4a5) Release notes - [`fa544b3`](https://github.com/actualbudget/actual/commit/fa544b3078fc0c87cb0477e5891b5f09cdd9203f) Apply category and group modals - [`0df65e5`](https://github.com/actualbudget/actual/commit/0df65e559a30686ce130569b3b6d937d3fb4df12) Category modal updates + notes - [`f97ff58`](https://github.com/actualbudget/actual/commit/f97ff585021b2f0636927272e57518966bafb48a) Reduce notes modal view height - [`5783b8e`](https://github.com/actualbudget/actual/commit/5783b8e90e3a51cfef6e553ba989ddbda91597be) Update CategoryGroupMenu modal view height - [`e054161`](https://github.com/actualbudget/actual/commit/e054161537a8d465482e51aa1a6ada40fcb80381) Update CategoryMenu modal view height - [`be7f1f0`](https://github.com/actualbudget/actual/commit/be7f1f0a16e7e4fab27130457689cd7ee2f58cc9) Fix lint error - [`6c6d541`](https://github.com/actualbudget/actual/commit/6c6d5417725f270ce1f2fb758d23240b7cc76853) No notes text - [`ea4ff21`](https://github.com/actualbudget/actual/commit/ea4ff21996ed72b533cbfefe1dca6d5030755d13) Add budget-table testid on edit mode ### 📊 Changes **21 files changed** (+1162 additions, -836 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Modals.tsx` (+44 -2) ➕ `packages/desktop-client/src/components/Notes.tsx` (+133 -0) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+8 -104) 📝 `packages/desktop-client/src/components/budget/MobileBudget.jsx` (+114 -72) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.jsx` (+92 -625) 📝 `packages/desktop-client/src/components/common/Menu.tsx` (+10 -3) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+97 -19) ➕ `packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx` (+261 -0) ➕ `packages/desktop-client/src/components/modals/CategoryMenu.tsx` (+230 -0) 📝 `packages/desktop-client/src/components/modals/EditRule.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/ManageRulesModal.tsx` (+0 -2) ➕ `packages/desktop-client/src/components/modals/Notes.tsx` (+99 -0) 📝 `packages/desktop-client/src/components/modals/SingleInput.tsx` (+13 -2) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/reports/CustomReportCard.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/util/GenericInput.jsx` (+1 -1) 📝 `packages/loot-core/src/client/actions/modals.ts` (+4 -0) 📝 `packages/loot-core/src/client/constants.ts` (+1 -0) 📝 `packages/loot-core/src/client/reducers/modals.ts` (+12 -1) 📝 `packages/loot-core/src/client/state-types/modals.d.ts` (+34 -2) _...and 1 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> # Category Groups ![image](https://github.com/actualbudget/actual/assets/20313680/a206256c-cb66-449a-9085-719d108b69d3) ![image](https://github.com/actualbudget/actual/assets/20313680/0285fee1-93b8-4ce0-92b4-42c71b46269f) ![image](https://github.com/actualbudget/actual/assets/20313680/86c3a3ab-d607-40b2-af14-e4add4df6f20) ![image](https://github.com/actualbudget/actual/assets/20313680/8a32ff71-0ce6-442e-a2fd-26007810926a) # Categories ![image](https://github.com/actualbudget/actual/assets/20313680/451430f4-85a7-420b-b2b7-f169b02b5ed6) ![image](https://github.com/actualbudget/actual/assets/20313680/f8c5587f-ca60-4a7e-9b1c-36cbb1b0f4ba) ![image](https://github.com/actualbudget/actual/assets/20313680/abc10589-25f4-492c-9987-0c62d2590fa4) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:50:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4048