github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 08:52:49 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1946] [MERGED] [refactor] Migrate Discover schedules to tsx #4036

New Issue
Closed
opened 2026-02-28 20:50:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:50:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1946
Author: @muhsinkamil
Created: 11/21/2023
Status: ✅ Merged
Merged: 11/26/2023
Merged by: @MatissJanis

Base: master ← Head: refactor/1483-discover-schedules

📝 Commits (10+)

  • 094aa1c feat: add types for discover-schedule endpoint
  • c5ff081 refactor: move discover schedule component to tsx
  • 4c08f49 refactor: change type for useSelected event & remove log
  • 718f84c refactor(types): move entity def to d.ts file
  • 11377aa revert: remove the unwanted filter used for logging to useSelected
  • a00c7e4 chore: add release notes for the change
  • ecad163 refactor: provide type in useSendPlatformRequest to infer in usages
  • ae9f895 refactor: remove explicit type in runQuery
  • 298e438 Merge branch 'master' into refactor/1483-discover-schedules
  • b5aaa0e refactor: provide or type in schedule conditions

📊 Changes

9 files changed (+79 additions, -25 deletions)

View changed files

📝 packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx (+39 -18)
📝 packages/desktop-client/src/components/table.tsx (+1 -1)
📝 packages/desktop-client/src/hooks/useSelected.tsx (+3 -2)
📝 packages/desktop-client/src/hooks/useSendPlatformRequest.ts (+1 -1)
📝 packages/loot-core/src/client/reducers/budgets.ts (+0 -1)
📝 packages/loot-core/src/server/schedules/find-schedules.ts (+4 -1)
📝 packages/loot-core/src/server/schedules/types/handlers.ts (+3 -1)
📝 packages/loot-core/src/types/models/schedule.d.ts (+22 -0)
➕ upcoming-release-notes/1946.md (+6 -0)

📄 Description

Relates to https://github.com/actualbudget/actual/issues/1483

  • Migrate Discover schedules component to ts
  • Enrich types to the endpoint schedules/discover

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1946 **Author:** [@muhsinkamil](https://github.com/muhsinkamil) **Created:** 11/21/2023 **Status:** ✅ Merged **Merged:** 11/26/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `refactor/1483-discover-schedules` --- ### 📝 Commits (10+) - [`094aa1c`](https://github.com/actualbudget/actual/commit/094aa1c99191ef0a033536f623e52cfb7bd175c8) feat: add types for discover-schedule endpoint - [`c5ff081`](https://github.com/actualbudget/actual/commit/c5ff081832bc58632cd8f2778ffa2d137eaf1e19) refactor: move discover schedule component to tsx - [`4c08f49`](https://github.com/actualbudget/actual/commit/4c08f49f55fbf21f9c1299cc1fc35f351f3be27a) refactor: change type for useSelected event & remove log - [`718f84c`](https://github.com/actualbudget/actual/commit/718f84c1dc45b4899858b0ed6cea603c36f56293) refactor(types): move entity def to d.ts file - [`11377aa`](https://github.com/actualbudget/actual/commit/11377aa0c577cc04bd6401e8ee8ee838d6a17dea) revert: remove the unwanted filter used for logging to useSelected - [`a00c7e4`](https://github.com/actualbudget/actual/commit/a00c7e47b5449555b108459f5f13163e13e8c6a9) chore: add release notes for the change - [`ecad163`](https://github.com/actualbudget/actual/commit/ecad163f49c5c80093850067872e3db639e83d54) refactor: provide type in useSendPlatformRequest to infer in usages - [`ae9f895`](https://github.com/actualbudget/actual/commit/ae9f895bb29d48abb32ff87512b46698edb947d5) refactor: remove explicit type in runQuery - [`298e438`](https://github.com/actualbudget/actual/commit/298e43897a79083bcbc0b59f1d7094e21a74bbac) Merge branch 'master' into refactor/1483-discover-schedules - [`b5aaa0e`](https://github.com/actualbudget/actual/commit/b5aaa0e51e73ddd625b04b2a2508438cb30bed1c) refactor: provide or type in schedule conditions ### 📊 Changes **9 files changed** (+79 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx` (+39 -18) 📝 `packages/desktop-client/src/components/table.tsx` (+1 -1) 📝 `packages/desktop-client/src/hooks/useSelected.tsx` (+3 -2) 📝 `packages/desktop-client/src/hooks/useSendPlatformRequest.ts` (+1 -1) 📝 `packages/loot-core/src/client/reducers/budgets.ts` (+0 -1) 📝 `packages/loot-core/src/server/schedules/find-schedules.ts` (+4 -1) 📝 `packages/loot-core/src/server/schedules/types/handlers.ts` (+3 -1) 📝 `packages/loot-core/src/types/models/schedule.d.ts` (+22 -0) ➕ `upcoming-release-notes/1946.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Relates to https://github.com/actualbudget/actual/issues/1483 - [x] Migrate Discover schedules component to ts - [x] Enrich types to the endpoint `schedules/discover` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:50:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4036
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?