github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1927] [CLOSED] Remove unused args #4026

New Issue
Closed
opened 2026-02-28 20:50:28 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:50:28 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1927
Author: @jaas666
Created: 11/18/2023
Status: ❌ Closed

Base: master ← Head: jaas666/remove-unused-vars

📝 Commits (3)

  • 855e727 Enable args check under no-unused-vars rule
  • 2ed0cc3 Remove unused args
  • 28e129c Add release note

📊 Changes

78 files changed (+128 additions, -148 deletions)

View changed files

📝 .eslintrc.js (+2 -1)
📝 packages/desktop-client/craco.config.ts (+2 -2)
📝 packages/desktop-client/src/browser-preload.browser.js (+5 -5)
📝 packages/desktop-client/src/components/FixedSizeList.js (+3 -3)
📝 packages/desktop-client/src/components/ManageRules.tsx (+1 -1)
📝 packages/desktop-client/src/components/accounts/Account.js (+2 -2)
📝 packages/desktop-client/src/components/accounts/MobileAccount.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.js (+1 -1)
📝 packages/desktop-client/src/components/budget/MobileBudget.js (+1 -1)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+1 -1)
📝 packages/desktop-client/src/components/budget/SidebarCategory.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/SidebarGroup.tsx (+2 -3)
📝 packages/desktop-client/src/components/budget/index.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/report/components.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx (+1 -1)
📝 packages/desktop-client/src/components/common/Menu.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/MobileAmountInput.js (+1 -1)
📝 packages/desktop-client/src/components/modals/EditRule.js (+2 -2)

...and 58 more files

📄 Description

Should close #1907

No linting errors or warnings after changes but I'd still review carefully as there are a bunch of files with changes.

Also, there are two errors that I noticed when running tests but they don't seem to be related to changes on this PR. These errors might need new issues created.

Running npm run test:

[loot-core]: FAIL src/shared/util.test.ts
[loot-core]:   ● utility functions › number formatting works with space-comma format
[loot-core]: 
[loot-core]:     expect(received).toBe(expected) // Object.is equality
[loot-core]: 
[loot-core]:     Expected: "1 234,56"
[loot-core]:     Received: "1,234.56"
[loot-core]: 
[loot-core]:       69 |     let formatter = getNumberFormat().formatter;
[loot-core]:       70 |     // grouping separator space char is a non-breaking space, or UTF-16 \xa0
[loot-core]:     > 71 |     expect(formatter.format(Number('1234.56'))).toBe('1\xa0234,56');
[loot-core]:          |                                                 ^
[loot-core]:       72 |
[loot-core]:       73 |     setNumberFormat({ format: 'space-comma', hideFraction: true });
[loot-core]:       74 |     formatter = getNumberFormat().formatter;
[loot-core]: 
[loot-core]:       at Object.<anonymous> (src/shared/util.test.ts:71:49)

Running npm run typecheck:

packages/desktop-client/src/components/table.tsx:889:14 - error TS2322: Type 'ForwardRefExoticComponent<TableProps<TableItem> & RefAttributes<TableHandleRef>>' is not assignable to type '<T extends TableItem>(props: TableProps<T> & { ref?: Ref<TableHandleRef>; }) => ReactElement<any, string | JSXElementConstructor<any>>'.
  Type 'ReactNode' is not assignable to type 'ReactElement<any, string | JSXElementConstructor<any>>'.
    Type 'string' is not assignable to type 'ReactElement<any, string | JSXElementConstructor<any>>'.

889 export const Table: <T extends TableItem>(
                 ~~~~~


Found 1 error in packages/desktop-client/src/components/table.tsx:889

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1927 **Author:** [@jaas666](https://github.com/jaas666) **Created:** 11/18/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `jaas666/remove-unused-vars` --- ### 📝 Commits (3) - [`855e727`](https://github.com/actualbudget/actual/commit/855e72770061df9a27506a2a28946f3bd0dd063a) Enable args check under no-unused-vars rule - [`2ed0cc3`](https://github.com/actualbudget/actual/commit/2ed0cc3f381d48d27688e730521c4fa8cd193b11) Remove unused args - [`28e129c`](https://github.com/actualbudget/actual/commit/28e129c7faf79a597d20c61bfe4f1e37f48e62b6) Add release note ### 📊 Changes **78 files changed** (+128 additions, -148 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+2 -1) 📝 `packages/desktop-client/craco.config.ts` (+2 -2) 📝 `packages/desktop-client/src/browser-preload.browser.js` (+5 -5) 📝 `packages/desktop-client/src/components/FixedSizeList.js` (+3 -3) 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+2 -2) 📝 `packages/desktop-client/src/components/accounts/MobileAccount.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/MobileBudget.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/SidebarCategory.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/SidebarGroup.tsx` (+2 -3) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/report/components.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/common/Menu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/MobileAmountInput.js` (+1 -1) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+2 -2) _...and 58 more files_ </details> ### 📄 Description Should close #1907 No linting errors or warnings after changes but I'd still review carefully as there are a bunch of files with changes. Also, there are two errors that I noticed when running tests but they don't seem to be related to changes on this PR. These errors might need new issues created. Running `npm run test`: ``` [loot-core]: FAIL src/shared/util.test.ts [loot-core]: ● utility functions › number formatting works with space-comma format [loot-core]: [loot-core]: expect(received).toBe(expected) // Object.is equality [loot-core]: [loot-core]: Expected: "1 234,56" [loot-core]: Received: "1,234.56" [loot-core]: [loot-core]: 69 | let formatter = getNumberFormat().formatter; [loot-core]: 70 | // grouping separator space char is a non-breaking space, or UTF-16 \xa0 [loot-core]: > 71 | expect(formatter.format(Number('1234.56'))).toBe('1\xa0234,56'); [loot-core]: | ^ [loot-core]: 72 | [loot-core]: 73 | setNumberFormat({ format: 'space-comma', hideFraction: true }); [loot-core]: 74 | formatter = getNumberFormat().formatter; [loot-core]: [loot-core]: at Object.<anonymous> (src/shared/util.test.ts:71:49) ``` Running `npm run typecheck`: ``` packages/desktop-client/src/components/table.tsx:889:14 - error TS2322: Type 'ForwardRefExoticComponent<TableProps<TableItem> & RefAttributes<TableHandleRef>>' is not assignable to type '<T extends TableItem>(props: TableProps<T> & { ref?: Ref<TableHandleRef>; }) => ReactElement<any, string | JSXElementConstructor<any>>'. Type 'ReactNode' is not assignable to type 'ReactElement<any, string | JSXElementConstructor<any>>'. Type 'string' is not assignable to type 'ReactElement<any, string | JSXElementConstructor<any>>'. 889 export const Table: <T extends TableItem>( ~~~~~ Found 1 error in packages/desktop-client/src/components/table.tsx:889 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:50:28 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4026
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?