github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5060] [MERGED] Move more .d.ts files to .ts #40167

New Issue
Closed
opened 2026-04-23 13:03:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:03:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5060
Author: @jfdoming
Created: 5/25/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/move-d-ts-2

📝 Commits (9)

  • e910133 Move more .d.ts files to .ts
  • 49fd1a6 Add release notes
  • 50748c4 Some errors with templates snuck in
  • b6a90b2 Fix API build
  • f63422a CodeRabbit feedback
  • ca4e63a Move budget templates to new directory
  • f90c0cf Fix type errors in library module
  • 9f0131d Merge branch 'master' into jfdoming/move-d-ts-2
  • f030533 Merge branch 'master' into jfdoming/move-d-ts-2

📊 Changes

44 files changed (+82 additions, -60 deletions)

View changed files

📝 packages/api/tsconfig.dist.json (+1 -1)
📝 packages/desktop-client/src/browser-preload.browser.js (+1 -1)
📝 packages/desktop-client/src/components/App.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/goals/BudgetAutomation.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/CategoryAutomationButton.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/actions.ts (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/constants.ts (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/HistoricalAutomation.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/HistoricalAutomationReadOnly.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/PercentageAutomation.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/PercentageAutomationReadOnly.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/ScheduleAutomation.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/ScheduleAutomationReadOnly.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/SimpleAutomation.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/SimpleAutomationReadOnly.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/WeekAutomation.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/editor/WeekAutomationReadOnly.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/reducer.ts (+1 -1)
📝 packages/desktop-client/src/components/modals/BudgetAutomationsModal.tsx (+1 -1)
📝 packages/desktop-electron/index.ts (+1 -1)

...and 24 more files

📄 Description

In our current TypeScript configuration we don't type check .d.ts files. This has resulted in a number of type errors sneaking into the codebase. This PR moves a number of .d.ts files to regular .ts files and fixes the resulting type errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5060 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 5/25/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/move-d-ts-2` --- ### 📝 Commits (9) - [`e910133`](https://github.com/actualbudget/actual/commit/e910133b5062c00ad6e3e655f0e9aa9282c752e2) Move more .d.ts files to .ts - [`49fd1a6`](https://github.com/actualbudget/actual/commit/49fd1a637c764b9697b62fe9fddd7b19b101bbd0) Add release notes - [`50748c4`](https://github.com/actualbudget/actual/commit/50748c45cb391f158b53dddd01d094039dbf26a5) Some errors with templates snuck in - [`b6a90b2`](https://github.com/actualbudget/actual/commit/b6a90b2425f3fb8af7f22e05b912d980b97c55aa) Fix API build - [`f63422a`](https://github.com/actualbudget/actual/commit/f63422a98285a173fb2a0389fc3378bca6dddc55) CodeRabbit feedback - [`ca4e63a`](https://github.com/actualbudget/actual/commit/ca4e63a452265158cb6d0ae78703381b6dc0e6bf) Move budget templates to new directory - [`f90c0cf`](https://github.com/actualbudget/actual/commit/f90c0cf92284f8da8bd0395596c31356eb0f25e5) Fix type errors in library module - [`9f0131d`](https://github.com/actualbudget/actual/commit/9f0131d03603ddaba218780afc2c49e28be31258) Merge branch 'master' into jfdoming/move-d-ts-2 - [`f030533`](https://github.com/actualbudget/actual/commit/f030533b7de2eb6b4019666fc023348b2f3eca75) Merge branch 'master' into jfdoming/move-d-ts-2 ### 📊 Changes **44 files changed** (+82 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/tsconfig.dist.json` (+1 -1) 📝 `packages/desktop-client/src/browser-preload.browser.js` (+1 -1) 📝 `packages/desktop-client/src/components/App.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/goals/BudgetAutomation.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/CategoryAutomationButton.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/actions.ts` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/constants.ts` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/HistoricalAutomation.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/HistoricalAutomationReadOnly.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/PercentageAutomation.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/PercentageAutomationReadOnly.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/ScheduleAutomation.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/ScheduleAutomationReadOnly.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/SimpleAutomation.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/SimpleAutomationReadOnly.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/WeekAutomation.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/editor/WeekAutomationReadOnly.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/reducer.ts` (+1 -1) 📝 `packages/desktop-client/src/components/modals/BudgetAutomationsModal.tsx` (+1 -1) 📝 `packages/desktop-electron/index.ts` (+1 -1) _...and 24 more files_ </details> ### 📄 Description In our current TypeScript configuration we don't type check `.d.ts` files. This has resulted in a number of type errors sneaking into the codebase. This PR moves a number of `.d.ts` files to regular `.ts` files and fixes the resulting type errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:03:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#40167
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?