github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1888] [MERGED] [Maintenance] Goals break out goal target calculations to individual files #4007

New Issue
Closed
opened 2026-02-28 20:50:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:50:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1888
Author: @shall0pass
Created: 11/9/2023
Status: ✅ Merged
Merged: 11/11/2023
Merged by: @shall0pass

Base: master ← Head: goals_breakOutFunctions

📝 Commits (3)

📊 Changes

9 files changed (+536 additions, -364 deletions)

View changed files

➕ packages/loot-core/src/server/budget/goals/goalsBy.ts (+47 -0)
➕ packages/loot-core/src/server/budget/goals/goalsPercentage.ts (+55 -0)
➕ packages/loot-core/src/server/budget/goals/goalsRemainder.ts (+46 -0)
➕ packages/loot-core/src/server/budget/goals/goalsSchedule.ts (+169 -0)
➕ packages/loot-core/src/server/budget/goals/goalsSimple.ts (+31 -0)
➕ packages/loot-core/src/server/budget/goals/goalsSpend.ts (+52 -0)
➕ packages/loot-core/src/server/budget/goals/goalsWeek.ts (+36 -0)
📝 packages/loot-core/src/server/budget/goaltemplates.ts (+94 -364)
➕ upcoming-release-notes/1888.md (+6 -0)

📄 Description

This is mostly a reorganization attempt to reduce the line count of goaltemplates.ts and move the logic for calculating each type of template into it's own file. I think this could be useful when trying different logic, especially relating to schedules.

Test budget attached. It was exported in September, so the Income templates work best when applying the templates in that month.
2023-09-22-_goal template tests.zip

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1888 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 11/9/2023 **Status:** ✅ Merged **Merged:** 11/11/2023 **Merged by:** [@shall0pass](https://github.com/shall0pass) **Base:** `master` ← **Head:** `goals_breakOutFunctions` --- ### 📝 Commits (3) - [`4d38637`](https://github.com/actualbudget/actual/commit/4d38637419f7b1cdf8b5d731894b1486c5930c42) move goal calculations to separate files by type - [`245a7d4`](https://github.com/actualbudget/actual/commit/245a7d4aa1e1ceccf61c920da993e27ac920cc59) bug squashing - [`e6f7e91`](https://github.com/actualbudget/actual/commit/e6f7e917b19c3c1b2294e5487c2c20dcf647070c) release note ### 📊 Changes **9 files changed** (+536 additions, -364 deletions) <details> <summary>View changed files</summary> ➕ `packages/loot-core/src/server/budget/goals/goalsBy.ts` (+47 -0) ➕ `packages/loot-core/src/server/budget/goals/goalsPercentage.ts` (+55 -0) ➕ `packages/loot-core/src/server/budget/goals/goalsRemainder.ts` (+46 -0) ➕ `packages/loot-core/src/server/budget/goals/goalsSchedule.ts` (+169 -0) ➕ `packages/loot-core/src/server/budget/goals/goalsSimple.ts` (+31 -0) ➕ `packages/loot-core/src/server/budget/goals/goalsSpend.ts` (+52 -0) ➕ `packages/loot-core/src/server/budget/goals/goalsWeek.ts` (+36 -0) 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+94 -364) ➕ `upcoming-release-notes/1888.md` (+6 -0) </details> ### 📄 Description This is mostly a reorganization attempt to reduce the line count of goaltemplates.ts and move the logic for calculating each type of template into it's own file. I think this could be useful when trying different logic, especially relating to schedules. Test budget attached. It was exported in September, so the Income templates work best when applying the templates in that month. [2023-09-22-_goal template tests.zip](https://github.com/actualbudget/actual/files/13310573/2023-09-22-_goal.template.tests.zip) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:50:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4007
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?