github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #4267] [MERGED] Add "payee is nothing" condition to rule if there is no payee set in a schedule #39729

New Issue
Closed
opened 2026-04-23 12:40:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 12:40:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4267
Author: @matt-fidd
Created: 1/30/2025
Status: ✅ Merged
Merged: 3/4/2025
Merged by: @matt-fidd

Base: master ← Head: schedule-payee-null

📝 Commits (6)

  • 3fdde48 if no payee set in schedule, add payee = nothing to rule
  • 9485675 note
  • 4003c06 Merge branch 'master' into schedule-payee-null
  • 0e13e9e Merge branch 'master' into schedule-payee-null
  • 08b70e4 Merge branch 'master' into schedule-payee-null
  • edfafd2 Merge branch 'master' into schedule-payee-null

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/schedules/ScheduleDetails.tsx (+1 -1)
➕ upcoming-release-notes/4267.md (+6 -0)

📄 Description

Fixes https://github.com/actualbudget/actual/issues/1616

Repro instructions copied from the issue:

  1. Create a schedule that is due and assign to an account
  2. Leave payee field empty
  3. Add new transaction to the account used in step 1 and set its payee

image
image

Caused by the schedule rule creation skipping adding conditions for null fields, but in this case we should retain the payee=null check to avoid accidentally matching other transactions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4267 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 3/4/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `schedule-payee-null` --- ### 📝 Commits (6) - [`3fdde48`](https://github.com/actualbudget/actual/commit/3fdde4819a951b8bd7e9bbb1cceb8b288fd4d626) if no payee set in schedule, add payee = nothing to rule - [`9485675`](https://github.com/actualbudget/actual/commit/94856756150301fc59bc39e5da2b617f391d2ae6) note - [`4003c06`](https://github.com/actualbudget/actual/commit/4003c06b1f95c292982a2dbea16b61b57165802c) Merge branch 'master' into schedule-payee-null - [`0e13e9e`](https://github.com/actualbudget/actual/commit/0e13e9e8f4fd754defbe899b98a9dbf83b89628a) Merge branch 'master' into schedule-payee-null - [`08b70e4`](https://github.com/actualbudget/actual/commit/08b70e4dc518e486784cdafbbc2e7195a26a20f5) Merge branch 'master' into schedule-payee-null - [`edfafd2`](https://github.com/actualbudget/actual/commit/edfafd26372a756818d2eb90220db1c110f00804) Merge branch 'master' into schedule-payee-null ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/schedules/ScheduleDetails.tsx` (+1 -1) ➕ `upcoming-release-notes/4267.md` (+6 -0) </details> ### 📄 Description Fixes https://github.com/actualbudget/actual/issues/1616 Repro instructions copied from the issue: > 1. Create a schedule that is due and assign to an account > 2. Leave payee field empty > 3. Add new transaction to the account used in step 1 and set its payee > > ![image](https://github.com/actualbudget/actual/assets/20313680/92921ec1-b810-4c4a-94be-1c1a46c93593) > ![image](https://github.com/actualbudget/actual/assets/20313680/5a602949-6a10-4777-b1ab-673b902743ae) Caused by the schedule rule creation skipping adding conditions for null fields, but in this case we should retain the payee=null check to avoid accidentally matching other transactions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 12:40:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#39729
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?