github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 12:30:06 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1785] [MERGED] Maintenance: Updating icons generator to output typescript #3956

New Issue
Closed
opened 2026-02-28 20:49:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:49:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1785
Author: @MikesGlitch
Created: 10/11/2023
Status: ✅ Merged
Merged: 10/19/2023
Merged by: @MatissJanis

Base: master ← Head: maintenance/ts-icons

📝 Commits (2)

  • 2892115 updating icons generator to typescript
  • 1b85c93 add release notes

📊 Changes

368 files changed (+1098 additions, -365 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -1)
📝 packages/desktop-client/src/icons/logo/Logo.tsx (+2 -1)
➕ packages/desktop-client/src/icons/logo/index.ts (+1 -0)
📝 packages/desktop-client/src/icons/v0/Add.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v0/Delete.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v0/ExpandArrow.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v0/LeftArrow2.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v0/Math.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v0/Merge.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v0/RightArrow2.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v0/Split.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v0/Subtract.tsx (+2 -1)
➕ packages/desktop-client/src/icons/v0/index.ts (+9 -0)
📝 packages/desktop-client/src/icons/v1/Add.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v1/AddOutline.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v1/AddSolid.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v1/Adjust.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v1/Airplane.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v1/Album.tsx (+2 -1)
📝 packages/desktop-client/src/icons/v1/AlignCenter.tsx (+2 -1)

...and 80 more files

📄 Description

So we currently use: Zondicons. Right now we have about 368 generated files based on that icon set - that's why the pr is huge.

All these files are generated with the following command:

"generate:icons": "rm src/icons/*/*.tsx; cd src/icons && svgr --typescript --expand-props start -d . .",

This PR just converts the js files to tsx.

To reduce the size of this PR we could delete the icons we don't use - that would make it harder when adding new icons to the UI in the future.

Another approach

We could use a package like styled-icons to get the zondicons into the project, and then delete all 368 of our icon files (because we'd be using the package instead). Then we wouldn't have to maintain these.

Open to thoughts

https://github.com/actualbudget/actual/issues/1483

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1785 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 10/11/2023 **Status:** ✅ Merged **Merged:** 10/19/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `maintenance/ts-icons` --- ### 📝 Commits (2) - [`2892115`](https://github.com/actualbudget/actual/commit/2892115ffe3a2c41d7a360603a0f3a13ab49d703) updating icons generator to typescript - [`1b85c93`](https://github.com/actualbudget/actual/commit/1b85c93f057758912c6abf8da0b77f22bd626645) add release notes ### 📊 Changes **368 files changed** (+1098 additions, -365 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -1) 📝 `packages/desktop-client/src/icons/logo/Logo.tsx` (+2 -1) ➕ `packages/desktop-client/src/icons/logo/index.ts` (+1 -0) 📝 `packages/desktop-client/src/icons/v0/Add.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v0/Delete.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v0/ExpandArrow.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v0/LeftArrow2.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v0/Math.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v0/Merge.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v0/RightArrow2.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v0/Split.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v0/Subtract.tsx` (+2 -1) ➕ `packages/desktop-client/src/icons/v0/index.ts` (+9 -0) 📝 `packages/desktop-client/src/icons/v1/Add.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v1/AddOutline.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v1/AddSolid.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v1/Adjust.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v1/Airplane.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v1/Album.tsx` (+2 -1) 📝 `packages/desktop-client/src/icons/v1/AlignCenter.tsx` (+2 -1) _...and 80 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> So we currently use: [Zondicons](https://www.zondicons.com/). Right now we have about 368 generated files based on that icon set - that's why the pr is huge. All these files are generated with the following command: ``` "generate:icons": "rm src/icons/*/*.tsx; cd src/icons && svgr --typescript --expand-props start -d . .", ``` This PR just converts the js files to tsx. To reduce the size of this PR we could delete the icons we don't use - that would make it harder when adding new icons to the UI in the future. ## Another approach We could use a package like [styled-icons](https://github.com/styled-icons/styled-icons) to get the zondicons into the project, and then delete all 368 of our icon files (because we'd be using the package instead). Then we wouldn't have to maintain these. Open to thoughts https://github.com/actualbudget/actual/issues/1483 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:49:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3956
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?