github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #3603] [MERGED] Fixes #2703 - Fixes inaccurate running balance when hiding reconciled transactions #39382

New Issue
Closed
opened 2026-04-23 12:19:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 12:19:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3603
Author: @wysinder
Created: 10/8/2024
Status: ✅ Merged
Merged: 10/8/2024
Merged by: @youngcw

Base: master ← Head: fix-2703

📝 Commits (3)

  • 28dc971 Show accurate balances when hiding reconciled transactions.
  • f2a6a08 Linting
  • 64b8d87 Add release notes

📊 Changes

4 files changed (+26 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+7 -2)
📝 packages/desktop-client/src/components/transactions/TransactionList.jsx (+3 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.jsx (+10 -1)
➕ upcoming-release-notes/3603.md (+6 -0)

📄 Description

Fixes #2703 to show an account's running balance accurately when hiding its reconciled transactions. This addresses the use case of wanting to hide reconciled transactions (to keep them off of mind) and still showing the account's running balance.

Implementation notes:

  • This fix changes updateQuery to not filter out reconciled transactions, but defers the filtering downstream to TransactionsTable instead (which now takes the showReconciled prop accordingly).
  • This allows us to call calculateBalances on the full set of account transactions. Previously, calculateBalances would be executed on only the rendered transactions, which meant the calculation would not reflect the account's actual balance.
  • This does not break the existing behaviour that hides running balances when searching, filtering, or sorting (canCalculateBalance is respected).

Preview build screenshots:

Show running balance + Show reconciled transactions:
image

[PREVIOUS TO THIS FIX] Show running balance + Hide reconciled transactions (inaccurate running balance):
image

[WITH THIS FIX] Show running balance + Hide reconciled transactions (running balance is now accurate):
image

Show running balance + Hide reconciled transactions + Reconciled transaction in between two other transactions (shows accurate running balance on that day):
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3603 **Author:** [@wysinder](https://github.com/wysinder) **Created:** 10/8/2024 **Status:** ✅ Merged **Merged:** 10/8/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix-2703` --- ### 📝 Commits (3) - [`28dc971`](https://github.com/actualbudget/actual/commit/28dc971db0ab2cbb8db82a2484f5e69acab11274) Show accurate balances when hiding reconciled transactions. - [`f2a6a08`](https://github.com/actualbudget/actual/commit/f2a6a082121cee8ab138f759b97bfaaa0ef6486e) Linting - [`64b8d87`](https://github.com/actualbudget/actual/commit/64b8d8724ed153981eaf26fc547a5cd322fbf657) Add release notes ### 📊 Changes **4 files changed** (+26 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+7 -2) 📝 `packages/desktop-client/src/components/transactions/TransactionList.jsx` (+3 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.jsx` (+10 -1) ➕ `upcoming-release-notes/3603.md` (+6 -0) </details> ### 📄 Description Fixes #2703 to show an account's running balance accurately when hiding its reconciled transactions. This addresses the use case of wanting to hide reconciled transactions (to keep them off of mind) and still showing the account's running balance. ### Implementation notes: * This fix changes `updateQuery` to _not_ filter out reconciled transactions, but defers the filtering downstream to `TransactionsTable` instead (which now takes the `showReconciled` prop accordingly). * This allows us to call `calculateBalances` on the full set of account transactions. Previously, `calculateBalances` would be executed on only the rendered transactions, which meant the calculation would not reflect the account's actual balance. * This does not break the existing behaviour that hides running balances when searching, filtering, or sorting (`canCalculateBalance` is respected). ### Preview build screenshots: Show running balance + Show reconciled transactions: ![image](https://github.com/user-attachments/assets/75ac4739-2918-4bf5-bd5a-b5ad68f6fee4) [PREVIOUS TO THIS FIX] Show running balance + Hide reconciled transactions (inaccurate running balance): ![image](https://github.com/user-attachments/assets/d6e35ac5-7132-41f5-ad78-271508b361de) [WITH THIS FIX] Show running balance + Hide reconciled transactions (running balance is now accurate): ![image](https://github.com/user-attachments/assets/e5f07cc3-0a37-4044-ba1d-70aceb383a85) Show running balance + Hide reconciled transactions + Reconciled transaction in between two other transactions (shows accurate running balance on that day): ![image](https://github.com/user-attachments/assets/6369e1fa-b751-405d-84d4-b8378114de77) <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 12:19:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#39382
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?