github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1724] [MERGED] Consolidate Notice Colors #3922

New Issue
Closed
opened 2026-02-28 20:48:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:48:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1724
Author: @carkom
Created: 9/22/2023
Status: ✅ Merged
Merged: 10/4/2023
Merged by: @MatissJanis

Base: master ← Head: noticeColorConsolidation

📝 Commits (4)

  • 300e11b Consolidate Notice Colors
  • 7428917 Merge branch 'master' into noticeColorConsolidation
  • c273afb notes
  • 02b02af Merge branch 'master' into noticeColorConsolidation

📊 Changes

24 files changed (+58 additions, -52 deletions)

View changed files

📝 packages/desktop-client/src/components/Notifications.tsx (+4 -4)
📝 packages/desktop-client/src/components/accounts/Balance.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/Reconcile.js (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js (+1 -1)
📝 packages/desktop-client/src/components/budget/report/BudgetSummary.tsx (+2 -2)
📝 packages/desktop-client/src/components/manager/subscribe/ChangePassword.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsg.js (+2 -2)
📝 packages/desktop-client/src/components/modals/ImportTransactions.js (+1 -1)
📝 packages/desktop-client/src/components/modals/PlaidExternalMsg.js (+2 -2)
📝 packages/desktop-client/src/components/payees/index.js (+1 -1)
📝 packages/desktop-client/src/components/reports/Change.js (+1 -1)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.tsx (+1 -1)
📝 packages/desktop-client/src/components/schedules/StatusBadge.tsx (+5 -5)
📝 packages/desktop-client/src/components/settings/Encryption.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/FixSplits.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/index.tsx (+1 -1)
📝 packages/desktop-client/src/components/transactions/MobileTransaction.js (+3 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.js (+2 -2)

...and 4 more files

📄 Description

This is a proof of concept for consolidating colors to make the apps color scheme more consistent. We are using 5 different shades of dark green for text fields. Looking to slim this down to 3 and consolidate background colors a bit as well and clean up the naming standards.

It should also help to make the palette more compact allowing for easier creation of more themes.

There are places where the color hasn't actually changed but the name of the color has. I'll try to point out the bits where the color has changed by one shade so you don't have to review all the ones where color is the same but name is different.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1724 **Author:** [@carkom](https://github.com/carkom) **Created:** 9/22/2023 **Status:** ✅ Merged **Merged:** 10/4/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `noticeColorConsolidation` --- ### 📝 Commits (4) - [`300e11b`](https://github.com/actualbudget/actual/commit/300e11b8f20fb7182d04e9b8278a9e6b1bfaa3a5) Consolidate Notice Colors - [`7428917`](https://github.com/actualbudget/actual/commit/742891759ecb3a162f2d04c7b57921b44cb28ab1) Merge branch 'master' into noticeColorConsolidation - [`c273afb`](https://github.com/actualbudget/actual/commit/c273afb39c739394a9e25b530fe42574c85d761b) notes - [`02b02af`](https://github.com/actualbudget/actual/commit/02b02af9e2fda20e6a4fbe891a9d73b737a439a1) Merge branch 'master' into noticeColorConsolidation ### 📊 Changes **24 files changed** (+58 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Notifications.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/accounts/Balance.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Reconcile.js` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/report/BudgetSummary.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/manager/subscribe/ChangePassword.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsg.js` (+2 -2) 📝 `packages/desktop-client/src/components/modals/ImportTransactions.js` (+1 -1) 📝 `packages/desktop-client/src/components/modals/PlaidExternalMsg.js` (+2 -2) 📝 `packages/desktop-client/src/components/payees/index.js` (+1 -1) 📝 `packages/desktop-client/src/components/reports/Change.js` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/StatusBadge.tsx` (+5 -5) 📝 `packages/desktop-client/src/components/settings/Encryption.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/FixSplits.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/index.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/MobileTransaction.js` (+3 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.js` (+2 -2) _...and 4 more files_ </details> ### 📄 Description This is a proof of concept for consolidating colors to make the apps color scheme more consistent. We are using 5 different shades of dark green for text fields. Looking to slim this down to 3 and consolidate background colors a bit as well and clean up the naming standards. It should also help to make the palette more compact allowing for easier creation of more themes. There are places where the color hasn't actually changed but the name of the color has. I'll try to point out the bits where the color has changed by one shade so you don't have to review all the ones where color is the same but name is different. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:48:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3922
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?