github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #2760] [CLOSED] Use GoCardless remittanceInformationStructured for notes if available #38924

New Issue
Closed
opened 2026-04-23 11:54:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 11:54:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2760
Author: @matt-fidd
Created: 5/15/2024
Status: ❌ Closed

Base: master ← Head: remittance-structured

📝 Commits (3)

  • 474e7b1 Use GoCardless remittanceInformationStructured for notes if available
  • 34d4523 release note
  • 2ccea5f Merge branch 'master' into remittance-structured

📊 Changes

2 files changed (+9 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.ts (+3 -1)
➕ upcoming-release-notes/2760.md (+6 -0)

📄 Description

Closes #2759

Following a discussion in Discord it looks like BELADEBEXXX does not provide remittanceInformationUnstructured at all and just returns remittanceInformationStructured. The notes field should pick this up if it exists.

The GoCardless docs are vague on what this field contains and I can't seem to find the structure mentioned in them but (at least in this case) the data appears similar or the same to what we'd normally see in the unstructured version.

image

If #2721 and actualbudget/actual-server#353 are merged there's probably another conversation to be had regarding whether it's worth moving this over to actual-server too.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2760 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 5/15/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `remittance-structured` --- ### 📝 Commits (3) - [`474e7b1`](https://github.com/actualbudget/actual/commit/474e7b141f2dde6621667dc38f8658cb39b2e887) Use GoCardless remittanceInformationStructured for notes if available - [`34d4523`](https://github.com/actualbudget/actual/commit/34d45236a3835424cca050ad8a6135f9431adb9a) release note - [`2ccea5f`](https://github.com/actualbudget/actual/commit/2ccea5fa8307c45cb4de51a2a5f6633e0aaf380a) Merge branch 'master' into remittance-structured ### 📊 Changes **2 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.ts` (+3 -1) ➕ `upcoming-release-notes/2760.md` (+6 -0) </details> ### 📄 Description Closes #2759 Following a discussion in Discord it looks like `BELADEBEXXX` does not provide `remittanceInformationUnstructured` at all and just returns `remittanceInformationStructured`. The notes field should pick this up if it exists. The GoCardless docs are vague on what this field contains and I can't seem to find the structure mentioned in them but (at least in this case) the data appears similar or the same to what we'd normally see in the unstructured version. ![image](https://github.com/actualbudget/actual/assets/81489167/5ce48b9b-3fcf-4be2-bd5d-3057a7437385) If #2721 and actualbudget/actual-server#353 are merged there's probably another conversation to be had regarding whether it's worth moving this over to `actual-server` too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 11:54:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#38924
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?