github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-30 17:10:00 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #1671] [CLOSED] TypeScript migration (partial). #3887

New Issue
Closed
opened 2026-02-28 20:48:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:48:19 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1671
Author: @doggan
Created: 9/7/2023
Status: ❌ Closed

Base: master ← Head: shyam/0907-ts

📝 Commits (10+)

📊 Changes

21 files changed (+82 additions, -76 deletions)

View changed files

📝 packages/desktop-client/src/components/AnimatedRefresh.tsx (+3 -1)
📝 packages/desktop-client/src/components/FatalError.tsx (+3 -1)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+3 -3)
📝 packages/desktop-client/src/components/Notifications.tsx (+1 -1)
📝 packages/desktop-client/src/components/alerts.tsx (+1 -1)
📝 packages/desktop-client/src/components/common/MenuButton.tsx (+5 -1)
📝 packages/desktop-client/src/components/manager/ConfigServer.tsx (+4 -4)
📝 packages/desktop-client/src/components/manager/ImportActual.tsx (+1 -1)
📝 packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx (+4 -4)
📝 packages/desktop-client/src/components/manager/subscribe/ChangePassword.tsx (+5 -5)
📝 packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx (+12 -2)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/FixSplits.tsx (+1 -1)
📝 packages/desktop-client/src/components/sidebar/ItemContent.tsx (+3 -3)
📝 packages/desktop-client/src/components/sort.tsx (+1 -23)
➖ packages/desktop-client/src/hooks/useMergedRefs.js (+0 -17)
➕ packages/desktop-client/src/hooks/useMergedRefs.ts (+25 -0)
📝 packages/loot-core/src/client/actions/budgets.ts (+1 -1)
📝 packages/loot-core/src/shared/transactions.ts (+2 -2)
📝 packages/loot-core/src/shared/util.ts (+0 -4)

...and 1 more files

📄 Description

Working through some of the TypeScript migrations/hardening when running yarn tsc --strict.

Found 3531 errors in 249 files. -> Found 3500 errors in 240 files.

Related: https://github.com/actualbudget/actual/issues/1483

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1671 **Author:** [@doggan](https://github.com/doggan) **Created:** 9/7/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `shyam/0907-ts` --- ### 📝 Commits (10+) - [`943a219`](https://github.com/actualbudget/actual/commit/943a21945624f3828254ca74ee79bfc443f2c898) tsc error fixes - [`f35ed4d`](https://github.com/actualbudget/actual/commit/f35ed4dffecfb4c1c31a846ceec6e1524c4541cc) tsc error fixes - [`bb092d9`](https://github.com/actualbudget/actual/commit/bb092d963bbe93e7a1104551c8ed318d0f7f647e) tsc error fixes - [`e8a8b9a`](https://github.com/actualbudget/actual/commit/e8a8b9ac492590dcd17207199898454f4f38d79a) tsc error fixes - [`1b483df`](https://github.com/actualbudget/actual/commit/1b483df9f645c3b61459eeb6b4e64d3bd450e821) tsc error fixes - [`858633f`](https://github.com/actualbudget/actual/commit/858633fdc0cacf0ff3239fc8804aed0a419a1cb0) tsc error fixes - [`b03b42f`](https://github.com/actualbudget/actual/commit/b03b42ff82f1fc1f523f309c6995564f294c86bd) Merge branch 'master' into shyam/0907-ts - [`016b510`](https://github.com/actualbudget/actual/commit/016b510628e0b884c7dd86ad56c22e2a035c9181) Release notes. - [`9e533b4`](https://github.com/actualbudget/actual/commit/9e533b421f3a3fcb9d8cbd20f931055614e25e5a) remove last - [`f4a7c75`](https://github.com/actualbudget/actual/commit/f4a7c75eca8ea2016cf07607772065d9246c1a8f) remove import ### 📊 Changes **21 files changed** (+82 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/AnimatedRefresh.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/FatalError.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/alerts.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/common/MenuButton.tsx` (+5 -1) 📝 `packages/desktop-client/src/components/manager/ConfigServer.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/manager/ImportActual.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/manager/subscribe/ChangePassword.tsx` (+5 -5) 📝 `packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx` (+12 -2) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/FixSplits.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/sidebar/ItemContent.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/sort.tsx` (+1 -23) ➖ `packages/desktop-client/src/hooks/useMergedRefs.js` (+0 -17) ➕ `packages/desktop-client/src/hooks/useMergedRefs.ts` (+25 -0) 📝 `packages/loot-core/src/client/actions/budgets.ts` (+1 -1) 📝 `packages/loot-core/src/shared/transactions.ts` (+2 -2) 📝 `packages/loot-core/src/shared/util.ts` (+0 -4) _...and 1 more files_ </details> ### 📄 Description Working through some of the TypeScript migrations/hardening when running `yarn tsc --strict`. `Found 3531 errors in 249 files. -> Found 3500 errors in 240 files.` Related: https://github.com/actualbudget/actual/issues/1483 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:48:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3887