github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2643] [MERGED] Fix amount filter to include both incoming and outgoing amounts #38860

New Issue
Closed
opened 2026-04-23 11:51:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 11:51:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2643
Author: @mirdaki
Created: 4/20/2024
Status: ✅ Merged
Merged: 5/16/2024
Merged by: @youngcw

Base: master ← Head: updateFilterAmountToFilterIncomingAndOutgoing

📝 Commits (8)

📊 Changes

3 files changed (+69 additions, -14 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/transaction-rules.test.ts (+49 -3)
📝 packages/loot-core/src/server/accounts/transaction-rules.ts (+14 -11)
➕ upcoming-release-notes/2643.md (+6 -0)

📄 Description

Hi folks, this address #1935, which had some confusing UX. I also added some simple tests to verify the behavior.

I want to acknowledge that changing it in the transaction rules may not be the best spot, I don't have a ton of context on this repo yet. I also considered updating the filter to allow using oneOf behind the scenes for the number type, but that seemed to have more knock on effects that weren't as obvious.

Happy to update the logic if there is a better approach. Thank you!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2643 **Author:** [@mirdaki](https://github.com/mirdaki) **Created:** 4/20/2024 **Status:** ✅ Merged **Merged:** 5/16/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `updateFilterAmountToFilterIncomingAndOutgoing` --- ### 📝 Commits (8) - [`1f292df`](https://github.com/actualbudget/actual/commit/1f292df6602dc293782c22ec25d5213cf6c70111) Update filter amount to filter incoming and outgoing transactions - [`18051f8`](https://github.com/actualbudget/actual/commit/18051f8c92dcd5ae7bce6cf8fc2583b8ec4dbdf2) Add test and fix logic - [`328a6fd`](https://github.com/actualbudget/actual/commit/328a6fd4428e06b71da656f71f226d33f778da67) Added release note - [`1c1f6a1`](https://github.com/actualbudget/actual/commit/1c1f6a14c72f3e3fbb5dc58cd089e9bc56a98dcf) Update with linter fixes - [`18a012b`](https://github.com/actualbudget/actual/commit/18a012b889c5e1efc023f9db9b409e6aa6e141e7) Update new ammount filter to apply to all ops - [`39bd37e`](https://github.com/actualbudget/actual/commit/39bd37e88a8868ba883874605b03efa9000664fe) Fix lint - [`a9acc19`](https://github.com/actualbudget/actual/commit/a9acc1932c139cdb3ec6d4d7ef515e89d36e1186) Merge remote-tracking branch 'origin/master' into updateFilterAmountToFilterIncomingAndOutgoing - [`0be7477`](https://github.com/actualbudget/actual/commit/0be747785ee818cad90300164ddd75f2cbef5fb7) Merge branch 'master' of https://github.com/actualbudget/actual into updateFilterAmountToFilterIncomingAndOutgoing ### 📊 Changes **3 files changed** (+69 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/transaction-rules.test.ts` (+49 -3) 📝 `packages/loot-core/src/server/accounts/transaction-rules.ts` (+14 -11) ➕ `upcoming-release-notes/2643.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Hi folks, this address #1935, which had some confusing UX. I also added some simple tests to verify the behavior. I want to acknowledge that changing it in the transaction rules may not be the best spot, I don't have a ton of context on this repo yet. I also considered updating the filter to allow using `oneOf` behind the scenes for the number type, but that seemed to have more knock on effects that weren't as obvious. Happy to update the logic if there is a better approach. Thank you! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 11:51:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#38860
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?