github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1571] [MERGED] 🐛 Schedule editor: Linked transactions table collapses #3825

New Issue
Closed
opened 2026-02-28 20:47:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:47:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1571
Author: @trevdor
Created: 8/23/2023
Status: ✅ Merged
Merged: 8/24/2023
Merged by: @trevdor

Base: master ← Head: trevdor-schedules-table-collapse

📝 Commits (5)

  • bdf9cd4 Handle empty state in linked transaction mode
  • 4b14c6a Use theme values for colors
  • 72f9e8f Table still collapses with empty state
  • 6062567 Release notes
  • 2615dc9 fixup! Table still collapses with empty state

📊 Changes

3 files changed (+56 additions, -28 deletions)

View changed files

📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+44 -27)
📝 packages/desktop-client/src/components/table.tsx (+6 -1)
➕ upcoming-release-notes/1571.md (+6 -0)

📄 Description

Problem

h/t @Kidglove57 for noticing this.
The Schedules table in the Link Schedules modal gets squished to 0px height by the AutoSizer in <Table>, even if it has rows in it. In fact, the empty state "No transactions found" is the only situation where this table renders with a proper height.

Screenshot 2023-08-22 at 10 10 33 PM

Solution

  1. Fix the empty state to be able to render whether we're looking at Linked or Matched transactions.
  2. Give <Table> a flex-basis equal to the row height multiplied by the number of rows, but let it flex grow AND shrink.

Concerns

I don't like messing with <Table>, since it's used for Accounts transactions lists and several other places. But I verified the height comes out as expected in every spot where it's used. Large transaction lists may get a flex basis of 6000px+, but they flex shrink to fit within the virtualized list container.

Definitely open to alternate suggestions here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1571 **Author:** [@trevdor](https://github.com/trevdor) **Created:** 8/23/2023 **Status:** ✅ Merged **Merged:** 8/24/2023 **Merged by:** [@trevdor](https://github.com/trevdor) **Base:** `master` ← **Head:** `trevdor-schedules-table-collapse` --- ### 📝 Commits (5) - [`bdf9cd4`](https://github.com/actualbudget/actual/commit/bdf9cd40a23bbb8c92c346e256c3068e62d20e41) Handle empty state in linked transaction mode - [`4b14c6a`](https://github.com/actualbudget/actual/commit/4b14c6a472c1a1b0966ffb358f42270c29b86497) Use theme values for colors - [`72f9e8f`](https://github.com/actualbudget/actual/commit/72f9e8f177244bce1bf0e7eef7944882e15221db) Table still collapses with empty state - [`6062567`](https://github.com/actualbudget/actual/commit/6062567d5987ee3f4dd250ad3de1cdbdf0806542) Release notes - [`2615dc9`](https://github.com/actualbudget/actual/commit/2615dc986b22d0cb6833c0cbab9b2e13da9f99df) fixup! Table still collapses with empty state ### 📊 Changes **3 files changed** (+56 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+44 -27) 📝 `packages/desktop-client/src/components/table.tsx` (+6 -1) ➕ `upcoming-release-notes/1571.md` (+6 -0) </details> ### 📄 Description ### Problem h/t @Kidglove57 for [noticing this](https://github.com/actualbudget/actual/pull/1501#issuecomment-1686770556). The Schedules table in the Link Schedules modal gets squished to 0px height by the AutoSizer in `<Table>`, even if it has rows in it. In fact, the empty state "No transactions found" is the only situation where this table renders with a proper height. <img width="680" alt="Screenshot 2023-08-22 at 10 10 33 PM" src="https://github.com/actualbudget/actual/assets/5862724/e0235537-2772-4b23-921f-f3359be8d31a"> ### Solution 1. Fix the empty state to be able to render whether we're looking at Linked or Matched transactions. 2. Give `<Table>` a flex-basis equal to the row height multiplied by the number of rows, but let it flex grow AND shrink. ### Concerns I don't like messing with `<Table>`, since it's used for Accounts transactions lists and several other places. But I verified the height comes out as expected in every spot where it's used. Large transaction lists may get a flex basis of 6000px+, but they flex shrink to fit within the virtualized list container. Definitely open to alternate suggestions here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:47:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3825
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?