github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #1184] [MERGED] Consistently use ExternalLink #38006

New Issue
Closed
opened 2026-04-23 11:08:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 11:08:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1184
Author: @j-f1
Created: 6/25/2023
Status: ✅ Merged
Merged: 6/27/2023
Merged by: @j-f1

Base: master ← Head: jed/external-link

📝 Commits (10+)

📊 Changes

24 files changed (+193 additions, -218 deletions)

View changed files

📝 .eslintrc.js (+6 -0)
📝 packages/desktop-client/src/components/FatalError.js (+28 -16)
📝 packages/desktop-client/src/components/ManageRules.js (+13 -16)
📝 packages/desktop-client/src/components/Notifications.js (+4 -5)
📝 packages/desktop-client/src/components/Titlebar.js (+5 -8)
📝 packages/desktop-client/src/components/UpdateNotification.js (+5 -5)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.js (+3 -7)
📝 packages/desktop-client/src/components/common.tsx (+30 -38)
📝 packages/desktop-client/src/components/manager/ImportYNAB5.js (+1 -5)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+0 -1)
📝 packages/desktop-client/src/components/manager/WelcomeScreen.js (+7 -5)
📝 packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx (+3 -8)
📝 packages/desktop-client/src/components/modals/CloseAccount.js (+13 -7)
📝 packages/desktop-client/src/components/modals/CreateAccount.js (+17 -11)
📝 packages/desktop-client/src/components/modals/CreateEncryptionKey.js (+2 -8)
📝 packages/desktop-client/src/components/modals/CreateLocalAccount.js (+5 -8)
📝 packages/desktop-client/src/components/modals/FixEncryptionKey.js (+2 -8)
📝 packages/desktop-client/src/components/modals/NordigenExternalMsg.js (+18 -17)
📝 packages/desktop-client/src/components/modals/NordigenInitialise.tsx (+2 -8)
📝 packages/desktop-client/src/components/settings/Encryption.js (+9 -25)

...and 4 more files

📄 Description

This cleans up all of the usage of <a> in the codebase. Now all external links get the appropriate attributes added.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1184 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/25/2023 **Status:** ✅ Merged **Merged:** 6/27/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/external-link` --- ### 📝 Commits (10+) - [`50b740a`](https://github.com/actualbudget/actual/commit/50b740a2b1aea9ad7115bbf97b1970b01fe161a5) Remove non-asAnchor ExternalLink support - [`a8e540d`](https://github.com/actualbudget/actual/commit/a8e540dabc06764a11e412e0426ba5c982379721) Use native link open behavior - [`24aff3a`](https://github.com/actualbudget/actual/commit/24aff3acaf65354ff087efa6f315ac02eda76cbd) use to as prop name for ExternalLink - [`3d6e029`](https://github.com/actualbudget/actual/commit/3d6e0293acf62aea32e1f3c053849b24374b7a98) Add link color support - [`7ba3de6`](https://github.com/actualbudget/actual/commit/7ba3de6100071bdae5600c284735220b90ac00c2) Port <a> usage to <ExternalLink> - [`7e7c361`](https://github.com/actualbudget/actual/commit/7e7c361c7fff0cd6cf409d7b3d09e924ce5d897d) Remove stray href prop - [`5180ba9`](https://github.com/actualbudget/actual/commit/5180ba9744327cf7684de5a23d2dfc2c5810ec9c) Run Prettier on eslintrc - [`c522b36`](https://github.com/actualbudget/actual/commit/c522b364b6ffde9d7f6878180155bce0fe1aec70) forbid <a> in favor of <Link> or <ExternalLink> - [`102e770`](https://github.com/actualbudget/actual/commit/102e770935eae396a3b9a26615d44abca7402dec) Add a link to the report budget tooltip - [`aa5f268`](https://github.com/actualbudget/actual/commit/aa5f2682763f53980ae25eeec637f25154a7aea0) Swap <a href="#"> with <Link> ### 📊 Changes **24 files changed** (+193 additions, -218 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+6 -0) 📝 `packages/desktop-client/src/components/FatalError.js` (+28 -16) 📝 `packages/desktop-client/src/components/ManageRules.js` (+13 -16) 📝 `packages/desktop-client/src/components/Notifications.js` (+4 -5) 📝 `packages/desktop-client/src/components/Titlebar.js` (+5 -8) 📝 `packages/desktop-client/src/components/UpdateNotification.js` (+5 -5) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.js` (+3 -7) 📝 `packages/desktop-client/src/components/common.tsx` (+30 -38) 📝 `packages/desktop-client/src/components/manager/ImportYNAB5.js` (+1 -5) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+0 -1) 📝 `packages/desktop-client/src/components/manager/WelcomeScreen.js` (+7 -5) 📝 `packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx` (+3 -8) 📝 `packages/desktop-client/src/components/modals/CloseAccount.js` (+13 -7) 📝 `packages/desktop-client/src/components/modals/CreateAccount.js` (+17 -11) 📝 `packages/desktop-client/src/components/modals/CreateEncryptionKey.js` (+2 -8) 📝 `packages/desktop-client/src/components/modals/CreateLocalAccount.js` (+5 -8) 📝 `packages/desktop-client/src/components/modals/FixEncryptionKey.js` (+2 -8) 📝 `packages/desktop-client/src/components/modals/NordigenExternalMsg.js` (+18 -17) 📝 `packages/desktop-client/src/components/modals/NordigenInitialise.tsx` (+2 -8) 📝 `packages/desktop-client/src/components/settings/Encryption.js` (+9 -25) _...and 4 more files_ </details> ### 📄 Description This cleans up all of the usage of `<a>` in the codebase. Now all external links get the appropriate attributes added. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 11:08:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#38006
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?