github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1532] [MERGED] Some typescript migration #3800

New Issue
Closed
opened 2026-02-28 20:46:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:46:59 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1532
Author: @joel-jeremy
Created: 8/16/2023
Status: ✅ Merged
Merged: 8/17/2023
Merged by: @joel-jeremy

Base: master ← Head: ts

📝 Commits (10+)

  • 4288b39 Typescript migration
  • 20109d2 Release notes
  • af292ef Update error boundary
  • adbda91 Breakup sidebar components
  • 2dac884 Account and Sidebar props
  • 965221f Remove button in Item component + exports cleanup
  • 63a8b77 Put accountNameStyle to Account
  • e79b234 Revert component ports (separated to another PR)
  • 472ce19 Export cleanup
  • 29d3d13 Remove ErrorBoundary (separated to another PR)

📊 Changes

28 files changed (+1007 additions, -684 deletions)

View changed files

📝 packages/desktop-client/src/components/AnimatedRefresh.tsx (+12 -4)
📝 packages/desktop-client/src/components/BankSyncStatus.tsx (+0 -0)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+1 -1)
📝 packages/desktop-client/src/components/GlobalKeys.tsx (+0 -0)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+11 -2)
📝 packages/desktop-client/src/components/ManageRulesPage.tsx (+1 -1)
📝 packages/desktop-client/src/components/MobileWebMessage.tsx (+1 -1)
➖ packages/desktop-client/src/components/SyncRefresh.js (+0 -13)
➕ packages/desktop-client/src/components/SyncRefresh.tsx (+21 -0)
📝 packages/desktop-client/src/components/Titlebar.tsx (+12 -4)
📝 packages/desktop-client/src/components/UpdateNotification.tsx (+0 -0)
📝 packages/desktop-client/src/components/settings/Format.tsx (+1 -1)
➖ packages/desktop-client/src/components/sidebar.js (+0 -620)
➕ packages/desktop-client/src/components/sidebar/Account.tsx (+148 -0)
➕ packages/desktop-client/src/components/sidebar/Accounts.tsx (+184 -0)
➕ packages/desktop-client/src/components/sidebar/Item.tsx (+91 -0)
➕ packages/desktop-client/src/components/sidebar/ItemContent.tsx (+52 -0)
➕ packages/desktop-client/src/components/sidebar/SecondaryItem.tsx (+83 -0)
➕ packages/desktop-client/src/components/sidebar/Sidebar.tsx (+153 -0)
📝 packages/desktop-client/src/components/sidebar/SidebarWithData.tsx (+29 -17)

...and 8 more files

📄 Description

Some typescript migration for components in the root components directory. Also moved some sidebar components to the sidebar folder. There's no functional change in this PR.

This is to help with #1483.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1532 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 8/16/2023 **Status:** ✅ Merged **Merged:** 8/17/2023 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `ts` --- ### 📝 Commits (10+) - [`4288b39`](https://github.com/actualbudget/actual/commit/4288b396edddbec9a00b131c97c2ee2616b82f18) Typescript migration - [`20109d2`](https://github.com/actualbudget/actual/commit/20109d2a309bb09b77ebfaaaaa86af9b5b23912a) Release notes - [`af292ef`](https://github.com/actualbudget/actual/commit/af292efc3c7cf892df01a82e0759cedf3676c34d) Update error boundary - [`adbda91`](https://github.com/actualbudget/actual/commit/adbda9139921e06d4523aabad00c545d6fca1564) Breakup sidebar components - [`2dac884`](https://github.com/actualbudget/actual/commit/2dac884ba60dd2edee4a67291b190e8dd162c0ec) Account and Sidebar props - [`965221f`](https://github.com/actualbudget/actual/commit/965221f02c6f1374d7dc63ec2c3b8ffc6ac695ee) Remove button in Item component + exports cleanup - [`63a8b77`](https://github.com/actualbudget/actual/commit/63a8b77ef8c5cec99938ed6aa23a39db0a536ea4) Put accountNameStyle to Account - [`e79b234`](https://github.com/actualbudget/actual/commit/e79b2349a48af6174179671bb30a5ffa7bb1b99e) Revert component ports (separated to another PR) - [`472ce19`](https://github.com/actualbudget/actual/commit/472ce19493f7091c393c55a7245f0333eb89c409) Export cleanup - [`29d3d13`](https://github.com/actualbudget/actual/commit/29d3d13db045fde0a24e3419c4b9fce4dc1c65e5) Remove ErrorBoundary (separated to another PR) ### 📊 Changes **28 files changed** (+1007 additions, -684 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/AnimatedRefresh.tsx` (+12 -4) 📝 `packages/desktop-client/src/components/BankSyncStatus.tsx` (+0 -0) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/GlobalKeys.tsx` (+0 -0) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+11 -2) 📝 `packages/desktop-client/src/components/ManageRulesPage.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/MobileWebMessage.tsx` (+1 -1) ➖ `packages/desktop-client/src/components/SyncRefresh.js` (+0 -13) ➕ `packages/desktop-client/src/components/SyncRefresh.tsx` (+21 -0) 📝 `packages/desktop-client/src/components/Titlebar.tsx` (+12 -4) 📝 `packages/desktop-client/src/components/UpdateNotification.tsx` (+0 -0) 📝 `packages/desktop-client/src/components/settings/Format.tsx` (+1 -1) ➖ `packages/desktop-client/src/components/sidebar.js` (+0 -620) ➕ `packages/desktop-client/src/components/sidebar/Account.tsx` (+148 -0) ➕ `packages/desktop-client/src/components/sidebar/Accounts.tsx` (+184 -0) ➕ `packages/desktop-client/src/components/sidebar/Item.tsx` (+91 -0) ➕ `packages/desktop-client/src/components/sidebar/ItemContent.tsx` (+52 -0) ➕ `packages/desktop-client/src/components/sidebar/SecondaryItem.tsx` (+83 -0) ➕ `packages/desktop-client/src/components/sidebar/Sidebar.tsx` (+153 -0) 📝 `packages/desktop-client/src/components/sidebar/SidebarWithData.tsx` (+29 -17) _...and 8 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Some typescript migration for components in the root components directory. Also moved some sidebar components to the sidebar folder. There's no functional change in this PR. This is to help with [#1483](https://github.com/actualbudget/actual/issues/1483). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:46:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3800
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?