github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-21 06:31:58 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #1158] [MERGED] Deleting all unused files, deleting unused functions from loot-core #37990

New Issue
Closed
opened 2026-04-23 11:08:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 11:08:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1158
Author: @Shazib
Created: 6/20/2023
Status: ✅ Merged
Merged: 6/23/2023
Merged by: @j-f1

Base: master ← Head: export-tidy

📝 Commits (10+)

📊 Changes

30 files changed (+6 additions, -3300 deletions)

View changed files

➖ packages/desktop-client/src/components/SyncNotifications.js (+0 -65)
➖ packages/desktop-client/src/components/debug/index.js (+0 -143)
➖ packages/desktop-client/src/util.ts (+0 -4)
📝 packages/loot-core/src/server/api-models.ts (+0 -77)
📝 packages/loot-core/src/server/aql/compiler.ts (+0 -4)
📝 packages/loot-core/src/server/errors.ts (+0 -4)
➖ packages/loot-core/src/server/perf.ts (+0 -59)
📝 packages/loot-core/src/server/spreadsheet/globals.ts (+0 -17)
➖ packages/loot-core/src/server/spreadsheet/new/REQUIREMENTS.txt (+0 -33)
➖ packages/loot-core/src/server/spreadsheet/new/__snapshots__/compiler.test.ts.snap (+0 -734)
➖ packages/loot-core/src/server/spreadsheet/new/__snapshots__/lexer.test.ts.snap (+0 -50)
➖ packages/loot-core/src/server/spreadsheet/new/__snapshots__/vm.test.ts.snap (+0 -15)
➖ packages/loot-core/src/server/spreadsheet/new/compiler.test.ts (+0 -95)
➖ packages/loot-core/src/server/spreadsheet/new/compiler.ts (+0 -193)
➖ packages/loot-core/src/server/spreadsheet/new/get-sql-fields.ts (+0 -48)
➖ packages/loot-core/src/server/spreadsheet/new/lexer.test.ts (+0 -17)
➖ packages/loot-core/src/server/spreadsheet/new/lexer.ts (+0 -310)
➖ packages/loot-core/src/server/spreadsheet/new/nodes.ts (+0 -201)
➖ packages/loot-core/src/server/spreadsheet/new/ops.ts (+0 -33)
➖ packages/loot-core/src/server/spreadsheet/new/parser.ts (+0 -462)

...and 10 more files

📄 Description

Last one before I add the actual linter rules!

Draft for now as I have a couple queries and would like some feedback from maintainers.

  • An argument could be made that some functions i've deleted from various util.js files have merit and could stay. e.g. min() from ../spreadsheet/globals.ts If this is the case maybe i just go through and annotate everywhere with the eslint disable rule. I'm not sure if people will 'know' to go there for these functions given they're not currently used.

  • I've deleted the entire ../spreadsheet/new/ subfolder, but it looks like this was used in a single test, which i've also subsequently deleted packages/loot-core/src/server/spreadsheet/sqlinterp.test.ts. Is it worth having all those files for a single test? Can this test be recreated without this dependency?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1158 **Author:** [@Shazib](https://github.com/Shazib) **Created:** 6/20/2023 **Status:** ✅ Merged **Merged:** 6/23/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `export-tidy` --- ### 📝 Commits (10+) - [`8fcaa99`](https://github.com/actualbudget/actual/commit/8fcaa995b1c2bb6c37c29e1427442d80bc330db1) Remove unused exports - [`ae6adf6`](https://github.com/actualbudget/actual/commit/ae6adf636656ff5d89250b9482d715cb4efa889f) Add Release Notes - [`b4e766e`](https://github.com/actualbudget/actual/commit/b4e766ec989cec7912b73275111f5a0477a24a07) Removing unused functions - [`0a37705`](https://github.com/actualbudget/actual/commit/0a37705c34b4bc5c16062e93e5bb2092c455ad5c) Merge branch 'actualbudget:master' into export-tidy - [`2505471`](https://github.com/actualbudget/actual/commit/250547113489fdce55ec94ccc8fe0c06aa58520a) Merge branch 'export-tidy' of https://github.com/Shazib/actual into export-tidy - [`ff66c63`](https://github.com/actualbudget/actual/commit/ff66c632d494de33ecc70d3650e1d53d8ed19e05) Add Release Notes - [`06adff4`](https://github.com/actualbudget/actual/commit/06adff4c3f913f60aa217841050ce22ac3f7e3f6) Merge branch 'actualbudget:master' into export-tidy - [`1362313`](https://github.com/actualbudget/actual/commit/136231326e6f7ade810f3a209e005510d48a21d2) Removing Tutorial - [`181c78d`](https://github.com/actualbudget/actual/commit/181c78de0bbd295852e0daebfbd935698199f5b2) Add Release Notes - [`3bc98b4`](https://github.com/actualbudget/actual/commit/3bc98b42cc69290af57588b0b23fd8eb184cea3a) Merge branch 'actualbudget:master' into export-tidy ### 📊 Changes **30 files changed** (+6 additions, -3300 deletions) <details> <summary>View changed files</summary> ➖ `packages/desktop-client/src/components/SyncNotifications.js` (+0 -65) ➖ `packages/desktop-client/src/components/debug/index.js` (+0 -143) ➖ `packages/desktop-client/src/util.ts` (+0 -4) 📝 `packages/loot-core/src/server/api-models.ts` (+0 -77) 📝 `packages/loot-core/src/server/aql/compiler.ts` (+0 -4) 📝 `packages/loot-core/src/server/errors.ts` (+0 -4) ➖ `packages/loot-core/src/server/perf.ts` (+0 -59) 📝 `packages/loot-core/src/server/spreadsheet/globals.ts` (+0 -17) ➖ `packages/loot-core/src/server/spreadsheet/new/REQUIREMENTS.txt` (+0 -33) ➖ `packages/loot-core/src/server/spreadsheet/new/__snapshots__/compiler.test.ts.snap` (+0 -734) ➖ `packages/loot-core/src/server/spreadsheet/new/__snapshots__/lexer.test.ts.snap` (+0 -50) ➖ `packages/loot-core/src/server/spreadsheet/new/__snapshots__/vm.test.ts.snap` (+0 -15) ➖ `packages/loot-core/src/server/spreadsheet/new/compiler.test.ts` (+0 -95) ➖ `packages/loot-core/src/server/spreadsheet/new/compiler.ts` (+0 -193) ➖ `packages/loot-core/src/server/spreadsheet/new/get-sql-fields.ts` (+0 -48) ➖ `packages/loot-core/src/server/spreadsheet/new/lexer.test.ts` (+0 -17) ➖ `packages/loot-core/src/server/spreadsheet/new/lexer.ts` (+0 -310) ➖ `packages/loot-core/src/server/spreadsheet/new/nodes.ts` (+0 -201) ➖ `packages/loot-core/src/server/spreadsheet/new/ops.ts` (+0 -33) ➖ `packages/loot-core/src/server/spreadsheet/new/parser.ts` (+0 -462) _...and 10 more files_ </details> ### 📄 Description Last one before I add the actual linter rules! Draft for now as I have a couple queries and would like some feedback from maintainers. - An argument could be made that some functions i've deleted from various `util.js` files have merit and could stay. e.g. `min()` from `../spreadsheet/globals.ts` If this is the case maybe i just go through and annotate everywhere with the eslint disable rule. I'm not sure if people will 'know' to go there for these functions given they're not currently used. - I've deleted the entire `../spreadsheet/new/` subfolder, but it looks like this was used in a single test, which i've also subsequently deleted `packages/loot-core/src/server/spreadsheet/sqlinterp.test.ts`. Is it worth having all those files for a single test? Can this test be recreated without this dependency? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 11:08:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#37990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?