github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1494] [MERGED] Fix transactions button background color #3781

New Issue
Closed
opened 2026-02-28 20:46:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:46:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1494
Author: @Cldfire
Created: 8/8/2023
Status: ✅ Merged
Merged: 8/9/2023
Merged by: @trevdor

Base: master ← Head: jarek/fix-transactions-button

📝 Commits (2)

  • a3dd5bf Fix transactions button background color
  • 0ed27c8 Add release note

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/table.tsx (+1 -1)
➕ upcoming-release-notes/1494.md (+6 -0)

📄 Description

It seems #1436 caused a regression in the background color of the transactions button.

demo.actualbudget.org right now looks like:

Screenshot 2023-08-08 at 7 12 24 PM

With the fix in this PR:

Screenshot 2023-08-08 at 7 12 50 PM

It looks like the transparent background was added explicitly in #1436: https://github.com/actualbudget/actual/pull/1436/files#diff-816cd66052d6811e3d3cac9f19920d8b57c09d3c3b0c882c4fc768d314776d45R905

It's not entirely clear to me why that was done, @carkom was there a specific reason for that change?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1494 **Author:** [@Cldfire](https://github.com/Cldfire) **Created:** 8/8/2023 **Status:** ✅ Merged **Merged:** 8/9/2023 **Merged by:** [@trevdor](https://github.com/trevdor) **Base:** `master` ← **Head:** `jarek/fix-transactions-button` --- ### 📝 Commits (2) - [`a3dd5bf`](https://github.com/actualbudget/actual/commit/a3dd5bfe88d512bbca782ac9ef319131654f158b) Fix transactions button background color - [`0ed27c8`](https://github.com/actualbudget/actual/commit/0ed27c86e348b4a168a365463f2e4d63c655676a) Add release note ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/table.tsx` (+1 -1) ➕ `upcoming-release-notes/1494.md` (+6 -0) </details> ### 📄 Description It seems #1436 caused a regression in the background color of the transactions button. `demo.actualbudget.org` right now looks like: <img width="365" alt="Screenshot 2023-08-08 at 7 12 24 PM" src="https://github.com/actualbudget/actual/assets/13814214/b13ca87a-d1e1-4dd7-9275-3bd933b2fc07"> With the fix in this PR: <img width="309" alt="Screenshot 2023-08-08 at 7 12 50 PM" src="https://github.com/actualbudget/actual/assets/13814214/5f25d4d0-fc25-4187-9ddd-bcf7d0aa2889"> It looks like the transparent background was added explicitly in #1436: https://github.com/actualbudget/actual/pull/1436/files#diff-816cd66052d6811e3d3cac9f19920d8b57c09d3c3b0c882c4fc768d314776d45R905 It's not entirely clear to me why that was done, @carkom was there a specific reason for that change? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:46:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3781
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?