github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1493] [MERGED] Stop setting endDate when fetching GoCardless transactions #3780

New Issue
Closed
opened 2026-02-28 20:46:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:46:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1493
Author: @kyrias
Created: 8/8/2023
Status: ✅ Merged
Merged: 8/9/2023
Merged by: @MatissJanis

Base: master ← Head: gocardless-stop-setting-endDate

📝 Commits (1)

  • 11b2bd9 Stop setting endDate when fetching GoCardless transactions

📊 Changes

2 files changed (+6 additions, -3 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.ts (+0 -3)
➕ upcoming-release-notes/1493.md (+6 -0)

📄 Description

This breaks fetching transactions where the valueDate is in the future. While the GoCardless documentation says this should never happen, it's what happens with at least Bank Norwegian due to them using the interest date as valueDate. (C.f. #1392)

Related server PR: actualbudget/actual-server#241

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1493 **Author:** [@kyrias](https://github.com/kyrias) **Created:** 8/8/2023 **Status:** ✅ Merged **Merged:** 8/9/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `gocardless-stop-setting-endDate` --- ### 📝 Commits (1) - [`11b2bd9`](https://github.com/actualbudget/actual/commit/11b2bd93f19879e2d694752b09b0626f41459185) Stop setting endDate when fetching GoCardless transactions ### 📊 Changes **2 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.ts` (+0 -3) ➕ `upcoming-release-notes/1493.md` (+6 -0) </details> ### 📄 Description This breaks fetching transactions where the valueDate is in the future. While the GoCardless documentation says this should never happen, it's what happens with at least Bank Norwegian due to them using the interest date as valueDate. (C.f. #1392) Related server PR: actualbudget/actual-server#241 <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:46:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3780
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?