github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #218] [MERGED] Fix enter to create accounts #37492

New Issue
Closed
opened 2026-04-23 10:39:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 10:39:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/218
Author: @ezfe
Created: 8/30/2022
Status: ✅ Merged
Merged: 11/12/2022
Merged by: @rich-howell

Base: master ← Head: master

📝 Commits (1)

  • 55b9a0e Fix enter to create accounts

📊 Changes

2 files changed (+3 additions, -5 deletions)

View changed files

📝 packages/loot-design/src/components/common.js (+0 -4)
📝 packages/loot-design/src/components/modals/CreateLocalAccount.js (+3 -1)

📄 Description

This is a small fix.

Right now, it seems like an attempt was made to insert a hidden button. This does not work on my computer (Safari 16.1).

The correct fix as I understand it is to mark non-submit buttons as type="button".

I've searched the codebase and only found one form button that needs to be modified.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/218 **Author:** [@ezfe](https://github.com/ezfe) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 11/12/2022 **Merged by:** [@rich-howell](https://github.com/rich-howell) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`55b9a0e`](https://github.com/actualbudget/actual/commit/55b9a0e7ef150897709725085fb67190967946ac) Fix enter to create accounts ### 📊 Changes **2 files changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-design/src/components/common.js` (+0 -4) 📝 `packages/loot-design/src/components/modals/CreateLocalAccount.js` (+3 -1) </details> ### 📄 Description This is a small fix. Right now, it seems like an attempt was made to insert a hidden button. This **does not work** on my computer (Safari 16.1). The correct fix as I understand it is to mark non-submit buttons as `type="button"`. I've searched the codebase and only found one form button that needs to be modified. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 10:39:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#37492
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?