github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #46] [MERGED] Minor fixes to package.json file formatting #37417

New Issue
Closed
opened 2026-04-23 10:34:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 10:34:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/46
Author: @TomAFrench
Created: 5/6/2022
Status: ✅ Merged
Merged: 6/29/2022
Merged by: @jlongster

Base: master ← Head: sort-desktop-client-packages

📝 Commits (4)

  • 54cc144 chore: reorder packages in desktop-client package.json
  • 1d06082 chore: sort dependencies in api package
  • 5428f11 chore: remove empty object entries in package.jsons
  • 6c9106e chore: remove duplicated license entry

📊 Changes

3 files changed (+27 additions, -31 deletions)

View changed files

📝 packages/api/package.json (+2 -3)
📝 packages/desktop-client/package.json (+25 -27)
📝 packages/import-ynab4/package.json (+0 -1)

📄 Description

The dependencies in the package.json for the desktop-client package aren't sorted properly. This results in a messy diff when installing a new dependency in this package as these existing entries will be automatically sorted into alphabetical order on top of the adding the new entry.

This PR is a noop other than sorting these dependencies to avoid potential for an unwanted (potentially malicious) dependency slipping through in a future PR due to a messy diff.

Edit: I've modified this to cover all the various package.json files

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/46 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 5/6/2022 **Status:** ✅ Merged **Merged:** 6/29/2022 **Merged by:** [@jlongster](https://github.com/jlongster) **Base:** `master` ← **Head:** `sort-desktop-client-packages` --- ### 📝 Commits (4) - [`54cc144`](https://github.com/actualbudget/actual/commit/54cc144109819607d2771200be58d274f5ca1019) chore: reorder packages in desktop-client package.json - [`1d06082`](https://github.com/actualbudget/actual/commit/1d0608289c14f828804415e73116a0407113661f) chore: sort dependencies in api package - [`5428f11`](https://github.com/actualbudget/actual/commit/5428f113b8613d89c6308320edbeaaf89d1d2919) chore: remove empty object entries in package.jsons - [`6c9106e`](https://github.com/actualbudget/actual/commit/6c9106ead6f871be28a832698376157ef0418b64) chore: remove duplicated license entry ### 📊 Changes **3 files changed** (+27 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/package.json` (+2 -3) 📝 `packages/desktop-client/package.json` (+25 -27) 📝 `packages/import-ynab4/package.json` (+0 -1) </details> ### 📄 Description The dependencies in the package.json for the `desktop-client` package aren't sorted properly. This results in a messy diff when installing a new dependency in this package as these existing entries will be automatically sorted into alphabetical order on top of the adding the new entry. This PR is a noop other than sorting these dependencies to avoid potential for an unwanted (potentially malicious) dependency slipping through in a future PR due to a messy diff. Edit: I've modified this to cover all the various package.json files --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 10:34:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#37417
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?