[PR #7466] [MERGED] [AI] Refactor IS_GENERIC_BROWSER env var to --mode=browser #37380

Closed
opened 2026-04-21 00:24:21 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7466
Author: @MatissJanis
Created: 4/11/2026
Status: Merged
Merged: 4/15/2026
Merged by: @MatissJanis

Base: masterHead: claude/refactor-generic-browser-mode-A0BCv


📝 Commits (3)

  • 32afa37 [AI] Refactor IS_GENERIC_BROWSER env var to --mode=browser
  • e3890ce Add release notes for PR #7466
  • 1eb536d [AI] Fix COOP/COEP headers not set with --mode=browser

📊 Changes

5 files changed (+11 additions, -7 deletions)

View changed files

📝 packages/desktop-client/bin/build-browser (+1 -2)
📝 packages/desktop-client/bin/watch-browser (+1 -2)
📝 packages/desktop-client/src/build-shims.js (+1 -1)
📝 packages/desktop-client/vite.config.ts (+2 -2)
upcoming-release-notes/7466.md (+6 -0)

📄 Description

Replace IS_GENERIC_BROWSER with --mode param usage: simplifying the build process.


Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 12.9 MB → 12.9 MB (-3 B) -0.00%
loot-core 1 4.84 MB 0%
api 1 3.88 MB 0%
cli 1 7.89 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 12.9 MB → 12.9 MB (-3 B) -0.00%
Changeset
File Δ Size
src/build-shims.js 📉 -3 B (-0.81%) 370 B → 367 B
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
static/js/extends.js 485.17 kB → 485.17 kB (-3 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/index.js 3.32 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 852.77 kB 0%
static/js/ReportRouter.js 1.17 MB 0%
static/js/TransactionList.js 82.49 kB 0%
static/js/Value.js 4.33 MB 0%
static/js/ca.js 191.98 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.38 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 175.89 kB 0%
static/js/es.js 181.8 kB 0%
static/js/fr.js 177.08 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.95 kB 0%
static/js/narrow.js 363.02 kB 0%
static/js/nb-NO.js 151.85 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.44 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 179.3 kB 0%
static/js/theme.js 30.79 kB 0%
static/js/uk.js 212.6 kB 0%
static/js/wide.js 295 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 110.05 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.84 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.2cr-I6dh.js 4.84 MB 0%

api

Total

Files count Total bundle size % Changed
1 3.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.88 MB 0%

cli

Total

Files count Total bundle size % Changed
1 7.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.89 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7466 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/11/2026 **Status:** ✅ Merged **Merged:** 4/15/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/refactor-generic-browser-mode-A0BCv` --- ### 📝 Commits (3) - [`32afa37`](https://github.com/actualbudget/actual/commit/32afa3715bf7bd6cd21fbc96dca018f02f5e17f9) [AI] Refactor IS_GENERIC_BROWSER env var to --mode=browser - [`e3890ce`](https://github.com/actualbudget/actual/commit/e3890ce939fe2a05815cfcfae6a520fe482a8b1e) Add release notes for PR #7466 - [`1eb536d`](https://github.com/actualbudget/actual/commit/1eb536dd9b04e5695a508268fec512f5e3654c54) [AI] Fix COOP/COEP headers not set with --mode=browser ### 📊 Changes **5 files changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/bin/build-browser` (+1 -2) 📝 `packages/desktop-client/bin/watch-browser` (+1 -2) 📝 `packages/desktop-client/src/build-shims.js` (+1 -1) 📝 `packages/desktop-client/vite.config.ts` (+2 -2) ➕ `upcoming-release-notes/7466.md` (+6 -0) </details> ### 📄 Description Replace `IS_GENERIC_BROWSER` with `--mode` param usage: simplifying the build process. <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 12.9 MB → 12.9 MB (-3 B) | -0.00% loot-core | 1 | 4.84 MB | 0% api | 1 | 3.88 MB | 0% cli | 1 | 7.89 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 12.9 MB → 12.9 MB (-3 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/build-shims.js` | 📉 -3 B (-0.81%) | 370 B → 367 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/extends.js | 485.17 kB → 485.17 kB (-3 B) | -0.00% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.32 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 852.77 kB | 0% static/js/ReportRouter.js | 1.17 MB | 0% static/js/TransactionList.js | 82.49 kB | 0% static/js/Value.js | 4.33 MB | 0% static/js/ca.js | 191.98 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.38 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 175.89 kB | 0% static/js/es.js | 181.8 kB | 0% static/js/fr.js | 177.08 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.95 kB | 0% static/js/narrow.js | 363.02 kB | 0% static/js/nb-NO.js | 151.85 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.44 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 179.3 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 212.6 kB | 0% static/js/wide.js | 295 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 110.05 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.84 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.2cr-I6dh.js | 4.84 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.88 MB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.89 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 00:24:21 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#37380