github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7428] [MERGED] Prevent path traversal in file upload by using basename #37352

New Issue
Closed
opened 2026-04-21 00:19:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 00:19:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7428
Author: @MatissJanis
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/11/2026
Merged by: @MatissJanis

Base: master ← Head: claude/fix-path-traversal-upload-6qWQs

📝 Commits (6)

  • 04e6fec [AI] Fix path traversal vulnerability in uploadFileWeb
  • e027ff8 [AI] Harden path traversal fix and correct broken basename in web fs
  • 394b5f2 [AI] Revert browser fs.basename change per user request
  • cc726aa [AI] Add release notes for path traversal fix (#7428)
  • 7228ffe [AI] Suppress no-control-regex lint for null byte sanitization
  • 59fe0ce [AI] Use replaceAll for null-byte stripping instead of regex

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/budgetfiles/app.ts (+5 -1)
➕ upcoming-release-notes/7428.md (+6 -0)

📄 Description

Description

Fixing some security vulnerabilities that claude is highlighting.

Technically I would not call this a real vulnerability since all "loot-core" operations happen on your local device.. but we can fix it nonetheless to silence the false-negative signals.

This PR fixes a potential path traversal vulnerability in the `uploadFileWeb` function by sanitizing the filename before writing to disk. The change uses `fs.basename()` to extract only the filename component, preventing attackers from using path traversal sequences (e.g., `../../../etc/passwd`) to write files outside the intended `/uploads/` directory.

Related issue(s)

n/a

Testing

n/a

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

https://claude.ai/code/session_01UgQANWBxqkqVT7xGyWNAXB

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 12.9 MB 0%
loot-core 1 4.84 MB → 4.84 MB (+180 B) +0.00%
api 1 3.84 MB → 3.84 MB (+178 B) +0.00%
cli 1 7.89 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 12.9 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 3.32 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 852.77 kB 0%
static/js/ReportRouter.js 1.17 MB 0%
static/js/TransactionList.js 82.49 kB 0%
static/js/Value.js 4.33 MB 0%
static/js/ca.js 191.98 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.38 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 175.89 kB 0%
static/js/es.js 181.8 kB 0%
static/js/extends.js 485.18 kB 0%
static/js/fr.js 177.08 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.87 kB 0%
static/js/narrow.js 363.02 kB 0%
static/js/nb-NO.js 151.85 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.44 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 179.3 kB 0%
static/js/theme.js 30.79 kB 0%
static/js/uk.js 212.6 kB 0%
static/js/wide.js 295 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 109.61 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.84 MB → 4.84 MB (+180 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/budgetfiles/app.ts 📈 +180 B (+1.63%) 10.8 kB → 10.98 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.ddTTAQMt.js 0 B → 4.84 MB (+4.84 MB) -

Removed

Asset File Size % Changed
kcab.worker.2cr-I6dh.js 4.84 MB → 0 B (-4.84 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
1 3.84 MB → 3.84 MB (+178 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/budgetfiles/app.ts 📈 +178 B (+1.66%) 10.45 kB → 10.63 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.84 MB → 3.84 MB (+178 B) +0.00%

Smaller
No assets were smaller

Unchanged
No assets were unchanged

cli

Total

Files count Total bundle size % Changed
1 7.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.89 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7428 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/11/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/fix-path-traversal-upload-6qWQs` --- ### 📝 Commits (6) - [`04e6fec`](https://github.com/actualbudget/actual/commit/04e6fecb43aa4c23a0dfa874a98f0dde1fcd65b1) [AI] Fix path traversal vulnerability in uploadFileWeb - [`e027ff8`](https://github.com/actualbudget/actual/commit/e027ff8c87abad72d5e12279f902729deacded0b) [AI] Harden path traversal fix and correct broken basename in web fs - [`394b5f2`](https://github.com/actualbudget/actual/commit/394b5f2190ae455b77f3c65a9114f519989f3dcb) [AI] Revert browser fs.basename change per user request - [`cc726aa`](https://github.com/actualbudget/actual/commit/cc726aace32406a527a3b04b5863db69a9449957) [AI] Add release notes for path traversal fix (#7428) - [`7228ffe`](https://github.com/actualbudget/actual/commit/7228ffe036efd71bc1f4754dcd67f54da9902927) [AI] Suppress no-control-regex lint for null byte sanitization - [`59fe0ce`](https://github.com/actualbudget/actual/commit/59fe0ceac7994cca7f6fa5c86f7c235aff3acb3d) [AI] Use replaceAll for null-byte stripping instead of regex ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budgetfiles/app.ts` (+5 -1) ➕ `upcoming-release-notes/7428.md` (+6 -0) </details> ### 📄 Description ## Description Fixing some security vulnerabilities that claude is highlighting. Technically I would not call this a real vulnerability since all "loot-core" operations happen on your local device.. but we can fix it nonetheless to silence the false-negative signals. ``` This PR fixes a potential path traversal vulnerability in the `uploadFileWeb` function by sanitizing the filename before writing to disk. The change uses `fs.basename()` to extract only the filename component, preventing attackers from using path traversal sequences (e.g., `../../../etc/passwd`) to write files outside the intended `/uploads/` directory. ``` ## Related issue(s) <!-- Security fix for path traversal vulnerability --> n/a ## Testing n/a ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed https://claude.ai/code/session_01UgQANWBxqkqVT7xGyWNAXB <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 12.9 MB | 0% loot-core | 1 | 4.84 MB → 4.84 MB (+180 B) | +0.00% api | 1 | 3.84 MB → 3.84 MB (+178 B) | +0.00% cli | 1 | 7.89 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 12.9 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.32 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 852.77 kB | 0% static/js/ReportRouter.js | 1.17 MB | 0% static/js/TransactionList.js | 82.49 kB | 0% static/js/Value.js | 4.33 MB | 0% static/js/ca.js | 191.98 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.38 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 175.89 kB | 0% static/js/es.js | 181.8 kB | 0% static/js/extends.js | 485.18 kB | 0% static/js/fr.js | 177.08 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.87 kB | 0% static/js/narrow.js | 363.02 kB | 0% static/js/nb-NO.js | 151.85 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.44 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 179.3 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 212.6 kB | 0% static/js/wide.js | 295 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 109.61 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.84 MB → 4.84 MB (+180 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/budgetfiles/app.ts` | 📈 +180 B (+1.63%) | 10.8 kB → 10.98 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.ddTTAQMt.js | 0 B → 4.84 MB (+4.84 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.2cr-I6dh.js | 4.84 MB → 0 B (-4.84 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.84 MB → 3.84 MB (+178 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/budgetfiles/app.ts` | 📈 +178 B (+1.66%) | 10.45 kB → 10.63 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.84 MB → 3.84 MB (+178 B) | +0.00% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.89 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 00:19:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#37352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?