github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1428] [CLOSED] Apply button styles again to hover and active states #3733

New Issue
Closed
opened 2026-02-28 20:45:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:45:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1428
Author: @j-f1
Created: 7/30/2023
Status: ❌ Closed

Base: master ← Head: jed/button-color-fix

📝 Commits (6)

  • 6316e8d Fix “done” button in MobileBudgetTable not having all styles applied
  • fb7d72c Apply prop again to hover and active states
  • be1c9f7 Remove prop in favor of color style attribute
  • 1f63d7d Clean up a few color-related properties around buttons
  • 8878657 Add release note
  • 603d840 Fix bad reference

📊 Changes

11 files changed (+35 additions, -45 deletions)

View changed files

📝 packages/desktop-client/src/components/Notifications.tsx (+2 -4)
📝 packages/desktop-client/src/components/SidebarWithData.js (+1 -1)
📝 packages/desktop-client/src/components/Titlebar.js (+1 -5)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+5 -5)
📝 packages/desktop-client/src/components/budget/misc.js (+1 -5)
📝 packages/desktop-client/src/components/budget/report/BudgetSummary.tsx (+6 -6)
📝 packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx (+6 -6)
📝 packages/desktop-client/src/components/common/Button.tsx (+5 -5)
📝 packages/desktop-client/src/components/manager/BudgetList.js (+1 -7)
📝 packages/desktop-client/src/components/sidebar.js (+1 -1)
➕ upcoming-release-notes/1428.md (+6 -0)

📄 Description

Supersedes #1424. This allows <Button style={{ color: 'salmon' }}> to override both the hover and active styles of the button as well as the normal style.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1428 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/30/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `jed/button-color-fix` --- ### 📝 Commits (6) - [`6316e8d`](https://github.com/actualbudget/actual/commit/6316e8dea08a993299a584678c029b5ca7e9f0f2) Fix “done” button in MobileBudgetTable not having all styles applied - [`fb7d72c`](https://github.com/actualbudget/actual/commit/fb7d72cdf88f53af633b4ee96e2657b70b4f0236) Apply <Button style> prop again to hover and active states - [`be1c9f7`](https://github.com/actualbudget/actual/commit/be1c9f7fd37e69cf28cdf91a8f7d654b34dd11a0) Remove <Button color> prop in favor of color style attribute - [`1f63d7d`](https://github.com/actualbudget/actual/commit/1f63d7df84756d79a1cda4fb7532cb34090de6f7) Clean up a few color-related properties around buttons - [`8878657`](https://github.com/actualbudget/actual/commit/887865718b68968e85c1aa6b48e2079a8f7a118e) Add release note - [`603d840`](https://github.com/actualbudget/actual/commit/603d840923731b4da5525b28b0f9f54791bb7a2b) Fix bad reference ### 📊 Changes **11 files changed** (+35 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Notifications.tsx` (+2 -4) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+1 -1) 📝 `packages/desktop-client/src/components/Titlebar.js` (+1 -5) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+5 -5) 📝 `packages/desktop-client/src/components/budget/misc.js` (+1 -5) 📝 `packages/desktop-client/src/components/budget/report/BudgetSummary.tsx` (+6 -6) 📝 `packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx` (+6 -6) 📝 `packages/desktop-client/src/components/common/Button.tsx` (+5 -5) 📝 `packages/desktop-client/src/components/manager/BudgetList.js` (+1 -7) 📝 `packages/desktop-client/src/components/sidebar.js` (+1 -1) ➕ `upcoming-release-notes/1428.md` (+6 -0) </details> ### 📄 Description Supersedes #1424. This allows `<Button style={{ color: 'salmon' }}>` to override both the hover and active styles of the button as well as the normal style. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?