[PR #7387] [CLOSED] Revert "trim down some unused/unnecessary dependencies" #37322

Closed
opened 2026-04-21 00:16:18 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7387
Author: @youngcw
Created: 4/5/2026
Status: Closed

Base: masterHead: revert-7350-trim-deps


📝 Commits (2)

📊 Changes

15 files changed (+281 additions, -28 deletions)

View changed files

📝 .github/workflows/build.yml (+3 -3)
📝 .github/workflows/size-compare.yml (+2 -2)
📝 package.json (+4 -0)
📝 packages/api/index.ts (+13 -0)
📝 packages/api/package.json (+1 -0)
📝 packages/desktop-client/package.json (+2 -0)
📝 packages/docs/docs/api/index.md (+1 -1)
📝 packages/eslint-plugin-actual/package.json (+6 -0)
📝 packages/loot-core/package.json (+4 -1)
📝 packages/loot-core/src/server/importers/ynab4.ts (+2 -1)
📝 packages/loot-core/src/server/update.ts (+2 -2)
📝 packages/loot-core/vite.config.ts (+0 -1)
upcoming-release-notes/7350.md (+0 -6)
upcoming-release-notes/7387.md (+6 -0)
📝 yarn.lock (+235 -11)

📄 Description

Reverts actualbudget/actual#7242

Will remerge later. Was merged prematurely.


Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 12.27 MB → 12.27 MB (+52 B) +0.00%
loot-core 1 4.82 MB → 4.83 MB (+9.03 kB) +0.18%
api 1 → 4 3.83 MB → 4.06 MB (+228.71 kB) +5.83%
cli 1 7.88 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 12.27 MB → 12.27 MB (+52 B) +0.00%
Changeset
File Δ Size
package.json 📈 +52 B (+1.60%) 3.17 kB → 3.22 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.24 MB → 3.24 MB (+52 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 119.98 kB 0%
static/js/FormulaEditor.js 846.44 kB 0%
static/js/ReportRouter.js 1.1 MB 0%
static/js/TransactionList.js 81.29 kB 0%
static/js/ca.js 183.36 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.79 kB 0%
static/js/en-GB.js 7.16 kB 0%
static/js/en.js 170.76 kB 0%
static/js/es.js 182.18 kB 0%
static/js/fr.js 177.47 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 166.25 kB 0%
static/js/narrow.js 354.5 kB 0%
static/js/nb-NO.js 152.2 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.84 kB 0%
static/js/resize-observer.js 18.03 kB 0%
static/js/sv.js 80.58 kB 0%
static/js/th.js 179.94 kB 0%
static/js/theme.js 30.68 kB 0%
static/js/uk.js 213.14 kB 0%
static/js/useTransactionBatchActions.js 4.29 MB 0%
static/js/wide.js 418 B 0%
static/js/workbox-window.prod.es5.js 7.28 kB 0%
static/js/zh-Hans.js 93.57 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.82 MB → 4.83 MB (+9.03 kB) +0.18%
Changeset
File Δ Size
node_modules/md5/md5.js 🆕 +5.4 kB 0 B → 5.4 kB
node_modules/crypt/crypt.js 🆕 +2.23 kB 0 B → 2.23 kB
node_modules/charenc/charenc.js 🆕 +763 B 0 B → 763 B
node_modules/is-buffer/index.js 🆕 +546 B 0 B → 546 B
node_modules/slash/index.js 🆕 +169 B 0 B → 169 B
node_modules/create-hash/md5.js 📈 +2 B (+0.82%) 245 B → 247 B
node_modules/create-hmac/browser.js 📈 +2 B (+0.12%) 1.64 kB → 1.64 kB
node_modules/pbkdf2/lib/sync-browser.js 📈 +2 B (+0.06%) 3.09 kB → 3.09 kB
node_modules/i18next/dist/esm/i18next.js 📈 +4 B (+0.01%) 74.53 kB → 74.53 kB
home/runner/work/actual/actual/packages/loot-core/migrations/1632571489012_remove_cache.js 📉 -3 B (-0.10%) 3.03 kB → 3.03 kB
home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab4.ts 📉 -13 B (-0.14%) 9.36 kB → 9.35 kB
home/runner/work/actual/actual/packages/loot-core/src/server/update.ts 📉 -45 B (-6.71%) 671 B → 626 B
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.DsPqDXjP.js 0 B → 4.83 MB (+4.83 MB) -

Removed

Asset File Size % Changed
kcab.worker.3maKMh4x.js 4.82 MB → 0 B (-4.82 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged


api

Total

Files count Total bundle size % Changed
1 → 4 3.83 MB → 4.06 MB (+228.71 kB) +5.83%
Changeset
File Δ Size
node_modules/web-streams-polyfill/dist/ponyfill.es2018.js 🆕 +155.28 kB 0 B → 155.28 kB
node_modules/node-fetch/src/index.js 🆕 +8.88 kB 0 B → 8.88 kB
node_modules/node-fetch/src/body.js 🆕 +8.19 kB 0 B → 8.19 kB
node_modules/node-fetch/src/utils/multipart-parser.js 🆕 +8.1 kB 0 B → 8.1 kB
node_modules/node-fetch/src/utils/referrer.js 🆕 +6.2 kB 0 B → 6.2 kB
node_modules/node-fetch/src/request.js 🆕 +6.06 kB 0 B → 6.06 kB
node_modules/node-fetch/src/headers.js 🆕 +5.85 kB 0 B → 5.85 kB
node_modules/fetch-blob/index.js 🆕 +5.68 kB 0 B → 5.68 kB
node_modules/md5/md5.js 🆕 +5.3 kB 0 B → 5.3 kB
node_modules/node-fetch/src/response.js 🆕 +3.16 kB 0 B → 3.16 kB
node_modules/formdata-polyfill/esm.min.js 🆕 +2.71 kB 0 B → 2.71 kB
node_modules/crypt/crypt.js 🆕 +2.19 kB 0 B → 2.19 kB
node_modules/node-fetch/src/utils/is.js 🆕 +2.09 kB 0 B → 2.09 kB
node_modules/fetch-blob/from.js 🆕 +1.31 kB 0 B → 1.31 kB
node_modules/data-uri-to-buffer/dist/index.js 🆕 +1.25 kB 0 B → 1.25 kB
node_modules/fetch-blob/streams.cjs 🆕 +1.11 kB 0 B → 1.11 kB
node_modules/fetch-blob/file.js 🆕 +1.02 kB 0 B → 1.02 kB
node_modules/charenc/charenc.js 🆕 +753 B 0 B → 753 B
node_modules/node-fetch/src/errors/fetch-error.js 🆕 +738 B 0 B → 738 B
node_modules/is-buffer/index.js 🆕 +669 B 0 B → 669 B
node_modules/node-domexception/index.js 🆕 +622 B 0 B → 622 B
node_modules/node-fetch/src/utils/get-search.js 🆕 +358 B 0 B → 358 B
node_modules/node-fetch/src/errors/base.js 🆕 +354 B 0 B → 354 B
node_modules/node-fetch/src/utils/is-redirect.js 🆕 +299 B 0 B → 299 B
node_modules/node-fetch/src/errors/abort-error.js 🆕 +252 B 0 B → 252 B
node_modules/slash/index.js 🆕 +162 B 0 B → 162 B
index.ts 📈 +180 B (+46.39%) 388 B → 568 B
home/runner/work/actual/actual/packages/loot-core/migrations/1632571489012_remove_cache.js 📈 +57 B (+1.90%) 2.92 kB → 2.98 kB
node_modules/i18next/dist/esm/i18next.js 📈 +4 B (+0.01%) 72.62 kB → 72.62 kB
home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab4.ts 📉 -13 B (-0.14%) 9.19 kB → 9.17 kB
home/runner/work/actual/actual/packages/loot-core/src/server/update.ts 📉 -32 B (-4.90%) 653 B → 621 B
View detailed bundle breakdown

Added

Asset File Size % Changed
from-Bl-Hslp4.js 0 B → 167.73 kB (+167.73 kB) -
src-iMkUmuwR.js 0 B → 43.64 kB (+43.64 kB) -
multipart-parser-BnDysoMr.js 0 B → 8.1 kB (+8.1 kB) -

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.83 MB → 3.84 MB (+9.23 kB) +0.24%

Smaller
No assets were smaller

Unchanged
No assets were unchanged


cli

Total

Files count Total bundle size % Changed
1 7.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.88 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7387 **Author:** [@youngcw](https://github.com/youngcw) **Created:** 4/5/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `revert-7350-trim-deps` --- ### 📝 Commits (2) - [`deac017`](https://github.com/actualbudget/actual/commit/deac017aaa3852dcd1134085b1d8b04ad390a516) Revert "trim down some unused/unnecessary dependencies (#7350)" - [`ae57339`](https://github.com/actualbudget/actual/commit/ae573390a357465c72633632746b7d4e43356548) Add release notes for PR #7387 ### 📊 Changes **15 files changed** (+281 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+3 -3) 📝 `.github/workflows/size-compare.yml` (+2 -2) 📝 `package.json` (+4 -0) 📝 `packages/api/index.ts` (+13 -0) 📝 `packages/api/package.json` (+1 -0) 📝 `packages/desktop-client/package.json` (+2 -0) 📝 `packages/docs/docs/api/index.md` (+1 -1) 📝 `packages/eslint-plugin-actual/package.json` (+6 -0) 📝 `packages/loot-core/package.json` (+4 -1) 📝 `packages/loot-core/src/server/importers/ynab4.ts` (+2 -1) 📝 `packages/loot-core/src/server/update.ts` (+2 -2) 📝 `packages/loot-core/vite.config.ts` (+0 -1) ➖ `upcoming-release-notes/7350.md` (+0 -6) ➕ `upcoming-release-notes/7387.md` (+6 -0) 📝 `yarn.lock` (+235 -11) </details> ### 📄 Description Reverts actualbudget/actual#7242 Will remerge later. Was merged prematurely. <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 12.27 MB → 12.27 MB (+52 B) | +0.00% loot-core | 1 | 4.82 MB → 4.83 MB (+9.03 kB) | +0.18% api | 1 → 4 | 3.83 MB → 4.06 MB (+228.71 kB) | +5.83% cli | 1 | 7.88 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 12.27 MB → 12.27 MB (+52 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `package.json` | 📈 +52 B (+1.60%) | 3.17 kB → 3.22 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.24 MB → 3.24 MB (+52 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 119.98 kB | 0% static/js/FormulaEditor.js | 846.44 kB | 0% static/js/ReportRouter.js | 1.1 MB | 0% static/js/TransactionList.js | 81.29 kB | 0% static/js/ca.js | 183.36 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.79 kB | 0% static/js/en-GB.js | 7.16 kB | 0% static/js/en.js | 170.76 kB | 0% static/js/es.js | 182.18 kB | 0% static/js/fr.js | 177.47 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 166.25 kB | 0% static/js/narrow.js | 354.5 kB | 0% static/js/nb-NO.js | 152.2 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.84 kB | 0% static/js/resize-observer.js | 18.03 kB | 0% static/js/sv.js | 80.58 kB | 0% static/js/th.js | 179.94 kB | 0% static/js/theme.js | 30.68 kB | 0% static/js/uk.js | 213.14 kB | 0% static/js/useTransactionBatchActions.js | 4.29 MB | 0% static/js/wide.js | 418 B | 0% static/js/workbox-window.prod.es5.js | 7.28 kB | 0% static/js/zh-Hans.js | 93.57 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.82 MB → 4.83 MB (+9.03 kB) | +0.18% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `node_modules/md5/md5.js` | 🆕 +5.4 kB | 0 B → 5.4 kB `node_modules/crypt/crypt.js` | 🆕 +2.23 kB | 0 B → 2.23 kB `node_modules/charenc/charenc.js` | 🆕 +763 B | 0 B → 763 B `node_modules/is-buffer/index.js` | 🆕 +546 B | 0 B → 546 B `node_modules/slash/index.js` | 🆕 +169 B | 0 B → 169 B `node_modules/create-hash/md5.js` | 📈 +2 B (+0.82%) | 245 B → 247 B `node_modules/create-hmac/browser.js` | 📈 +2 B (+0.12%) | 1.64 kB → 1.64 kB `node_modules/pbkdf2/lib/sync-browser.js` | 📈 +2 B (+0.06%) | 3.09 kB → 3.09 kB `node_modules/i18next/dist/esm/i18next.js` | 📈 +4 B (+0.01%) | 74.53 kB → 74.53 kB `home/runner/work/actual/actual/packages/loot-core/migrations/1632571489012_remove_cache.js` | 📉 -3 B (-0.10%) | 3.03 kB → 3.03 kB `home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab4.ts` | 📉 -13 B (-0.14%) | 9.36 kB → 9.35 kB `home/runner/work/actual/actual/packages/loot-core/src/server/update.ts` | 📉 -45 B (-6.71%) | 671 B → 626 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DsPqDXjP.js | 0 B → 4.83 MB (+4.83 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.3maKMh4x.js | 4.82 MB → 0 B (-4.82 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 → 4 | 3.83 MB → 4.06 MB (+228.71 kB) | +5.83% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `node_modules/web-streams-polyfill/dist/ponyfill.es2018.js` | 🆕 +155.28 kB | 0 B → 155.28 kB `node_modules/node-fetch/src/index.js` | 🆕 +8.88 kB | 0 B → 8.88 kB `node_modules/node-fetch/src/body.js` | 🆕 +8.19 kB | 0 B → 8.19 kB `node_modules/node-fetch/src/utils/multipart-parser.js` | 🆕 +8.1 kB | 0 B → 8.1 kB `node_modules/node-fetch/src/utils/referrer.js` | 🆕 +6.2 kB | 0 B → 6.2 kB `node_modules/node-fetch/src/request.js` | 🆕 +6.06 kB | 0 B → 6.06 kB `node_modules/node-fetch/src/headers.js` | 🆕 +5.85 kB | 0 B → 5.85 kB `node_modules/fetch-blob/index.js` | 🆕 +5.68 kB | 0 B → 5.68 kB `node_modules/md5/md5.js` | 🆕 +5.3 kB | 0 B → 5.3 kB `node_modules/node-fetch/src/response.js` | 🆕 +3.16 kB | 0 B → 3.16 kB `node_modules/formdata-polyfill/esm.min.js` | 🆕 +2.71 kB | 0 B → 2.71 kB `node_modules/crypt/crypt.js` | 🆕 +2.19 kB | 0 B → 2.19 kB `node_modules/node-fetch/src/utils/is.js` | 🆕 +2.09 kB | 0 B → 2.09 kB `node_modules/fetch-blob/from.js` | 🆕 +1.31 kB | 0 B → 1.31 kB `node_modules/data-uri-to-buffer/dist/index.js` | 🆕 +1.25 kB | 0 B → 1.25 kB `node_modules/fetch-blob/streams.cjs` | 🆕 +1.11 kB | 0 B → 1.11 kB `node_modules/fetch-blob/file.js` | 🆕 +1.02 kB | 0 B → 1.02 kB `node_modules/charenc/charenc.js` | 🆕 +753 B | 0 B → 753 B `node_modules/node-fetch/src/errors/fetch-error.js` | 🆕 +738 B | 0 B → 738 B `node_modules/is-buffer/index.js` | 🆕 +669 B | 0 B → 669 B `node_modules/node-domexception/index.js` | 🆕 +622 B | 0 B → 622 B `node_modules/node-fetch/src/utils/get-search.js` | 🆕 +358 B | 0 B → 358 B `node_modules/node-fetch/src/errors/base.js` | 🆕 +354 B | 0 B → 354 B `node_modules/node-fetch/src/utils/is-redirect.js` | 🆕 +299 B | 0 B → 299 B `node_modules/node-fetch/src/errors/abort-error.js` | 🆕 +252 B | 0 B → 252 B `node_modules/slash/index.js` | 🆕 +162 B | 0 B → 162 B `index.ts` | 📈 +180 B (+46.39%) | 388 B → 568 B `home/runner/work/actual/actual/packages/loot-core/migrations/1632571489012_remove_cache.js` | 📈 +57 B (+1.90%) | 2.92 kB → 2.98 kB `node_modules/i18next/dist/esm/i18next.js` | 📈 +4 B (+0.01%) | 72.62 kB → 72.62 kB `home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab4.ts` | 📉 -13 B (-0.14%) | 9.19 kB → 9.17 kB `home/runner/work/actual/actual/packages/loot-core/src/server/update.ts` | 📉 -32 B (-4.90%) | 653 B → 621 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- from-Bl-Hslp4.js | 0 B → 167.73 kB (+167.73 kB) | - src-iMkUmuwR.js | 0 B → 43.64 kB (+43.64 kB) | - multipart-parser-BnDysoMr.js | 0 B → 8.1 kB (+8.1 kB) | - **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.83 MB → 3.84 MB (+9.23 kB) | +0.24% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.88 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 00:16:19 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#37322