github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1424] [CLOSED] Swap custom bare button colors to the color prop #3731

New Issue
Closed
opened 2026-02-28 20:45:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:45:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1424
Author: @j-f1
Created: 7/30/2023
Status: ❌ Closed

Base: master ← Head: jed/fix-bare-button-color

📝 Commits (3)

  • 7c05fce Swap custom bare button colors to the color prop
  • a46332d Add release note
  • 55a554d Fix lint errors

📊 Changes

21 files changed (+74 additions, -112 deletions)

View changed files

📝 packages/desktop-client/src/ResponsiveProvider.tsx (+2 -0)
📝 packages/desktop-client/src/components/LoggedInUser.js (+1 -1)
📝 packages/desktop-client/src/components/NotesButton.tsx (+2 -6)
📝 packages/desktop-client/src/components/Notifications.tsx (+3 -2)
📝 packages/desktop-client/src/components/ThemeSelector.tsx (+2 -2)
📝 packages/desktop-client/src/components/Titlebar.js (+20 -38)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.js (+1 -2)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+4 -10)
📝 packages/desktop-client/src/components/budget/misc.js (+6 -12)
📝 packages/desktop-client/src/components/budget/report/BudgetSummary.tsx (+4 -7)
📝 packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx (+4 -7)
📝 packages/desktop-client/src/components/common/Button.tsx (+0 -1)
📝 packages/desktop-client/src/components/filters/FiltersMenu.js (+1 -1)
📝 packages/desktop-client/src/components/manager/BudgetList.js (+2 -4)
📝 packages/desktop-client/src/components/manager/ConfigServer.js (+4 -3)
📝 packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx (+2 -1)
📝 packages/desktop-client/src/components/manager/subscribe/Login.tsx (+2 -1)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+4 -7)
📝 packages/desktop-client/src/components/table.tsx (+1 -5)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.js (+3 -2)

...and 1 more files

📄 Description

The reasoning for this is that we now allow theming all states of the button, including hover. the :hover { ... } styles for the button override the styles further down that are not specifically applied to the hover state.

Now that I’m writing this description, I’m realizing that an alternate fix could be to manually apply the custom style prop to both hover and active styles. What do you think?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1424 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/30/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `jed/fix-bare-button-color` --- ### 📝 Commits (3) - [`7c05fce`](https://github.com/actualbudget/actual/commit/7c05fce1ca7e26c8d08e887fd9e8e37268ce4534) Swap custom bare button colors to the color prop - [`a46332d`](https://github.com/actualbudget/actual/commit/a46332d140164abc45da4219b1e2634b3dae961e) Add release note - [`55a554d`](https://github.com/actualbudget/actual/commit/55a554db30699a61ffe9c7970440b4b6670e49fd) Fix lint errors ### 📊 Changes **21 files changed** (+74 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/ResponsiveProvider.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+1 -1) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+2 -6) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/ThemeSelector.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/Titlebar.js` (+20 -38) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.js` (+1 -2) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+4 -10) 📝 `packages/desktop-client/src/components/budget/misc.js` (+6 -12) 📝 `packages/desktop-client/src/components/budget/report/BudgetSummary.tsx` (+4 -7) 📝 `packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx` (+4 -7) 📝 `packages/desktop-client/src/components/common/Button.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.js` (+1 -1) 📝 `packages/desktop-client/src/components/manager/BudgetList.js` (+2 -4) 📝 `packages/desktop-client/src/components/manager/ConfigServer.js` (+4 -3) 📝 `packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+4 -7) 📝 `packages/desktop-client/src/components/table.tsx` (+1 -5) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.js` (+3 -2) _...and 1 more files_ </details> ### 📄 Description The reasoning for this is that we now allow theming all states of the button, including hover. the `:hover { ... }` styles for the button override the styles further down that are not specifically applied to the hover state. Now that I’m writing this description, I’m realizing that an alternate fix could be to manually apply the custom `style` prop to both hover and active styles. What do you think? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3731
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?