[PR #7305] [MERGED] amend maintainer points counting script docs file filter #37267

New Issue

GiteaMirror · 2026-04-21T00:11:51-05:00

GiteaMirror commented

2026-04-21 00:11:51 -05:00

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7305
Author: @matt-fidd
Created: 3/27/2026
Status: ✅ Merged
Merged: 3/27/2026
Merged by: @matt-fidd

Base: master ← Head: points-count-docs

📝 Commits (2)

92b4532 fix
cf7bc93 note

📊 Changes

2 files changed (+30 additions, -8 deletions)

View changed files

📝 .github/scripts/count-points.mjs (+24 -8)
➕ upcoming-release-notes/7305.md (+6 -0)

📄 Description

Description

Changes to spelling workflows were being credited as code changes, and changes to the package.json in docs were being credited as docs changes, causing cases where sometimes reviewers would be given the minimum points count for both categories instead of just one.

Adding in globs here makes it more easily expandable if we find other issues with file categorisation

Reported on discord

Testing

Run locally against PRs 7244 and 7223

Before:

Code Review Statistics:
=======================
youngcw: 170 (PRs: #7272 (6pts), #7151 (1pts), #7244 (1pts), #7268 (2pts), #7153 (6pts), #7239 (8pts), #7267 (2pts), #7155 (6pts), #7172 (8pts), #7152 (6pts), #7118 (2pts), #7163 (6pts), #7194 (6pts), #7107 (2pts), #7145 (6pts), #7101 (6pts), #7095 (1pts), #7078 (8pts), #7209 (2pts), #7200 (6pts), #7047 (2pts), #7057 (6pts), #7041 (2pts), #7232 (6pts), #7125 (6pts), #7005 (2pts), #7196 (1pts), #7038 (8pts), #6903 (8pts), #6414 (6pts), #7105 (1pts), #7117 (6pts), #6741 (2pts), #7091 (1pts), #7223 (2pts), #6620 (8pts), #7092 (2pts), #7181 (2pts), #7069 (2pts), #6693 (6pts))
joel-jeremy: 115 (PRs: #7275 (1pts), #7248 (1pts), #7236 (6pts), #7224 (2pts), #7155 (6pts), #7172 (8pts), #7118 (2pts), #7163 (6pts), #7230 (2pts), #7194 (6pts), #7107 (2pts), #7144 (1pts), #7073 (1pts), #7095 (1pts), #7142 (2pts), #7146 (1pts), #7057 (6pts), #7232 (6pts), #7229 (2pts), #7005 (2pts), #7240 (8pts), #7111 (6pts), #7100 (1pts), #7105 (1pts), #7117 (6pts), #6741 (2pts), #7091 (1pts), #7187 (6pts), #7092 (2pts), #7181 (2pts), #7074 (6pts), #7050 (6pts), #7051 (2pts), #7053 (2pts))
matt-fidd: 91 (PRs: #7275 (1pts), #7274 (6pts), #7249 (1pts), #7166 (6pts), #7264 (1pts), #7245 (1pts), #7244 (1pts), #7168 (2pts), #7185 (2pts), #7139 (6pts), #7180 (2pts), #7188 (6pts), #7191 (2pts), #7152 (6pts), #7073 (1pts), #7101 (6pts), #7195 (2pts), #7209 (2pts), #7200 (6pts), #7193 (2pts), #6972 (6pts), #7219 (1pts), #6903 (8pts), #7100 (1pts), #7105 (1pts), #7104 (1pts), #7071 (2pts), #7181 (2pts), #7074 (6pts), #7055 (1pts))
MatissJanis: 48 (PRs: #7149 (2pts), #7197 (1pts), #7143 (1pts), #7222 (2pts), #7234 (6pts), #7227 (6pts), #7140 (1pts), #7130 (1pts), #7172 (8pts), #7129 (1pts), #7107 (2pts), #7141 (1pts), #6926 (6pts), #7184 (6pts), #7223 (2pts), #7075 (2pts))
jfdoming: 31 (PRs: #7177 (2pts), #7234 (6pts), #7224 (2pts), #7155 (6pts), #7207 (2pts), #7179 (2pts), #7044 (1pts), #7202 (2pts), #7097 (4pts - Release Merger), #7103 (2pts), #7183 (2pts))
MikesGlitch: 15 (PRs: #7118 (2pts), #7200 (6pts), #7091 (1pts), #7062 (6pts))
lelemm: 6 (PRs: #7155 (6pts))

Docs Review Statistics:
=======================
youngcw: 10 (PRs: #7244 (4pts), #7200 (2pts), #7117 (2pts), #7223 (2pts))
MatissJanis: 8 (PRs: #7199 (2pts), #7222 (2pts), #6926 (2pts), #7223 (2pts))
joel-jeremy: 6 (PRs: #7229 (2pts), #7240 (2pts), #7117 (2pts))
matt-fidd: 6 (PRs: #7244 (4pts), #7200 (2pts))
MikesGlitch: 4 (PRs: #7096 (2pts), #7200 (2pts))

Points Summary:
===============
youngcw: 208
MatissJanis: 144
matt-fidd: 138
joel-jeremy: 126
jfdoming: 45
MikesGlitch: 32
lelemm: 6

Total points earned: 699

After:

Code Review Statistics:
=======================
youngcw: 169 (PRs: #7272 (6pts), #7151 (1pts), #7268 (2pts), #7155 (6pts), #7118 (2pts), #7239 (8pts), #7153 (6pts), #7172 (8pts), #7267 (2pts), #7196 (1pts), #7152 (6pts), #7107 (2pts), #7209 (2pts), #7232 (6pts), #7101 (6pts), #7095 (1pts), #7078 (8pts), #7145 (6pts), #7057 (6pts), #7047 (2pts), #7041 (2pts), #7005 (2pts), #7117 (6pts), #7125 (6pts), #6741 (2pts), #7038 (8pts), #7181 (2pts), #6903 (8pts), #7105 (1pts), #7223 (2pts), #6620 (8pts), #6414 (6pts), #7092 (2pts), #7091 (1pts), #7194 (6pts), #7200 (6pts), #7069 (2pts), #7163 (6pts), #6693 (6pts))
joel-jeremy: 115 (PRs: #7275 (1pts), #7240 (8pts), #7155 (6pts), #7118 (2pts), #7172 (8pts), #7248 (1pts), #7230 (2pts), #7146 (1pts), #7236 (6pts), #7107 (2pts), #7224 (2pts), #7073 (1pts), #7232 (6pts), #7095 (1pts), #7144 (1pts), #7229 (2pts), #7142 (2pts), #7057 (6pts), #7187 (6pts), #7005 (2pts), #7117 (6pts), #6741 (2pts), #7181 (2pts), #7105 (1pts), #7100 (1pts), #7111 (6pts), #7092 (2pts), #7091 (1pts), #7194 (6pts), #7074 (6pts), #7163 (6pts), #7050 (6pts), #7051 (2pts), #7053 (2pts))
matt-fidd: 90 (PRs: #7188 (6pts), #7166 (6pts), #7249 (1pts), #7275 (1pts), #7245 (1pts), #7185 (2pts), #7264 (1pts), #7274 (6pts), #7168 (2pts), #7193 (2pts), #7139 (6pts), #7191 (2pts), #7219 (1pts), #7195 (2pts), #7152 (6pts), #7209 (2pts), #7180 (2pts), #7073 (1pts), #7101 (6pts), #6972 (6pts), #7181 (2pts), #6903 (8pts), #7105 (1pts), #7104 (1pts), #7100 (1pts), #7200 (6pts), #7074 (6pts), #7071 (2pts), #7055 (1pts))
MatissJanis: 48 (PRs: #7197 (1pts), #7149 (2pts), #7143 (1pts), #7140 (1pts), #7129 (1pts), #7234 (6pts), #7172 (8pts), #7107 (2pts), #7222 (2pts), #7227 (6pts), #7141 (1pts), #7130 (1pts), #6926 (6pts), #7223 (2pts), #7184 (6pts), #7075 (2pts))
jfdoming: 31 (PRs: #7155 (6pts), #7234 (6pts), #7179 (2pts), #7224 (2pts), #7207 (2pts), #7177 (2pts), #7202 (2pts), #7044 (1pts), #7103 (2pts), #7097 (4pts - Release Merger), #7183 (2pts))
MikesGlitch: 15 (PRs: #7118 (2pts), #7091 (1pts), #7200 (6pts), #7062 (6pts))
lelemm: 6 (PRs: #7155 (6pts))

Docs Review Statistics:
=======================
youngcw: 8 (PRs: #7244 (4pts), #7117 (2pts), #7200 (2pts))
matt-fidd: 6 (PRs: #7244 (4pts), #7200 (2pts))
joel-jeremy: 4 (PRs: #7240 (2pts), #7117 (2pts))
MatissJanis: 4 (PRs: #7199 (2pts), #6926 (2pts))
MikesGlitch: 4 (PRs: #7096 (2pts), #7200 (2pts))

Points Summary:
===============
youngcw: 205
MatissJanis: 140
matt-fidd: 137
joel-jeremy: 124
jfdoming: 45
MikesGlitch: 32
lelemm: 6

Total points earned: 689

Checklist

Release notes added (see link above)
No obvious regressions in affected areas
Self-review has been performed - I understand what each change in the code does and why it is needed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7305 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 3/27/2026 **Status:** ✅ Merged **Merged:** 3/27/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `points-count-docs` --- ### 📝 Commits (2) - [`92b4532`](https://github.com/actualbudget/actual/commit/92b45320be2c210bd4045f3d0ca614cce42e680d) fix - [`cf7bc93`](https://github.com/actualbudget/actual/commit/cf7bc93e6c255d3c507615db972b02b2785ba449) note ### 📊 Changes **2 files changed** (+30 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.github/scripts/count-points.mjs` (+24 -8) ➕ `upcoming-release-notes/7305.md` (+6 -0) </details> ### 📄 Description  ## Description  Changes to spelling workflows were being credited as code changes, and changes to the package.json in docs were being credited as docs changes, causing cases where sometimes reviewers would be given the minimum points count for both categories instead of just one. Adding in globs here makes it more easily expandable if we find other issues with file categorisation ## Related issue(s)  Reported on discord ## Testing  Run locally against PRs 7244 and 7223 Before: ``` Code Review Statistics: ======================= youngcw: 170 (PRs: #7272 (6pts), #7151 (1pts), #7244 (1pts), #7268 (2pts), #7153 (6pts), #7239 (8pts), #7267 (2pts), #7155 (6pts), #7172 (8pts), #7152 (6pts), #7118 (2pts), #7163 (6pts), #7194 (6pts), #7107 (2pts), #7145 (6pts), #7101 (6pts), #7095 (1pts), #7078 (8pts), #7209 (2pts), #7200 (6pts), #7047 (2pts), #7057 (6pts), #7041 (2pts), #7232 (6pts), #7125 (6pts), #7005 (2pts), #7196 (1pts), #7038 (8pts), #6903 (8pts), #6414 (6pts), #7105 (1pts), #7117 (6pts), #6741 (2pts), #7091 (1pts), #7223 (2pts), #6620 (8pts), #7092 (2pts), #7181 (2pts), #7069 (2pts), #6693 (6pts)) joel-jeremy: 115 (PRs: #7275 (1pts), #7248 (1pts), #7236 (6pts), #7224 (2pts), #7155 (6pts), #7172 (8pts), #7118 (2pts), #7163 (6pts), #7230 (2pts), #7194 (6pts), #7107 (2pts), #7144 (1pts), #7073 (1pts), #7095 (1pts), #7142 (2pts), #7146 (1pts), #7057 (6pts), #7232 (6pts), #7229 (2pts), #7005 (2pts), #7240 (8pts), #7111 (6pts), #7100 (1pts), #7105 (1pts), #7117 (6pts), #6741 (2pts), #7091 (1pts), #7187 (6pts), #7092 (2pts), #7181 (2pts), #7074 (6pts), #7050 (6pts), #7051 (2pts), #7053 (2pts)) matt-fidd: 91 (PRs: #7275 (1pts), #7274 (6pts), #7249 (1pts), #7166 (6pts), #7264 (1pts), #7245 (1pts), #7244 (1pts), #7168 (2pts), #7185 (2pts), #7139 (6pts), #7180 (2pts), #7188 (6pts), #7191 (2pts), #7152 (6pts), #7073 (1pts), #7101 (6pts), #7195 (2pts), #7209 (2pts), #7200 (6pts), #7193 (2pts), #6972 (6pts), #7219 (1pts), #6903 (8pts), #7100 (1pts), #7105 (1pts), #7104 (1pts), #7071 (2pts), #7181 (2pts), #7074 (6pts), #7055 (1pts)) MatissJanis: 48 (PRs: #7149 (2pts), #7197 (1pts), #7143 (1pts), #7222 (2pts), #7234 (6pts), #7227 (6pts), #7140 (1pts), #7130 (1pts), #7172 (8pts), #7129 (1pts), #7107 (2pts), #7141 (1pts), #6926 (6pts), #7184 (6pts), #7223 (2pts), #7075 (2pts)) jfdoming: 31 (PRs: #7177 (2pts), #7234 (6pts), #7224 (2pts), #7155 (6pts), #7207 (2pts), #7179 (2pts), #7044 (1pts), #7202 (2pts), #7097 (4pts - Release Merger), #7103 (2pts), #7183 (2pts)) MikesGlitch: 15 (PRs: #7118 (2pts), #7200 (6pts), #7091 (1pts), #7062 (6pts)) lelemm: 6 (PRs: #7155 (6pts)) Docs Review Statistics: ======================= youngcw: 10 (PRs: #7244 (4pts), #7200 (2pts), #7117 (2pts), #7223 (2pts)) MatissJanis: 8 (PRs: #7199 (2pts), #7222 (2pts), #6926 (2pts), #7223 (2pts)) joel-jeremy: 6 (PRs: #7229 (2pts), #7240 (2pts), #7117 (2pts)) matt-fidd: 6 (PRs: #7244 (4pts), #7200 (2pts)) MikesGlitch: 4 (PRs: #7096 (2pts), #7200 (2pts)) Points Summary: =============== youngcw: 208 MatissJanis: 144 matt-fidd: 138 joel-jeremy: 126 jfdoming: 45 MikesGlitch: 32 lelemm: 6 Total points earned: 699 ``` After: ``` Code Review Statistics: ======================= youngcw: 169 (PRs: #7272 (6pts), #7151 (1pts), #7268 (2pts), #7155 (6pts), #7118 (2pts), #7239 (8pts), #7153 (6pts), #7172 (8pts), #7267 (2pts), #7196 (1pts), #7152 (6pts), #7107 (2pts), #7209 (2pts), #7232 (6pts), #7101 (6pts), #7095 (1pts), #7078 (8pts), #7145 (6pts), #7057 (6pts), #7047 (2pts), #7041 (2pts), #7005 (2pts), #7117 (6pts), #7125 (6pts), #6741 (2pts), #7038 (8pts), #7181 (2pts), #6903 (8pts), #7105 (1pts), #7223 (2pts), #6620 (8pts), #6414 (6pts), #7092 (2pts), #7091 (1pts), #7194 (6pts), #7200 (6pts), #7069 (2pts), #7163 (6pts), #6693 (6pts)) joel-jeremy: 115 (PRs: #7275 (1pts), #7240 (8pts), #7155 (6pts), #7118 (2pts), #7172 (8pts), #7248 (1pts), #7230 (2pts), #7146 (1pts), #7236 (6pts), #7107 (2pts), #7224 (2pts), #7073 (1pts), #7232 (6pts), #7095 (1pts), #7144 (1pts), #7229 (2pts), #7142 (2pts), #7057 (6pts), #7187 (6pts), #7005 (2pts), #7117 (6pts), #6741 (2pts), #7181 (2pts), #7105 (1pts), #7100 (1pts), #7111 (6pts), #7092 (2pts), #7091 (1pts), #7194 (6pts), #7074 (6pts), #7163 (6pts), #7050 (6pts), #7051 (2pts), #7053 (2pts)) matt-fidd: 90 (PRs: #7188 (6pts), #7166 (6pts), #7249 (1pts), #7275 (1pts), #7245 (1pts), #7185 (2pts), #7264 (1pts), #7274 (6pts), #7168 (2pts), #7193 (2pts), #7139 (6pts), #7191 (2pts), #7219 (1pts), #7195 (2pts), #7152 (6pts), #7209 (2pts), #7180 (2pts), #7073 (1pts), #7101 (6pts), #6972 (6pts), #7181 (2pts), #6903 (8pts), #7105 (1pts), #7104 (1pts), #7100 (1pts), #7200 (6pts), #7074 (6pts), #7071 (2pts), #7055 (1pts)) MatissJanis: 48 (PRs: #7197 (1pts), #7149 (2pts), #7143 (1pts), #7140 (1pts), #7129 (1pts), #7234 (6pts), #7172 (8pts), #7107 (2pts), #7222 (2pts), #7227 (6pts), #7141 (1pts), #7130 (1pts), #6926 (6pts), #7223 (2pts), #7184 (6pts), #7075 (2pts)) jfdoming: 31 (PRs: #7155 (6pts), #7234 (6pts), #7179 (2pts), #7224 (2pts), #7207 (2pts), #7177 (2pts), #7202 (2pts), #7044 (1pts), #7103 (2pts), #7097 (4pts - Release Merger), #7183 (2pts)) MikesGlitch: 15 (PRs: #7118 (2pts), #7091 (1pts), #7200 (6pts), #7062 (6pts)) lelemm: 6 (PRs: #7155 (6pts)) Docs Review Statistics: ======================= youngcw: 8 (PRs: #7244 (4pts), #7117 (2pts), #7200 (2pts)) matt-fidd: 6 (PRs: #7244 (4pts), #7200 (2pts)) joel-jeremy: 4 (PRs: #7240 (2pts), #7117 (2pts)) MatissJanis: 4 (PRs: #7199 (2pts), #6926 (2pts)) MikesGlitch: 4 (PRs: #7096 (2pts), #7200 (2pts)) Points Summary: =============== youngcw: 205 MatissJanis: 140 matt-fidd: 137 joel-jeremy: 124 jfdoming: 45 MikesGlitch: 32 lelemm: 6 Total points earned: 689 ``` ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-21 00:11:51 -05:00

GiteaMirror closed this issue

2026-04-21 00:11:54 -05:00

Sign in to join this conversation.

Branches Tags

master

claude/hide-default-categories-1cwBZ

matiss/crdt-source-loading

youngcw/unlock-duplicates

matiss/crdt-protobuf

release/26.5.0

claude/update-issue-template-ykMNn

claude/fix-issue-7667-DPXi3

cursor/formula-feedback-improvements-4223

cursor/resolve-pr-7449-ee11

claude/fix-typescript-build-error-JPtZ5

jfdoming/api-tokens-part-3

jfdoming/api-tokens-part-2

jfdoming/api-tokens-part-1

claude/speed-up-vrt-workflow-ZAyI5

claude/crdt-version-auto-publish-Ph1BH

copilot/add-repository-configs-to-packages

worktree-compressed-drifting-ritchie

worktree-mellow-strolling-dawn

matiss/browser-api

claude/api-consumer-verification-kfz1K

feature/enable-banking

cursor/transaction-table-rewrite-f077

pr-7454

claude/fix-issue-7410-LLLQ4

release/v100.0.0

revert-7350-trim-deps

revert-7220-sankey-report

revert-7242-fix/split-parent-update-corruption

revert-7281-generate-icons

claude/electron-to-tauri-migration-LjBN8

worktree-remotion

release/vv26.4.0-pre

claude/browser-compatible-api-QbhHh

claude/improve-cli-transactions-waTUY

claude/publish-react-native-ios-j8qoT

js-proxy

claude/fix-flaky-ci-job-5gDdz

react-query-rules

react-query-useSchedules

claude/nightly-theme-validation-scan-DzOGD

claude/debug-simplefin-error-ZuKzB

matiss/desktop-client-subpath-imports

claude/fix-simplefin-ssrf-T31gX

claude/release-notes-validation-X7rvR

add-claude-github-actions-1772738270730

cursor/sync-performance-notification-9899

react-query-prefs

matiss/chunked-sync-and-progress-ux

v26.2.1

copilot/sub-pr-6880

fix-react-query-clear-on-close-budget

copilot/sub-pr-6140

feat/auto-note

feat/scoped-bank-sync

cursor/desktop-transactions-react-table-1d0c

fix-exhaustive-deps-App

copilot/fix-find-replace-bug

release/v26.2.0-pre

matiss/browser-tests

mobile-fix-drag-and-drop-across-groups

budget-table-v2

PayeeAutocomplete2

pglite

bugfix/plugins/fix-plugins-sw

feat/plugins/plugins-core-package

prerelease

matiss/unicode-minus-fix

cursor/fix-actual-github-issue-6206-gemini-3-pro-preview-9c37

TransactionFormPage

cursor/implement-mortgage-and-loan-account-type-78ca

tests-update-fill-with-pressSequentially

mobile/link-modal

deps/25.11

cursor/fix-update-vrt-apply-ci-job-dispatch-b324

sync-server-plugins

cursor/propose-patch-for-github-issue-5680-2a18

fix/compiler-preserve-inner-dollar-escapes

cursor/analyze-actual-budget-issue-and-propose-fix-5b70

coderabbitai/docstrings/0c070e5

cursor/add-wip-prefix-and-comment-to-prs-d78d

jfdoming/08-21-auto-focus-on-navigate-in-all-browsers

show-totals-on-mobile-budget-banners

allow-child-transactions-make-transfer

mobile-calculator-keyboard

payee-geolocation

enhance/restore_scroll_position

dm-fix-second-click-on-mobile-new-transaction-2

scrollToLocationBudget

alert-autofix-38

tsconfig-composite

mobile-fix-uncategorized-transactions-on-tracking-budgets

server-budget-handlers

fix-sql-injection-in-cleanup-template

non-chrome-draggable-workaround

mobile-budget-page-swipe-navigation

ts-db-all

stable

dark-theme-with-brand-colors

fix-mobile-delete-group

ts-db-select

UnderKoen/reconcile-context-menu

master-before-server-merge

v25.2.1

ts-runQuery

rename-redux-hooks

UnderKoen/3557-persist-state-in-history

remove-redux-CLOSE_BUDGET

fix-exhaustive-deps-errors-FinancesApp

redux-toolkit-createSlice-backup

accounts-function-component

ts-useSplitsExpanded

loot-core-server-package

useTransactios-in-TransactionEdit

react-aria-input

move-redux-to-desktop-client

QueryState-type

fix-themes-applied-late

mobile-vrts

revert-3295-spendingCardFix

react-aria-button-4

split-payee-on-mobile

twk3/pin-apis-crdt

notes-tag-autocomplete

ts-LoadBackup

dnd-kit

package-upgrades

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/actual#37267