[PR #1408] [MERGED] Search Bar Changes #3719

Closed
opened 2026-02-28 20:45:43 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1408
Author: @carkom
Created: 7/28/2023
Status: Merged
Merged: 7/30/2023
Merged by: @j-f1

Base: masterHead: searchBar


📝 Commits (10+)

  • 94c6d3c Proof of concept
  • 2475ab8 notes
  • bae9745 Add Schedules and Payees
  • bd6ec33 Merge branch 'master' into searchBar
  • d9126b6 Normalize Search Bars
  • 3953363 Merge branch 'master' into searchBar
  • 7d98736 code review changes
  • 8d4534b Merge branch 'master' into searchBar
  • 3b738d6 formatting/revert color changes
  • 471b10e Merge branch 'master' into searchBar

📊 Changes

11 files changed (+107 additions, -113 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.js (+4 -17)
📝 packages/desktop-client/src/components/accounts/Header.js (+8 -50)
📝 packages/desktop-client/src/components/common/Input.tsx (+7 -4)
📝 packages/desktop-client/src/components/common/InputWithContent.tsx (+7 -6)
📝 packages/desktop-client/src/components/common/Search.tsx (+56 -10)
📝 packages/desktop-client/src/components/payees/index.js (+10 -19)
📝 packages/desktop-client/src/components/schedules/index.js (+1 -1)
📝 packages/desktop-client/src/components/table.tsx (+1 -1)
📝 packages/desktop-client/src/style/themes/dark.ts (+4 -3)
📝 packages/desktop-client/src/style/themes/light.ts (+3 -2)
upcoming-release-notes/1408.md (+6 -0)

📄 Description

Looking to make the search bar a bit more user friendly while also avoiding it being too loud.

It's been suggested that this also be applied to all search bars (payees, schedules, etc.) - which I'm fine with.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1408 **Author:** [@carkom](https://github.com/carkom) **Created:** 7/28/2023 **Status:** ✅ Merged **Merged:** 7/30/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `searchBar` --- ### 📝 Commits (10+) - [`94c6d3c`](https://github.com/actualbudget/actual/commit/94c6d3c060bc723f1e9a9dab85ffa0fb501b53f3) Proof of concept - [`2475ab8`](https://github.com/actualbudget/actual/commit/2475ab807913687144b2c08e53cf8d3ed078c9f0) notes - [`bae9745`](https://github.com/actualbudget/actual/commit/bae974508bbf9895a27cd292536a0923567f181b) Add Schedules and Payees - [`bd6ec33`](https://github.com/actualbudget/actual/commit/bd6ec33e37c6f65fd7de20ef33fdb2aaf09cd631) Merge branch 'master' into searchBar - [`d9126b6`](https://github.com/actualbudget/actual/commit/d9126b67c35ee6f2c48f9b6b8add24df7bb6bc4f) Normalize Search Bars - [`3953363`](https://github.com/actualbudget/actual/commit/395336348a22dfdb511c453dfb6705490f5659b5) Merge branch 'master' into searchBar - [`7d98736`](https://github.com/actualbudget/actual/commit/7d98736d91acd67685a8cde208a106f3a8c143bb) code review changes - [`8d4534b`](https://github.com/actualbudget/actual/commit/8d4534baa001f6101773b3e10077b93f75d4ab35) Merge branch 'master' into searchBar - [`3b738d6`](https://github.com/actualbudget/actual/commit/3b738d61ea6f14dcb094af4ca223b33eb99855c0) formatting/revert color changes - [`471b10e`](https://github.com/actualbudget/actual/commit/471b10e611ebbbfa7963525f3e7c3d5f0d0c1fc5) Merge branch 'master' into searchBar ### 📊 Changes **11 files changed** (+107 additions, -113 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.js` (+4 -17) 📝 `packages/desktop-client/src/components/accounts/Header.js` (+8 -50) 📝 `packages/desktop-client/src/components/common/Input.tsx` (+7 -4) 📝 `packages/desktop-client/src/components/common/InputWithContent.tsx` (+7 -6) 📝 `packages/desktop-client/src/components/common/Search.tsx` (+56 -10) 📝 `packages/desktop-client/src/components/payees/index.js` (+10 -19) 📝 `packages/desktop-client/src/components/schedules/index.js` (+1 -1) 📝 `packages/desktop-client/src/components/table.tsx` (+1 -1) 📝 `packages/desktop-client/src/style/themes/dark.ts` (+4 -3) 📝 `packages/desktop-client/src/style/themes/light.ts` (+3 -2) ➕ `upcoming-release-notes/1408.md` (+6 -0) </details> ### 📄 Description Looking to make the search bar a bit more user friendly while also avoiding it being too loud. It's been suggested that this also be applied to all search bars (payees, schedules, etc.) - which I'm fine with. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:43 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3719