github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1405] [MERGED] Port the settings components to TS #3717

New Issue
Closed
opened 2026-02-28 20:45:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:45:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1405
Author: @j-f1
Created: 7/28/2023
Status: ✅ Merged
Merged: 7/30/2023
Merged by: @j-f1

Base: master ← Head: jed/settings-ts

📝 Commits (10+)

  • e61f76a Fix type for modal that takes no options
  • a3016d3 Refine Select types
  • dc05b4b Refine pref action types
  • 7be57df Refine pref types
  • 70d0dff Add saveFile & openDialog methods on window.Actual
  • 4530a73 Port Page to TS
  • 8022839 Port the settings page to TS
  • 50c3d1e Improve the modal types
  • c9ee4cc More modal type corrections
  • 2246e1f Propagate errors out of sync-budget

📊 Changes

22 files changed (+130 additions, -78 deletions)

View changed files

📝 packages/desktop-client/src/components/Page.tsx (+21 -8)
📝 packages/desktop-client/src/components/common/Select.tsx (+8 -8)
📝 packages/desktop-client/src/components/settings/Encryption.tsx (+1 -0)
📝 packages/desktop-client/src/components/settings/Experimental.tsx (+1 -0)
📝 packages/desktop-client/src/components/settings/Export.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/FixSplits.tsx (+5 -2)
📝 packages/desktop-client/src/components/settings/Format.tsx (+12 -26)
📝 packages/desktop-client/src/components/settings/Global.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/Reset.tsx (+0 -0)
📝 packages/desktop-client/src/components/settings/Themes.tsx (+0 -0)
📝 packages/desktop-client/src/components/settings/UI.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/index.tsx (+2 -2)
📝 packages/loot-core/src/client/actions/modals.ts (+20 -7)
📝 packages/loot-core/src/client/actions/prefs.ts (+3 -2)
📝 packages/loot-core/src/client/state-types/modals.d.ts (+19 -14)
📝 packages/loot-core/src/server/main.ts (+2 -2)
📝 packages/loot-core/src/server/sync/index.ts (+5 -1)
📝 packages/loot-core/src/types/prefs.d.ts (+6 -1)
📝 packages/loot-core/src/types/server-handlers.d.ts (+3 -1)
📝 packages/loot-core/src/types/util.d.ts (+5 -1)

...and 2 more files

📄 Description

This also includes refinements for a few related types.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1405 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/28/2023 **Status:** ✅ Merged **Merged:** 7/30/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/settings-ts` --- ### 📝 Commits (10+) - [`e61f76a`](https://github.com/actualbudget/actual/commit/e61f76a59486ff1aff8a6637457ea555e93e6cb4) Fix type for modal that takes no options - [`a3016d3`](https://github.com/actualbudget/actual/commit/a3016d3703f540fe46604ab9cabc9305bb85becd) Refine Select types - [`dc05b4b`](https://github.com/actualbudget/actual/commit/dc05b4b285c323ac06e5ffb4ed58dbbc36b77963) Refine pref action types - [`7be57df`](https://github.com/actualbudget/actual/commit/7be57df6c496b5e911fe00014815b032ef39fddf) Refine pref types - [`70d0dff`](https://github.com/actualbudget/actual/commit/70d0dff14957af3bf7601ea7eaa57933fa64693f) Add saveFile & openDialog methods on window.Actual - [`4530a73`](https://github.com/actualbudget/actual/commit/4530a73a557e26b3bfe974bd66c86e9e26933acd) Port Page to TS - [`8022839`](https://github.com/actualbudget/actual/commit/8022839af7e959a5ede75d6bd0abf3095736d2d1) Port the settings page to TS - [`50c3d1e`](https://github.com/actualbudget/actual/commit/50c3d1ec95401b8f40b4622818c4a80ced6a8528) Improve the modal types - [`c9ee4cc`](https://github.com/actualbudget/actual/commit/c9ee4ccbf26c7aef86cc988b704063ab86ccc0a8) More modal type corrections - [`2246e1f`](https://github.com/actualbudget/actual/commit/2246e1fd85ef8a550c77809a5f5a9f9df0ffaa67) Propagate errors out of sync-budget ### 📊 Changes **22 files changed** (+130 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Page.tsx` (+21 -8) 📝 `packages/desktop-client/src/components/common/Select.tsx` (+8 -8) 📝 `packages/desktop-client/src/components/settings/Encryption.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/settings/Export.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/FixSplits.tsx` (+5 -2) 📝 `packages/desktop-client/src/components/settings/Format.tsx` (+12 -26) 📝 `packages/desktop-client/src/components/settings/Global.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/Reset.tsx` (+0 -0) 📝 `packages/desktop-client/src/components/settings/Themes.tsx` (+0 -0) 📝 `packages/desktop-client/src/components/settings/UI.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/index.tsx` (+2 -2) 📝 `packages/loot-core/src/client/actions/modals.ts` (+20 -7) 📝 `packages/loot-core/src/client/actions/prefs.ts` (+3 -2) 📝 `packages/loot-core/src/client/state-types/modals.d.ts` (+19 -14) 📝 `packages/loot-core/src/server/main.ts` (+2 -2) 📝 `packages/loot-core/src/server/sync/index.ts` (+5 -1) 📝 `packages/loot-core/src/types/prefs.d.ts` (+6 -1) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+3 -1) 📝 `packages/loot-core/src/types/util.d.ts` (+5 -1) _...and 2 more files_ </details> ### 📄 Description This also includes refinements for a few related types. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3717
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?