github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1402] [MERGED] Bugfix row render #3714

New Issue
Closed
opened 2026-02-28 20:45:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:45:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1402
Author: @biohzrddd
Created: 7/27/2023
Status: ✅ Merged
Merged: 8/13/2023
Merged by: @joel-jeremy

Base: master ← Head: bugfix-row-render

📝 Commits (4)

  • 45e05e6 Fix re-rendering all rows on hover
  • b55d70c release note
  • 7bca829 Merge remote-tracking branch 'upstream/master' into bugfix-row-render
  • a0dbe4b Removing isHover logic in place of css :hover

📊 Changes

2 files changed (+16 additions, -28 deletions)

View changed files

📝 packages/desktop-client/src/components/transactions/TransactionsTable.js (+10 -28)
➕ upcoming-release-notes/1402.md (+6 -0)

📄 Description

Fixed bug where all Account Transaction rows would be re-rendered on hover of a single Transaction row.

Watch the logged call count in the below movies. Before it goes up by 20+ (however many transactions are loaded) every time the mouse moves one row, after it goes up by 2 (the one being left and the one entered).

Before:
Screencast_from_07-27-2023_090817_PM.webm

After:
Screencast_from_07-27-2023_103038_PM.webm

Note: there is still an existing re-render bug where selecting one row re-renders all other rows unnecessarily.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1402 **Author:** [@biohzrddd](https://github.com/biohzrddd) **Created:** 7/27/2023 **Status:** ✅ Merged **Merged:** 8/13/2023 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `bugfix-row-render` --- ### 📝 Commits (4) - [`45e05e6`](https://github.com/actualbudget/actual/commit/45e05e6217f99cab49ba09c46a43bba6cbcb3ae3) Fix re-rendering all rows on hover - [`b55d70c`](https://github.com/actualbudget/actual/commit/b55d70c5f95a4cf8e716b52040327295ce7ab4c0) release note - [`7bca829`](https://github.com/actualbudget/actual/commit/7bca8292f27c5461c21aa31a0388b2d787d21a3b) Merge remote-tracking branch 'upstream/master' into bugfix-row-render - [`a0dbe4b`](https://github.com/actualbudget/actual/commit/a0dbe4b17d4fbea6ba91c0e0360b4c9942e8a1aa) Removing isHover logic in place of css :hover ### 📊 Changes **2 files changed** (+16 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.js` (+10 -28) ➕ `upcoming-release-notes/1402.md` (+6 -0) </details> ### 📄 Description Fixed bug where all Account Transaction rows would be re-rendered on hover of a single Transaction row. Watch the logged call count in the below movies. Before it goes up by 20+ (however many transactions are loaded) every time the mouse moves one row, after it goes up by 2 (the one being left and the one entered). Before: [Screencast_from_07-27-2023_090817_PM.webm](https://github.com/actualbudget/actual/assets/10577752/94ab0d52-ebee-4d16-ab1c-93061483d344) After: [Screencast_from_07-27-2023_103038_PM.webm](https://github.com/actualbudget/actual/assets/10577752/5741dca2-0f29-4e11-a91e-4d88dcb19cc6) Note: there is still an existing re-render bug where selecting one row re-renders all other rows unnecessarily. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3714
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?