github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7046] [CLOSED] Remove global loot-core path alias from root tsconfig #37095

New Issue
Closed
opened 2026-04-20 23:53:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 23:53:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7046
Author: @PratikSilwal5
Created: 2/22/2026
Status: ❌ Closed

Base: master ← Head: enforce-boundary

📝 Commits (10+)

📊 Changes

4 files changed (+11 additions, -20 deletions)

View changed files

📝 packages/loot-core/package.json (+2 -2)
📝 packages/loot-core/tsconfig.json (+3 -16)
📝 tsconfig.json (+0 -2)
➕ upcoming-release-notes/7046.md (+6 -0)

📄 Description

Fixes Issue #7017

The global paths entry was what allowed packages without loot-core as an explicit dependency (e.g. sync-server) to silently resolve loot-core imports through the TypeScript compiler. Removing it means any future loot-core import in sync-server would require explicitly adding loot-core to sync-server/package.json, making the violation obvious in PR review.

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.85 MB 0%
loot-core 1 5.82 MB 0%
api 1 4.43 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.85 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 9.54 MB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/ca.js 188.15 kB 0%
static/js/da.js 106.35 kB 0%
static/js/de.js 180.07 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 170.37 kB 0%
static/js/es.js 174.55 kB 0%
static/js/fr.js 179.6 kB 0%
static/js/it.js 171.16 kB 0%
static/js/nb-NO.js 156.96 kB 0%
static/js/nl.js 106.37 kB 0%
static/js/pl.js 88.37 kB 0%
static/js/pt-BR.js 154.22 kB 0%
static/js/th.js 181.87 kB 0%
static/js/uk.js 214.74 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.16 MB 0%
static/js/narrow.js 637.68 kB 0%
static/js/TransactionList.js 106.22 kB 0%
static/js/wide.js 164.15 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 10.04 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.82 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BwrdDDMW.js 5.82 MB 0%

api

Total

Files count Total bundle size % Changed
1 4.43 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
bundle.api.js 4.43 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7046 **Author:** [@PratikSilwal5](https://github.com/PratikSilwal5) **Created:** 2/22/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `enforce-boundary` --- ### 📝 Commits (10+) - [`bea2bf4`](https://github.com/actualbudget/actual/commit/bea2bf40a65cace98bd91c2bc7888cf2a8777b08) remove the global path entry for loot-core - [`a9b2318`](https://github.com/actualbudget/actual/commit/a9b231889fb04b32d60979db8e61954b41a712bb) fixed two broken export entries - [`412e328`](https://github.com/actualbudget/actual/commit/412e32836abbdc76c8acdde29a11ca908e8ced06) add release notes - [`b85eea3`](https://github.com/actualbudget/actual/commit/b85eea309a0ed72aa3ee03b1cf2f708c015274c2) Rename 7047.md to 7046.md - [`7fd9670`](https://github.com/actualbudget/actual/commit/7fd96706cbd68debee0982e3cd627c210c42e394) fix broken exports - [`e248838`](https://github.com/actualbudget/actual/commit/e248838c710856151c67a23e2f08e7a93870f67e) Merge branch 'enforce-boundary' of https://github.com/PratikSilwal5/actual into enforce-boundary - [`b69ddae`](https://github.com/actualbudget/actual/commit/b69ddae73e223d6ae061b0873e30c0afc5c6499f) Merge branch 'master' into enforce-boundary - [`1597127`](https://github.com/actualbudget/actual/commit/159712797845228d7f3c50e6afd106ff1e6dab11) Fix merge conflict in package.json - [`3c81bd3`](https://github.com/actualbudget/actual/commit/3c81bd3ae9fbe5448a3c05141aca697a0f674d68) [autofix.ci] apply automated fixes - [`85f81dc`](https://github.com/actualbudget/actual/commit/85f81dc2cf9c3d43818a646ed1992daf8b930e6c) fix ### 📊 Changes **4 files changed** (+11 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/package.json` (+2 -2) 📝 `packages/loot-core/tsconfig.json` (+3 -16) 📝 `tsconfig.json` (+0 -2) ➕ `upcoming-release-notes/7046.md` (+6 -0) </details> ### 📄 Description Fixes Issue #7017 The global paths entry was what allowed packages without loot-core as an explicit dependency (e.g. sync-server) to silently resolve loot-core imports through the TypeScript compiler. Removing it means any future loot-core import in sync-server would require explicitly adding loot-core to sync-server/package.json, making the violation obvious in PR review. <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.85 MB | 0% loot-core | 1 | 5.82 MB | 0% api | 1 | 4.43 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.85 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.54 MB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/ca.js | 188.15 kB | 0% static/js/da.js | 106.35 kB | 0% static/js/de.js | 180.07 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 170.37 kB | 0% static/js/es.js | 174.55 kB | 0% static/js/fr.js | 179.6 kB | 0% static/js/it.js | 171.16 kB | 0% static/js/nb-NO.js | 156.96 kB | 0% static/js/nl.js | 106.37 kB | 0% static/js/pl.js | 88.37 kB | 0% static/js/pt-BR.js | 154.22 kB | 0% static/js/th.js | 181.87 kB | 0% static/js/uk.js | 214.74 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.16 MB | 0% static/js/narrow.js | 637.68 kB | 0% static/js/TransactionList.js | 106.22 kB | 0% static/js/wide.js | 164.15 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 10.04 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.82 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BwrdDDMW.js | 5.82 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.43 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.43 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:53:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#37095
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?