github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1395] [MERGED] Refactor buttons a bit, enable dark mode #3709

New Issue
Closed
opened 2026-02-28 20:45:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:45:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1395
Author: @j-f1
Created: 7/24/2023
Status: ✅ Merged
Merged: 7/26/2023
Merged by: @j-f1

Base: master ← Head: jed/button

📝 Commits (10+)

  • a54136d Add a “type” prop to and friends instead of using separate booleans
  • 899e3db Auto-apply the native type prop as appropriate
  • 1dd7bd5 Apply themes to the button
  • 1934b6d Remove 'development' theme
  • 3cc8594 Update dark theme button styles a bit
  • c87ba15 Fix some visual issues / finish adding colors
  • ede454b Fix normalDisabled button border
  • 0a851d8 Refactor to not use
  • f3f977b Clean up FatalError styles
  • 3a3bf43 Add release note

📊 Changes

76 files changed (+402 additions, -432 deletions)

View changed files

📝 packages/desktop-client/src/components/FatalError.js (+1 -14)
📝 packages/desktop-client/src/components/LoggedInUser.js (+1 -1)
📝 packages/desktop-client/src/components/ManageRules.js (+1 -1)
📝 packages/desktop-client/src/components/NotesButton.tsx (+1 -1)
📝 packages/desktop-client/src/components/Notifications.tsx (+2 -2)
📝 packages/desktop-client/src/components/SidebarWithData.js (+2 -2)
📝 packages/desktop-client/src/components/ThemeSelector.tsx (+1 -1)
📝 packages/desktop-client/src/components/Titlebar.js (+7 -7)
📝 packages/desktop-client/src/components/UpdateNotification.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/Account.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.js (+6 -2)
📝 packages/desktop-client/src/components/accounts/Balance.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/Header.js (+5 -5)
📝 packages/desktop-client/src/components/accounts/MobileAccountDetails.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/Reconcile.js (+2 -2)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+1 -29)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js (+10 -23)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+5 -5)
📝 packages/desktop-client/src/components/budget/misc.js (+3 -3)

...and 56 more files

📄 Description

Buttons have a new type prop that prevents nonsensical configurations like <Button bare primary>

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1395 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/24/2023 **Status:** ✅ Merged **Merged:** 7/26/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/button` --- ### 📝 Commits (10+) - [`a54136d`](https://github.com/actualbudget/actual/commit/a54136da8b48a3cb7c7054bd4574a26fc4d729d1) Add a “type” prop to <Button> and friends instead of using separate booleans - [`899e3db`](https://github.com/actualbudget/actual/commit/899e3db7ff9eda0ef7a8be5f2ea4e5038b931811) Auto-apply the native `type` prop as appropriate - [`1dd7bd5`](https://github.com/actualbudget/actual/commit/1dd7bd5635452ab90b53c1f101d49d63e2c87d4e) Apply themes to the button - [`1934b6d`](https://github.com/actualbudget/actual/commit/1934b6d975813142e4c2da845301182cca3484e1) Remove 'development' theme - [`3cc8594`](https://github.com/actualbudget/actual/commit/3cc8594a8ed22a78272fe8cee6f9550ac5e4d634) Update dark theme button styles a bit - [`c87ba15`](https://github.com/actualbudget/actual/commit/c87ba152e39107b102c241fb01b6bde45b483d86) Fix some visual issues / finish adding colors - [`ede454b`](https://github.com/actualbudget/actual/commit/ede454be584de46df3f887700b60e0fccac043af) Fix normalDisabled button border - [`0a851d8`](https://github.com/actualbudget/actual/commit/0a851d89326c43af36894c432a45dcc77e78d1d4) Refactor <LinkButton> to not use <Button> - [`f3f977b`](https://github.com/actualbudget/actual/commit/f3f977b44cb9e8431b8633ad5da0895530a25771) Clean up FatalError styles - [`3a3bf43`](https://github.com/actualbudget/actual/commit/3a3bf43d0de35861c207b21832f05e5f18d939f2) Add release note ### 📊 Changes **76 files changed** (+402 additions, -432 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/FatalError.js` (+1 -14) 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+1 -1) 📝 `packages/desktop-client/src/components/ManageRules.js` (+1 -1) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+2 -2) 📝 `packages/desktop-client/src/components/ThemeSelector.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/Titlebar.js` (+7 -7) 📝 `packages/desktop-client/src/components/UpdateNotification.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.js` (+6 -2) 📝 `packages/desktop-client/src/components/accounts/Balance.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Header.js` (+5 -5) 📝 `packages/desktop-client/src/components/accounts/MobileAccountDetails.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Reconcile.js` (+2 -2) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+1 -29) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js` (+10 -23) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+5 -5) 📝 `packages/desktop-client/src/components/budget/misc.js` (+3 -3) _...and 56 more files_ </details> ### 📄 Description Buttons have a new `type` prop that prevents nonsensical configurations like `<Button bare primary>` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3709
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?