github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1385] [MERGED] Remove double scrollbar as the screen is big enough #3704

New Issue
Closed
opened 2026-02-28 20:45:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:45:31 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1385
Author: @aleetsaiya
Created: 7/22/2023
Status: ✅ Merged
Merged: 7/23/2023
Merged by: @MatissJanis

Base: master ← Head: remove-double-scrollbar

📝 Commits (4)

  • 5a9b3dd remove double scrollbar as the screen is big enough
  • 1eb4b5f add release note
  • d8056fd fix lint
  • 4ea7720 remove the horizontal scrollbar under the transaction table

📊 Changes

3 files changed (+9 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/FixedSizeList.js (+1 -1)
📝 packages/desktop-client/src/style/styles.ts (+3 -1)
➕ upcoming-release-notes/1385.md (+5 -0)

📄 Description

Resolves #1358

This change will make users can scroll the whole page while the viewport height is lower than 550px, but cannot when higher.

I don't really sure which is the "good" height number to determine should users have ability to scroll the whole page or not.

The double scrollbar is helpful to the budget page because the upper component always stand 250px height. The outer scrollbar make users have ability to scroll down to focus on another part. Otherwise, their screen will always be occupied by the upper component.
截圖 2023-07-23 上午2 16 20

However, to the transaction table page. This outer scrollbar is meaningless from my perspective, because the upper component is very small, even right now I've limited the height to ensure the outer scrollbar only appear when the viewport height is lower than 550px, it still meaningless from my persepctive.

Maybe I should custom the height limitation for different page or current is good enought?

截圖 2023-07-23 上午2 30 03

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1385 **Author:** [@aleetsaiya](https://github.com/aleetsaiya) **Created:** 7/22/2023 **Status:** ✅ Merged **Merged:** 7/23/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `remove-double-scrollbar` --- ### 📝 Commits (4) - [`5a9b3dd`](https://github.com/actualbudget/actual/commit/5a9b3ddda3963cd777207d0119e4983af871ce13) remove double scrollbar as the screen is big enough - [`1eb4b5f`](https://github.com/actualbudget/actual/commit/1eb4b5fbe5c8d6aeec49e52d0765e7d8ac132c08) add release note - [`d8056fd`](https://github.com/actualbudget/actual/commit/d8056fde005795046dc11259f2dca20993ab7181) fix lint - [`4ea7720`](https://github.com/actualbudget/actual/commit/4ea772038d374ba66c3be7f83bd960f13d89859b) remove the horizontal scrollbar under the transaction table ### 📊 Changes **3 files changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/FixedSizeList.js` (+1 -1) 📝 `packages/desktop-client/src/style/styles.ts` (+3 -1) ➕ `upcoming-release-notes/1385.md` (+5 -0) </details> ### 📄 Description Resolves #1358 This change will make users can scroll the whole page while the viewport height is lower than `550px`, but cannot when higher. I don't really sure which is the "good" height number to determine should users have ability to scroll the whole page or not. The double scrollbar is helpful to the budget page because the upper component always stand `250px` height. The outer scrollbar make users have ability to scroll down to focus on another part. Otherwise, their screen will always be occupied by the upper component. <img width="776" alt="截圖 2023-07-23 上午2 16 20" src="https://github.com/actualbudget/actual/assets/67775387/2873b7b9-e02f-4e3c-97d6-16427a29cba0"> However, to the transaction table page. This outer scrollbar is meaningless from my perspective, because the upper component is very small, even right now I've limited the height to ensure the outer scrollbar only appear when the viewport height is lower than `550px`, it still meaningless from my persepctive. Maybe I should custom the height limitation for different page or current is good enought? <img width="770" alt="截圖 2023-07-23 上午2 30 03" src="https://github.com/actualbudget/actual/assets/67775387/9accca03-84fe-451f-8ea4-5e017787f4a6"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3704
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?