[PR #6796] [MERGED] Add oxlint rule against direct theme imports; fix Login OpenID button styles #36939

Closed
opened 2026-04-20 23:45:47 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6796
Author: @MatissJanis
Created: 1/27/2026
Status: Merged
Merged: 2/4/2026
Merged by: @MatissJanis

Base: masterHead: matiss/oxlint-no-direct-theme-imports


📝 Commits (2)

  • d78ed07 Add oxlint rule against direct theme imports; fix Login OpenID button styles
  • 8312140 Merge branch 'master' into matiss/oxlint-no-direct-theme-imports

📊 Changes

3 files changed (+15 additions, -8 deletions)

View changed files

📝 .oxlintrc.json (+4 -0)
📝 packages/desktop-client/src/components/manager/subscribe/Login.tsx (+5 -8)
upcoming-release-notes/6796.md (+6 -0)

📄 Description

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 14.46 MB → 14.46 MB (+112 B) +0.00%
loot-core 1 5.84 MB 0%
api 1 4.38 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 14.46 MB → 14.46 MB (+112 B) +0.00%
Changeset
File Δ Size
locale/pt-BR.json 📈 +112 B (+0.07%) 146.35 kB → 146.46 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/pt-BR.js 146.35 kB → 146.46 kB (+112 B) +0.07%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 9.22 MB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.62 kB 0%
static/js/de.js 177.78 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 162.91 kB 0%
static/js/es.js 171.21 kB 0%
static/js/fr.js 179.72 kB 0%
static/js/it.js 171.54 kB 0%
static/js/nb-NO.js 157.23 kB 0%
static/js/nl.js 103.82 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/ru.js 106.97 kB 0%
static/js/sv.js 78.2 kB 0%
static/js/th.js 182.35 kB 0%
static/js/uk.js 215.11 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.11 MB 0%
static/js/narrow.js 641.19 kB 0%
static/js/TransactionList.js 105.97 kB 0%
static/js/wide.js 160.07 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.79 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.84 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.DE5uAdQe.js 5.84 MB 0%

api

Total

Files count Total bundle size % Changed
1 4.38 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
bundle.api.js 4.38 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6796 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/oxlint-no-direct-theme-imports` --- ### 📝 Commits (2) - [`d78ed07`](https://github.com/actualbudget/actual/commit/d78ed07983d5ca5de68c66a873d895ba6de1f0a1) Add oxlint rule against direct theme imports; fix Login OpenID button styles - [`8312140`](https://github.com/actualbudget/actual/commit/8312140909df7edbf6742d9b78786b5b43f25e1c) Merge branch 'master' into matiss/oxlint-no-direct-theme-imports ### 📊 Changes **3 files changed** (+15 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+4 -0) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.tsx` (+5 -8) ➕ `upcoming-release-notes/6796.md` (+6 -0) </details> ### 📄 Description <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 14.46 MB → 14.46 MB (+112 B) | +0.00% loot-core | 1 | 5.84 MB | 0% api | 1 | 4.38 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 14.46 MB → 14.46 MB (+112 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `locale/pt-BR.json` | 📈 +112 B (+0.07%) | 146.35 kB → 146.46 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/pt-BR.js | 146.35 kB → 146.46 kB (+112 B) | +0.07% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.22 MB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.62 kB | 0% static/js/de.js | 177.78 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 162.91 kB | 0% static/js/es.js | 171.21 kB | 0% static/js/fr.js | 179.72 kB | 0% static/js/it.js | 171.54 kB | 0% static/js/nb-NO.js | 157.23 kB | 0% static/js/nl.js | 103.82 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/ru.js | 106.97 kB | 0% static/js/sv.js | 78.2 kB | 0% static/js/th.js | 182.35 kB | 0% static/js/uk.js | 215.11 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.11 MB | 0% static/js/narrow.js | 641.19 kB | 0% static/js/TransactionList.js | 105.97 kB | 0% static/js/wide.js | 160.07 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.79 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.84 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DE5uAdQe.js | 5.84 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.38 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.38 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:45:47 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36939