github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1368] [MERGED] Update to the latest SVGR version & re-generate all icons #3693

New Issue
Closed
opened 2026-02-28 20:45:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:45:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1368
Author: @j-f1
Created: 7/19/2023
Status: ✅ Merged
Merged: 7/19/2023
Merged by: @j-f1

Base: master ← Head: jed/svgr

📝 Commits (8)

  • 9ae6adc Format svgrrc.js
  • cd836cc Update to the latest svgr packages
  • 3bff9d9 Move generate script to package.json
  • ebf2095 Re-generate all icons with the latest version of svgr
  • 80a0619 Add release note
  • 85e8a21 Set icons to inherit their color from their parent
  • 2ec17f8 Remove now-inherited color properties from icons
  • ee4b746 Merge branch 'master' into jed/svgr

📊 Changes

391 files changed (+860 additions, -1415 deletions)

View changed files

📝 packages/desktop-client/package.json (+2 -1)
📝 packages/desktop-client/src/components/AnimatedRefresh.js (+1 -5)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+1 -5)
📝 packages/desktop-client/src/components/NotesButton.tsx (+1 -1)
📝 packages/desktop-client/src/components/SidebarWithData.js (+1 -5)
📝 packages/desktop-client/src/components/Titlebar.js (+2 -6)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.js (+1 -8)
📝 packages/desktop-client/src/components/accounts/Header.js (+6 -29)
📝 packages/desktop-client/src/components/accounts/MobileAccountDetails.js (+3 -10)
📝 packages/desktop-client/src/components/alerts.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/CategorySelect.tsx (+1 -5)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js (+1 -5)
📝 packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx (+1 -3)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+1 -1)
📝 packages/desktop-client/src/components/budget/MonthCountSelector.js (+1 -1)
📝 packages/desktop-client/src/components/common/Button.tsx (+1 -4)
📝 packages/desktop-client/src/components/common/MenuButton.tsx (+1 -1)
📝 packages/desktop-client/src/components/filters/FiltersMenu.js (+1 -7)
📝 packages/desktop-client/src/components/manager/BudgetList.js (+1 -5)
📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsg.js (+1 -1)

...and 80 more files

📄 Description

I re-ran it for #1367 and saw a bunch of changes, so I’m pulling them into a different PR.

This PR also changes the icon color property to inherit, fixing a bunch of minor UI issues (pulled out of #922). For example:
Screenshot_2023-07-19 16 05 33 → Screenshot_2023-07-19 16 05 59

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1368 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/19/2023 **Status:** ✅ Merged **Merged:** 7/19/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/svgr` --- ### 📝 Commits (8) - [`9ae6adc`](https://github.com/actualbudget/actual/commit/9ae6adc3d0d17f13a92d7f3a366e093a6ba6035a) Format svgrrc.js - [`cd836cc`](https://github.com/actualbudget/actual/commit/cd836cc5cf8effba363762df8326c039ba61ddd9) Update to the latest svgr packages - [`3bff9d9`](https://github.com/actualbudget/actual/commit/3bff9d96678a41a953f462518e7ce6bb259cb0b1) Move generate script to package.json - [`ebf2095`](https://github.com/actualbudget/actual/commit/ebf20953953df4aefc02c5efde53a188febd3d3a) Re-generate all icons with the latest version of svgr - [`80a0619`](https://github.com/actualbudget/actual/commit/80a06197798d2533ab329f57dc474f92881c7eab) Add release note - [`85e8a21`](https://github.com/actualbudget/actual/commit/85e8a218609ef5501504241d3673de5e725557be) Set icons to inherit their color from their parent - [`2ec17f8`](https://github.com/actualbudget/actual/commit/2ec17f8b90d155bc5c4832070418159035ca11aa) Remove now-inherited color properties from icons - [`ee4b746`](https://github.com/actualbudget/actual/commit/ee4b7468dff2db8fd4e3c06f221ac423f75317cc) Merge branch 'master' into jed/svgr ### 📊 Changes **391 files changed** (+860 additions, -1415 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+2 -1) 📝 `packages/desktop-client/src/components/AnimatedRefresh.js` (+1 -5) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+1 -5) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+1 -5) 📝 `packages/desktop-client/src/components/Titlebar.js` (+2 -6) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.js` (+1 -8) 📝 `packages/desktop-client/src/components/accounts/Header.js` (+6 -29) 📝 `packages/desktop-client/src/components/accounts/MobileAccountDetails.js` (+3 -10) 📝 `packages/desktop-client/src/components/alerts.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/CategorySelect.tsx` (+1 -5) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js` (+1 -5) 📝 `packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx` (+1 -3) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/MonthCountSelector.js` (+1 -1) 📝 `packages/desktop-client/src/components/common/Button.tsx` (+1 -4) 📝 `packages/desktop-client/src/components/common/MenuButton.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.js` (+1 -7) 📝 `packages/desktop-client/src/components/manager/BudgetList.js` (+1 -5) 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsg.js` (+1 -1) _...and 80 more files_ </details> ### 📄 Description I re-ran it for #1367 and saw a bunch of changes, so I’m pulling them into a different PR. This PR also changes the icon `color` property to `inherit`, fixing a bunch of minor UI issues (pulled out of #922). For example: ![Screenshot_2023-07-19 16 05 33](https://github.com/actualbudget/actual/assets/25517624/138b2d39-6b98-4213-b30f-8ee5cdfaec2a) → ![Screenshot_2023-07-19 16 05 59](https://github.com/actualbudget/actual/assets/25517624/9ce2042b-ba2e-4b3f-9e87-a676820523b4) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3693
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?