github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #6546] [CLOSED] Added financial year date ranges to custom report #36788

New Issue
Closed
opened 2026-04-20 23:37:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 23:37:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6546
Author: @Jon-Salmon
Created: 1/4/2026
Status: ❌ Closed

Base: master ← Head: financial-year-date-range

📝 Commits (6)

  • 4434469 feat: added financial year date ranges to custom report
  • 2cad576 Linting fixes and tests
  • 4503048 Added release notes
  • c946fff [autofix.ci] apply automated fixes
  • 25b8f7e Fixes for report card view and suggestions from AI review
  • 23d1722 All strict typescript checks on FinancialYear.tsx

📊 Changes

16 files changed (+247 additions, -5 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/ReportOptions.ts (+36 -0)
📝 packages/desktop-client/src/components/reports/ReportSidebar.tsx (+3 -0)
📝 packages/desktop-client/src/components/reports/getLiveRange.ts (+21 -0)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+12 -1)
📝 packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx (+2 -0)
📝 packages/desktop-client/src/components/reports/reports/GetCardData.tsx (+18 -1)
📝 packages/desktop-client/src/components/reports/spreadsheets/custom-spreadsheet.ts (+4 -0)
📝 packages/desktop-client/src/components/reports/spreadsheets/grouped-spreadsheet.ts (+3 -0)
📝 packages/desktop-client/src/components/reports/spreadsheets/makeQuery.ts (+7 -2)
📝 packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts (+4 -0)
➕ packages/desktop-client/src/components/settings/FinancialYear.tsx (+33 -0)
📝 packages/desktop-client/src/components/settings/index.tsx (+2 -0)
📝 packages/loot-core/src/shared/months.test.ts (+57 -0)
📝 packages/loot-core/src/shared/months.ts (+37 -0)
📝 packages/loot-core/src/types/prefs.ts (+2 -1)
➕ upcoming-release-notes/6546.md (+6 -0)

📄 Description

Fixes #3222 and #2743

This PR adds a settings option for setting when the users financial year starts and adds date range filters for this financial year and last financial year to the custom report. It does not currently expose these new ranges options to other reports. If unset, the financial year defaults to 1st Jan.

image

Summary by CodeRabbit

  • New Features

    • Financial year start setting added to Settings
    • Reports gain "current" and "last" financial-year ranges and honor configured start date
    • New option to toggle exact-date filtering for precise report ranges

  • Bug Fixes / Behavior

    • Report generation, list cards and live-range calculations now respect the financial year preference

  • Documentation

    • Added release note describing financial-year report support

  • Tests

    • Unit tests added for financial-year date utilities

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6546 **Author:** [@Jon-Salmon](https://github.com/Jon-Salmon) **Created:** 1/4/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `financial-year-date-range` --- ### 📝 Commits (6) - [`4434469`](https://github.com/actualbudget/actual/commit/44344695aa3e230e372f7a4a5baa9b094776d6e8) feat: added financial year date ranges to custom report - [`2cad576`](https://github.com/actualbudget/actual/commit/2cad576f0d2efc5803dfe281740bb1ad4195f21a) Linting fixes and tests - [`4503048`](https://github.com/actualbudget/actual/commit/4503048d9b2eb61616bf00c91579dece0f26d5bf) Added release notes - [`c946fff`](https://github.com/actualbudget/actual/commit/c946fff3de1205e906ab455ec4a8067eb82376de) [autofix.ci] apply automated fixes - [`25b8f7e`](https://github.com/actualbudget/actual/commit/25b8f7eba9045ce3f2f88a41b698d837d0e3cb64) Fixes for report card view and suggestions from AI review - [`23d1722`](https://github.com/actualbudget/actual/commit/23d17220dbf1a93ffd652306027121d123f2ed40) All strict typescript checks on FinancialYear.tsx ### 📊 Changes **16 files changed** (+247 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/ReportOptions.ts` (+36 -0) 📝 `packages/desktop-client/src/components/reports/ReportSidebar.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/reports/getLiveRange.ts` (+21 -0) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+12 -1) 📝 `packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/reports/reports/GetCardData.tsx` (+18 -1) 📝 `packages/desktop-client/src/components/reports/spreadsheets/custom-spreadsheet.ts` (+4 -0) 📝 `packages/desktop-client/src/components/reports/spreadsheets/grouped-spreadsheet.ts` (+3 -0) 📝 `packages/desktop-client/src/components/reports/spreadsheets/makeQuery.ts` (+7 -2) 📝 `packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts` (+4 -0) ➕ `packages/desktop-client/src/components/settings/FinancialYear.tsx` (+33 -0) 📝 `packages/desktop-client/src/components/settings/index.tsx` (+2 -0) 📝 `packages/loot-core/src/shared/months.test.ts` (+57 -0) 📝 `packages/loot-core/src/shared/months.ts` (+37 -0) 📝 `packages/loot-core/src/types/prefs.ts` (+2 -1) ➕ `upcoming-release-notes/6546.md` (+6 -0) </details> ### 📄 Description Fixes #3222 and #2743 This PR adds a settings option for setting when the users financial year starts and adds date range filters for this financial year and last financial year to the custom report. It does not currently expose these new ranges options to other reports. If unset, the financial year defaults to 1st Jan. <img width="997" height="384" alt="image" src="https://github.com/user-attachments/assets/913fbe74-5e89-403a-8a5c-acbee7872ece" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Financial year start setting added to Settings * Reports gain "current" and "last" financial-year ranges and honor configured start date * New option to toggle exact-date filtering for precise report ranges * **Bug Fixes / Behavior** * Report generation, list cards and live-range calculations now respect the financial year preference * **Documentation** * Added release note describing financial-year report support * **Tests** * Unit tests added for financial-year date utilities <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:37:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?