github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6505] [MERGED] Add configuration to use built-in test explorer in VS Code #36768

New Issue
Closed
opened 2026-04-20 23:36:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 23:36:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6505
Author: @jfdoming
Created: 12/28/2025
Status: ✅ Merged
Merged: 12/29/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/vscode-test-config

📝 Commits (4)

  • c0fa3ac Add configuration files to make tests runnable in VS Code
  • 780c6ff Add default configs/fix tests when run from VS Code
  • 2412adf Fix typo
  • 2532de0 Add release notes

📊 Changes

10 files changed (+65 additions, -5 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 .oxlintrc.json (+2 -2)
➕ .vscode/settings.default.json (+7 -0)
📝 packages/crdt/package.json (+1 -1)
➕ packages/crdt/vitest.config.mts (+11 -0)
➕ packages/eslint-plugin-actual/vitest.config.mts (+11 -0)
📝 packages/loot-core/vitest.config.ts (+1 -1)
📝 packages/sync-server/src/app-sync.test.ts (+6 -0)
➕ upcoming-release-notes/6505.md (+6 -0)
➕ vitest.config.ts (+18 -0)

📄 Description

Updates the vitest configuration to allow the VS Code test explorer to load tests from all projects. There's a VS Code settings change required here, so I'm checking in a default file for that as well (it won't do anything without a user manually copying it, though).

Confirmed by manually inspecting the action logs that all tests are still being run.

Branch:
image

Master (example of many issues):
image

Summary by CodeRabbit

  • Chores

    • Adjusted ignore rules to track a default editor settings file and keep other editor files ignored.
    • Added default editor configuration and linter environment tweaks for consistent development.
    • Unified and added per-package test configurations and simplified test scripts.

  • Tests

    • Optimized test runner parameters (workers, isolation, env) and improved test cleanup to remove test artifacts.

  • Documentation

    • Added a release notes entry announcing maintenance/configuration details.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6505 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 12/28/2025 **Status:** ✅ Merged **Merged:** 12/29/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/vscode-test-config` --- ### 📝 Commits (4) - [`c0fa3ac`](https://github.com/actualbudget/actual/commit/c0fa3ac14d62abcab9d48e94dfafb465b85232d0) Add configuration files to make tests runnable in VS Code - [`780c6ff`](https://github.com/actualbudget/actual/commit/780c6ff69dc1326938bdf2887b33314ab22f740b) Add default configs/fix tests when run from VS Code - [`2412adf`](https://github.com/actualbudget/actual/commit/2412adf3b884d46bdd1e7d84c5a1eb93b59051aa) Fix typo - [`2532de0`](https://github.com/actualbudget/actual/commit/2532de0193a06c3444fae5fdcbb767e6dd010e42) Add release notes ### 📊 Changes **10 files changed** (+65 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `.oxlintrc.json` (+2 -2) ➕ `.vscode/settings.default.json` (+7 -0) 📝 `packages/crdt/package.json` (+1 -1) ➕ `packages/crdt/vitest.config.mts` (+11 -0) ➕ `packages/eslint-plugin-actual/vitest.config.mts` (+11 -0) 📝 `packages/loot-core/vitest.config.ts` (+1 -1) 📝 `packages/sync-server/src/app-sync.test.ts` (+6 -0) ➕ `upcoming-release-notes/6505.md` (+6 -0) ➕ `vitest.config.ts` (+18 -0) </details> ### 📄 Description Updates the vitest configuration to allow the VS Code test explorer to load tests from all projects. There's a VS Code settings change required here, so I'm checking in a default file for that as well (it won't do anything without a user manually copying it, though). Confirmed by manually inspecting the action logs that all tests are still being run. Branch: <img width="520" height="393" alt="image" src="https://github.com/user-attachments/assets/7206ebbe-c54a-4d7a-a762-4b1d4b92951b" /> Master (example of many issues): <img width="466" height="139" alt="image" src="https://github.com/user-attachments/assets/9fb0a10b-3833-4dcf-beeb-433d5a39adf8" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Adjusted ignore rules to track a default editor settings file and keep other editor files ignored. * Added default editor configuration and linter environment tweaks for consistent development. * Unified and added per-package test configurations and simplified test scripts. * **Tests** * Optimized test runner parameters (workers, isolation, env) and improved test cleanup to remove test artifacts. * **Documentation** * Added a release notes entry announcing maintenance/configuration details. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:36:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36768
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?