github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6299] [MERGED] Fix lint violations (vol.1) #36630

New Issue
Closed
opened 2026-04-20 23:28:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 23:28:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6299
Author: @MatissJanis
Created: 12/4/2025
Status: ✅ Merged
Merged: 12/4/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-unused-vars-linting

📝 Commits (2)

  • f56695b Fix lint violations
  • 4dcf582 Merge branch 'master' into matiss/fix-unused-vars-linting

📊 Changes

58 files changed (+124 additions, -151 deletions)

View changed files

📝 .oxlintrc.json (+0 -3)
📝 package.json (+1 -1)
📝 packages/api/index.ts (+1 -1)
📝 packages/crdt/src/crdt/timestamp.ts (+1 -1)
📝 packages/desktop-client/src/components/formula/QueryManager.tsx (+2 -2)
📝 packages/desktop-client/src/components/mobile/budget/BudgetCell.tsx (+0 -3)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx (+16 -16)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/utils.ts (+7 -7)
📝 packages/desktop-client/src/components/modals/TransferOwnership.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/UnmigrateBudgetAutomationsModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/SaveReport.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/Format.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/Reset.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/Themes.tsx (+1 -1)
📝 packages/desktop-client/src/hooks/useIsInViewport.ts (+1 -1)
📝 packages/desktop-client/src/hooks/useTagCSS.ts (+1 -1)
📝 packages/desktop-electron/index.ts (+1 -1)
➖ packages/desktop-electron/modules.ts (+0 -3)
📝 packages/desktop-electron/window-state.ts (+1 -1)
📝 packages/docs/docs-sidebar.js (+0 -11)

...and 38 more files

📄 Description

Summary

This PR cleans up unused variables and code across the codebase, enabling stricter linting rules in oxlint.

Changes

Linting Configuration

  • Enable no-unused-vars, no-useless-catch, and import/namespace rules in oxlint (previously disabled)

Code Cleanup

  • Unused catch parameters: Remove unused exception variables (catch (e) → catch)
  • Unused destructured variables: Prefix with underscore convention (e.g., _inflow, _sort_order)
  • Unused imports: Remove ReactNode, CSSProperties, React namespace imports
  • Unused types: Comment out DbPendingTransaction and DbNextDate type definitions
  • Unused file: Delete packages/desktop-electron/modules.ts

Bug Fix

  • Fix locale.ts to avoid ESLint namespace import warnings by spreading date-fns/locale into a plain object

Files Changed

  • 52 files modified across multiple packages
  • 1 file deleted (modules.ts)

Testing

  • All changes are code style/linting improvements with no functional changes
  • Existing tests should continue to pass

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6299 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-unused-vars-linting` --- ### 📝 Commits (2) - [`f56695b`](https://github.com/actualbudget/actual/commit/f56695b08d4bbcf578f1aac3c73e0695b077c458) Fix lint violations - [`4dcf582`](https://github.com/actualbudget/actual/commit/4dcf582121299b3d21214d2243a44a8356a52e50) Merge branch 'master' into matiss/fix-unused-vars-linting ### 📊 Changes **58 files changed** (+124 additions, -151 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+0 -3) 📝 `package.json` (+1 -1) 📝 `packages/api/index.ts` (+1 -1) 📝 `packages/crdt/src/crdt/timestamp.ts` (+1 -1) 📝 `packages/desktop-client/src/components/formula/QueryManager.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/mobile/budget/BudgetCell.tsx` (+0 -3) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` (+16 -16) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/utils.ts` (+7 -7) 📝 `packages/desktop-client/src/components/modals/TransferOwnership.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/UnmigrateBudgetAutomationsModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/SaveReport.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/Format.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/Reset.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/Themes.tsx` (+1 -1) 📝 `packages/desktop-client/src/hooks/useIsInViewport.ts` (+1 -1) 📝 `packages/desktop-client/src/hooks/useTagCSS.ts` (+1 -1) 📝 `packages/desktop-electron/index.ts` (+1 -1) ➖ `packages/desktop-electron/modules.ts` (+0 -3) 📝 `packages/desktop-electron/window-state.ts` (+1 -1) 📝 `packages/docs/docs-sidebar.js` (+0 -11) _...and 38 more files_ </details> ### 📄 Description ## Summary This PR cleans up unused variables and code across the codebase, enabling stricter linting rules in oxlint. ## Changes ### Linting Configuration - Enable `no-unused-vars`, `no-useless-catch`, and `import/namespace` rules in oxlint (previously disabled) ### Code Cleanup - **Unused catch parameters**: Remove unused exception variables (`catch (e)` → `catch`) - **Unused destructured variables**: Prefix with underscore convention (e.g., `_inflow`, `_sort_order`) - **Unused imports**: Remove `ReactNode`, `CSSProperties`, `React` namespace imports - **Unused types**: Comment out `DbPendingTransaction` and `DbNextDate` type definitions - **Unused file**: Delete `packages/desktop-electron/modules.ts` ### Bug Fix - Fix `locale.ts` to avoid ESLint namespace import warnings by spreading `date-fns/locale` into a plain object ## Files Changed - 52 files modified across multiple packages - 1 file deleted (`modules.ts`) ## Testing - All changes are code style/linting improvements with no functional changes - Existing tests should continue to pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:28:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36630
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?