[PR #1305] [MERGED] 🐛 changing pages while adding a transaction #3657

Closed
opened 2026-02-28 20:44:50 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1305
Author: @MatissJanis
Created: 7/7/2023
Status: Merged
Merged: 7/7/2023
Merged by: @MatissJanis

Base: masterHead: matiss/close-add-transaction


📝 Commits (2)

  • 4dbd572 🐛 changing pages while adding a transaction
  • 5e523f9 Release notes

📊 Changes

2 files changed (+11 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.js (+5 -0)
upcoming-release-notes/1305.md (+6 -0)

📄 Description

Reported on Discord:

Hello,

I found a bug when entering multiple transactions and  jumping from one account to another. Here are the repro steps

Step 1. Select Account 1 on the For budget list on the left pane.
Step 2. Click +Add new 
Step 3. Enter your transaction and click Add
Step 4. Change to Account 2
Step 5. Enter your second transaction and click Add

The second transaction is going to be registered under Account 1. 

Note that after adding the first transaction, the new transaction line remains, as shown on the screenshot.

Also, if you then add a third transaction on Account 3, it's going to be registered under Account 2, so it seems that internally, the value of which account to register the transaction under is updated only after the transaction is saved. 

This can unexpectedly lead to duplicate transactions on different accounts, as it looks like transaction 2 is not registered under Account 2, but if you enter it again in Account 2 it will be created properly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1305 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 7/7/2023 **Status:** ✅ Merged **Merged:** 7/7/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/close-add-transaction` --- ### 📝 Commits (2) - [`4dbd572`](https://github.com/actualbudget/actual/commit/4dbd57268eada979aee3b2fbab4ad2151a87580c) :bug: changing pages while adding a transaction - [`5e523f9`](https://github.com/actualbudget/actual/commit/5e523f996eb7d9c272ec1f80606e231dea417174) Release notes ### 📊 Changes **2 files changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.js` (+5 -0) ➕ `upcoming-release-notes/1305.md` (+6 -0) </details> ### 📄 Description Reported on Discord: ``` Hello, I found a bug when entering multiple transactions and jumping from one account to another. Here are the repro steps Step 1. Select Account 1 on the For budget list on the left pane. Step 2. Click +Add new Step 3. Enter your transaction and click Add Step 4. Change to Account 2 Step 5. Enter your second transaction and click Add The second transaction is going to be registered under Account 1. Note that after adding the first transaction, the new transaction line remains, as shown on the screenshot. Also, if you then add a third transaction on Account 3, it's going to be registered under Account 2, so it seems that internally, the value of which account to register the transaction under is updated only after the transaction is saved. This can unexpectedly lead to duplicate transactions on different accounts, as it looks like transaction 2 is not registered under Account 2, but if you enter it again in Account 2 it will be created properly. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:44:50 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3657