github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6022] [MERGED] [Maintenance] Update types for budget table components #36469

New Issue
Closed
opened 2026-04-20 23:19:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 23:19:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6022
Author: @joel-jeremy
Created: 10/28/2025
Status: ✅ Merged
Merged: 11/18/2025
Merged by: @joel-jeremy

Base: master ← Head: ts-budget-table-components

📝 Commits (2)

  • 443bb23 [Maintenance] Update types for budget table components + new hooks to reduce prop drilling
  • a8c2635 Require BudgetCategories props

📊 Changes

16 files changed (+437 additions, -439 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/BudgetCategories.tsx (+9 -39)
📝 packages/desktop-client/src/components/budget/BudgetSummaries.tsx (+5 -7)
📝 packages/desktop-client/src/components/budget/BudgetTable.tsx (+5 -20)
📝 packages/desktop-client/src/components/budget/BudgetTotals.tsx (+8 -4)
📝 packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx (+9 -9)
📝 packages/desktop-client/src/components/budget/ExpenseCategory.tsx (+20 -14)
📝 packages/desktop-client/src/components/budget/ExpenseGroup.tsx (+7 -3)
📝 packages/desktop-client/src/components/budget/IncomeCategory.tsx (+21 -15)
📝 packages/desktop-client/src/components/budget/IncomeGroup.tsx (+7 -4)
📝 packages/desktop-client/src/components/budget/IncomeHeader.tsx (+8 -10)
📝 packages/desktop-client/src/components/budget/RenderMonths.tsx (+16 -33)
📝 packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx (+5 -26)
📝 packages/desktop-client/src/components/budget/index.tsx (+80 -238)
📝 packages/desktop-client/src/components/budget/tracking/TrackingBudgetComponents.tsx (+3 -17)
➕ packages/desktop-client/src/hooks/useCategoryActions.ts (+228 -0)
➕ upcoming-release-notes/6022.md (+6 -0)

📄 Description

Created a shared type (BudgetComponents) to replace EnvelopeBudgetComponents and TrackingBudgetComponents + added new hooks:

  • useBudgetComponents - to replace dataComponents prop in budget table components
  • useCategoryActions - planning to reuse this on the experimental v2 budget table

Updated RenderMonths to have a children prop instead of a component prop

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6022 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 11/18/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `ts-budget-table-components` --- ### 📝 Commits (2) - [`443bb23`](https://github.com/actualbudget/actual/commit/443bb231b4e5aa68926ccec0d084fc1af7a15de5) [Maintenance] Update types for budget table components + new hooks to reduce prop drilling - [`a8c2635`](https://github.com/actualbudget/actual/commit/a8c26355da3e7ca8a6240069719633c4246d5160) Require BudgetCategories props ### 📊 Changes **16 files changed** (+437 additions, -439 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/BudgetCategories.tsx` (+9 -39) 📝 `packages/desktop-client/src/components/budget/BudgetSummaries.tsx` (+5 -7) 📝 `packages/desktop-client/src/components/budget/BudgetTable.tsx` (+5 -20) 📝 `packages/desktop-client/src/components/budget/BudgetTotals.tsx` (+8 -4) 📝 `packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx` (+9 -9) 📝 `packages/desktop-client/src/components/budget/ExpenseCategory.tsx` (+20 -14) 📝 `packages/desktop-client/src/components/budget/ExpenseGroup.tsx` (+7 -3) 📝 `packages/desktop-client/src/components/budget/IncomeCategory.tsx` (+21 -15) 📝 `packages/desktop-client/src/components/budget/IncomeGroup.tsx` (+7 -4) 📝 `packages/desktop-client/src/components/budget/IncomeHeader.tsx` (+8 -10) 📝 `packages/desktop-client/src/components/budget/RenderMonths.tsx` (+16 -33) 📝 `packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx` (+5 -26) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+80 -238) 📝 `packages/desktop-client/src/components/budget/tracking/TrackingBudgetComponents.tsx` (+3 -17) ➕ `packages/desktop-client/src/hooks/useCategoryActions.ts` (+228 -0) ➕ `upcoming-release-notes/6022.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Created a shared type (`BudgetComponents`) to replace `EnvelopeBudgetComponents` and `TrackingBudgetComponents` + added new hooks: - `useBudgetComponents` - to replace `dataComponents` prop in budget table components - `useCategoryActions` - planning to reuse this on the experimental v2 budget table Updated `RenderMonths` to have a `children` prop instead of a `component` prop --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:19:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?