github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5952] [MERGED] Change "/update-vrt" workflow #36424

New Issue
Closed
opened 2026-04-20 23:17:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 23:17:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5952
Author: @MatissJanis
Created: 10/17/2025
Status: ✅ Merged
Merged: 10/18/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-vrt-git-ownership

📝 Commits (4)

  • 0b20b31 Fix git dubious ownership error in VRT workflow
  • 81c9dc3 Add release notes for PR #5952
  • da9c261 Fix shell injection vulnerability in git push
  • e809fa2 Merge branch 'master' into matiss/fix-vrt-git-ownership

📊 Changes

4 files changed (+268 additions, -119 deletions)

View changed files

➖ .github/workflows/update-vrt.yml (+0 -119)
➕ .github/workflows/vrt-update-apply.yml (+156 -0)
➕ .github/workflows/vrt-update-generate.yml (+105 -0)
➕ upcoming-release-notes/5952.md (+7 -0)

📄 Description

The current "/update-vrt" workflow has a vulnerability. Changing it to run in two steps.

  1. on every PR: generate new screenshots and upload them as artefacts (insecure context) - assuming the screenshots have any changes
  2. if a new screenshot artefact upload is received - extract it, analyze it and apply to the relevant PR as a new commit (within safe context)

From a usability perspective: we will no longer need to do "/update-vrt" comments. If there are VRT changes - they will be automatically updated in the PR and visible in the diff.

Here is an example how it will look like: https://github.com/MatissJanis/actual/pull/9

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5952 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/17/2025 **Status:** ✅ Merged **Merged:** 10/18/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-vrt-git-ownership` --- ### 📝 Commits (4) - [`0b20b31`](https://github.com/actualbudget/actual/commit/0b20b316ddd30f9d17178ff25855d129b9e0788f) Fix git dubious ownership error in VRT workflow - [`81c9dc3`](https://github.com/actualbudget/actual/commit/81c9dc3e7e83a1c021b43309b5040d36367b4ca2) Add release notes for PR #5952 - [`da9c261`](https://github.com/actualbudget/actual/commit/da9c261aada07326bdb9ab4f7e999a8d17b449d2) Fix shell injection vulnerability in git push - [`e809fa2`](https://github.com/actualbudget/actual/commit/e809fa22a2440594b9566d3a9574194760499a51) Merge branch 'master' into matiss/fix-vrt-git-ownership ### 📊 Changes **4 files changed** (+268 additions, -119 deletions) <details> <summary>View changed files</summary> ➖ `.github/workflows/update-vrt.yml` (+0 -119) ➕ `.github/workflows/vrt-update-apply.yml` (+156 -0) ➕ `.github/workflows/vrt-update-generate.yml` (+105 -0) ➕ `upcoming-release-notes/5952.md` (+7 -0) </details> ### 📄 Description The current "/update-vrt" workflow has a vulnerability. Changing it to run in two steps. 1. on every PR: generate new screenshots and upload them as artefacts (insecure context) - assuming the screenshots have any changes 2. if a new screenshot artefact upload is received - extract it, analyze it and apply to the relevant PR as a new commit (within safe context) From a usability perspective: we will no longer need to do "/update-vrt" comments. If there are VRT changes - they will be automatically updated in the PR and visible in the diff. Here is an example how it will look like: https://github.com/MatissJanis/actual/pull/9 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:17:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36424
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?