github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5943] [MERGED] Improve file decryption modal and button labels #36420

New Issue
Closed
opened 2026-04-20 23:17:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 23:17:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5943
Author: @MatissJanis
Created: 10/16/2025
Status: ✅ Merged
Merged: 10/17/2025
Merged by: @MatissJanis

Base: master ← Head: cursor/improve-file-decryption-modal-and-button-labels-5112

📝 Commits (7)

  • ebb192b Checkpoint before follow-up message
  • cf4a995 [autofix.ci] apply automated fixes
  • a628b6e Fix translation keys in FixEncryptionKeyModal
  • 5345cd1 Update encryption key prompt message
  • ee792d0 [autofix.ci] apply automated fixes
  • 83652ea Add release notes for PR #5943
  • 627f7a7 Merge branch 'master' into cursor/improve-file-decryption-modal-and-button-labels-5112

📊 Changes

2 files changed (+12 additions, -5 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/FixEncryptionKeyModal.tsx (+5 -5)
➕ upcoming-release-notes/5943.md (+7 -0)

📄 Description

Improve clarity of budget file decryption modal

This PR enhances the user experience for the budget file decryption modal by making its labels and descriptions more intuitive.

Screenshot 2025-10-16 at 23 45 19

Why:
The previous "Update key" button label and "Unable to decrypt file" modal title were often confusing. The description for the password change scenario was also not fully clear, and the password input field could benefit from more prominence. These changes aim to provide clearer guidance for users, whether they are logging in for the first time or have changed their password.

What:

  • Modal Title: Changed from "Unable to decrypt file" to "Decrypt budget file".
  • Button Label: Changed from "Update key" to "Unlock budget file".
  • Input Field: Replaced the standard Input component with BigInput for the password field.

Open in Cursor Open in Web

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5943 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/16/2025 **Status:** ✅ Merged **Merged:** 10/17/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/improve-file-decryption-modal-and-button-labels-5112` --- ### 📝 Commits (7) - [`ebb192b`](https://github.com/actualbudget/actual/commit/ebb192bf01bafb51cc8e0feb2183517043e27eef) Checkpoint before follow-up message - [`cf4a995`](https://github.com/actualbudget/actual/commit/cf4a995adeda483d1987cc1a9f8f18641e6605c8) [autofix.ci] apply automated fixes - [`a628b6e`](https://github.com/actualbudget/actual/commit/a628b6e592532030fdf9c6ecb616cd0e3c9646f3) Fix translation keys in FixEncryptionKeyModal - [`5345cd1`](https://github.com/actualbudget/actual/commit/5345cd172947dd41c6768cb88fd44b9cb9c8c7fa) Update encryption key prompt message - [`ee792d0`](https://github.com/actualbudget/actual/commit/ee792d037393a1e74d7e9b5d8dbb4f24a35e3196) [autofix.ci] apply automated fixes - [`83652ea`](https://github.com/actualbudget/actual/commit/83652ea6faf50fda7572149eef0168922d4a706b) Add release notes for PR #5943 - [`627f7a7`](https://github.com/actualbudget/actual/commit/627f7a7087eeee997a5abf77ad358e3af6c7b062) Merge branch 'master' into cursor/improve-file-decryption-modal-and-button-labels-5112 ### 📊 Changes **2 files changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/FixEncryptionKeyModal.tsx` (+5 -5) ➕ `upcoming-release-notes/5943.md` (+7 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ### Improve clarity of budget file decryption modal This PR enhances the user experience for the budget file decryption modal by making its labels and descriptions more intuitive. <img width="565" height="332" alt="Screenshot 2025-10-16 at 23 45 19" src="https://github.com/user-attachments/assets/bfde029d-e146-4f1b-8953-fa073a38dba3" /> **Why:** The previous "Update key" button label and "Unable to decrypt file" modal title were often confusing. The description for the password change scenario was also not fully clear, and the password input field could benefit from more prominence. These changes aim to provide clearer guidance for users, whether they are logging in for the first time or have changed their password. **What:** * **Modal Title:** Changed from "Unable to decrypt file" to "Decrypt budget file". * **Button Label:** Changed from "Update key" to "Unlock budget file". * **Input Field:** Replaced the standard `Input` component with `BigInput` for the password field. --- <a href="https://cursor.com/background-agent?bcId=bc-53b26240-2084-46c5-ae86-b8c1a214acac"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-53b26240-2084-46c5-ae86-b8c1a214acac"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:17:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?