github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5857] [MERGED] ⬆️ Upgrade electron-builder #36363

New Issue
Closed
opened 2026-04-20 23:14:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 23:14:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5857
Author: @MikesGlitch
Created: 10/5/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @MikesGlitch

Base: master ← Head: upgrade-electron-builder

📝 Commits (10+)

📊 Changes

10 files changed (+1805 additions, -3040 deletions)

View changed files

📝 .github/workflows/electron-master.yml (+1 -0)
📝 .gitignore (+0 -3)
➖ .secret-tokens.example (+0 -2)
📝 bin/package-electron (+1 -4)
📝 packages/desktop-client/package.json (+1 -1)
📝 packages/desktop-client/src/components/AppBackground.tsx (+0 -1)
📝 packages/desktop-client/src/components/BankSyncStatus.tsx (+0 -1)
📝 packages/desktop-electron/package.json (+1 -4)
➕ upcoming-release-notes/5857.md (+6 -0)
📝 yarn.lock (+1795 -3024)

📄 Description

There's about to be an electron-builder release to handle the new ios icons, which we're going to need. This is just making it easier for us to upgrade and use it.

Note: I had to regenerate the yarn lock to fix an issue where the package was missing a node_module for wrappy.

Tested:

  • Linux
  • Mac
  • Windows
  • Pipeline notarization
    • Decided not to test this - I have high confidence it will work, and to test it I'd need to get all the secrets again from Matiss, put them on my local repo, modify the build scripts to skip the publish and sign on Pull requests etc.
    • Will test it if anyone feels strongly about it, but the env variables should work as documented

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5857 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 10/5/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `upgrade-electron-builder` --- ### 📝 Commits (10+) - [`8524b0d`](https://github.com/actualbudget/actual/commit/8524b0d8030ffb54ec0ee1df86f04dc4dd4e9f1c) upgrade electron-builder - [`d533165`](https://github.com/actualbudget/actual/commit/d533165cb2d207eaf321a977283d2a4b04e3e771) no postinstall when yarn immutable - [`c2b35d3`](https://github.com/actualbudget/actual/commit/c2b35d3ee8fc4c6b5716f68854689edd3d251e61) downgrade to last version without the bug - [`038c020`](https://github.com/actualbudget/actual/commit/038c02057c6fb24ca652f9ae1e495fc15a0b805f) fix issue with wrappy - [`029ba10`](https://github.com/actualbudget/actual/commit/029ba105ec42473a24a486df6d86b9c68fdebad8) merge - [`ee11c1b`](https://github.com/actualbudget/actual/commit/ee11c1bbf99dab912a5152edb3ad1b433d065247) release notes - [`9f4586c`](https://github.com/actualbudget/actual/commit/9f4586c005fd48ecc7c5e4ca3e2dd62569952e49) merge - [`2dbb510`](https://github.com/actualbudget/actual/commit/2dbb5100b496795139bc472ab80ff872ad492a39) regen yarn lock - [`3050965`](https://github.com/actualbudget/actual/commit/305096563b885f45123500c2ee11cc90154b5131) react-sprint - [`10931b6`](https://github.com/actualbudget/actual/commit/10931b63c6218dfe4f85ee2fcad6880919c3715f) hmm ### 📊 Changes **10 files changed** (+1805 additions, -3040 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/electron-master.yml` (+1 -0) 📝 `.gitignore` (+0 -3) ➖ `.secret-tokens.example` (+0 -2) 📝 `bin/package-electron` (+1 -4) 📝 `packages/desktop-client/package.json` (+1 -1) 📝 `packages/desktop-client/src/components/AppBackground.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/BankSyncStatus.tsx` (+0 -1) 📝 `packages/desktop-electron/package.json` (+1 -4) ➕ `upcoming-release-notes/5857.md` (+6 -0) 📝 `yarn.lock` (+1795 -3024) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> There's about to be an electron-builder release to handle the new ios icons, which we're going to need. This is just making it easier for us to upgrade and use it. _Note:_ I had to regenerate the yarn lock to fix an issue where the package was missing a node_module for wrappy. Tested: - [x] Linux - [x] Mac - [x] Windows - [ ] Pipeline notarization - Decided not to test this - I have high confidence it will work, and to test it I'd need to get all the secrets again from Matiss, put them on my local repo, modify the build scripts to skip the publish and sign on Pull requests etc. - Will test it if anyone feels strongly about it, but the env variables should work as documented --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 23:14:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36363
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?