[PR #1268] [MERGED] Fallback to memo in ofx if payee is not found #3635

Closed
opened 2026-02-28 20:44:31 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1268
Author: @Shazib
Created: 7/3/2023
Status: Merged
Merged: 7/4/2023
Merged by: @j-f1

Base: masterHead: ofx-parse-tweaks


📝 Commits (10+)

📊 Changes

2 files changed (+13 additions, -3 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/parse-file.ts (+7 -3)
upcoming-release-notes/1268.md (+6 -0)

📄 Description

Solves #767

In my side quest to replace node-libofx i've come across a number of ofx files that use 'memo' in place of 'name' for the payee information, mostly outside of europe/US.

This implementation falls back to memo if payee is blank (for all transactions)

Maybe we should use a fixed choice per sheet, at the moment it decides per transaction. I thought about adding an option in settings for users to enable 'use memo instead of name' but I think thats not ideal for non technical users. The other option is that we allow the re-mapping of the fields in the GUI at import time?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1268 **Author:** [@Shazib](https://github.com/Shazib) **Created:** 7/3/2023 **Status:** ✅ Merged **Merged:** 7/4/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `ofx-parse-tweaks` --- ### 📝 Commits (10+) - [`363ea17`](https://github.com/actualbudget/actual/commit/363ea17fbf2661888d1a89ecfe3f81affd606864) Fallback to memo in ofx is payee is not found - [`c4dd1e1`](https://github.com/actualbudget/actual/commit/c4dd1e138747b7e81bd4cf851e6ce36edcaae658) fix - [`dffc0a2`](https://github.com/actualbudget/actual/commit/dffc0a278ed89a16fec93e1de4ebcd11b303169d) Merge branch 'master' into ofx-parse-tweaks - [`5ef2e17`](https://github.com/actualbudget/actual/commit/5ef2e17d0ab6f311e0cd5d95e5d40ca96960c6f9) Add Release Notes - [`87c9f07`](https://github.com/actualbudget/actual/commit/87c9f07b5022333865f178aa912f992ab893c5eb) lint - [`24e2124`](https://github.com/actualbudget/actual/commit/24e21247b68b5f694e292e45a020b324be8718eb) Update 1268.md - [`689d7ba`](https://github.com/actualbudget/actual/commit/689d7bac8e913bf85f45137b3cec64cd7cac2ee7) check once for the entire transaction set - [`648bbb5`](https://github.com/actualbudget/actual/commit/648bbb5564f749232a5c99d2c3b06af389d16909) better release notes - [`01cf51c`](https://github.com/actualbudget/actual/commit/01cf51c17bb4e7c2374d9d85309e446a119c70e2) Merge branch 'master' into ofx-parse-tweaks - [`0f90b3c`](https://github.com/actualbudget/actual/commit/0f90b3c3c1de8e5e0a90b94d17e8d44e8a8600b7) nulls ### 📊 Changes **2 files changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/parse-file.ts` (+7 -3) ➕ `upcoming-release-notes/1268.md` (+6 -0) </details> ### 📄 Description Solves #767 In my side quest to replace node-libofx i've come across a number of ofx files that use 'memo' in place of 'name' for the payee information, mostly outside of europe/US. This implementation falls back to memo if payee is blank (for all transactions) ~~Maybe we should use a fixed choice per sheet, at the moment it decides _per_ transaction.~~ I thought about adding an option in settings for users to enable 'use memo instead of name' but I think thats not ideal for non technical users. The other option is that we allow the re-mapping of the fields in the GUI at import time? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:44:31 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3635