[PR #1248] [MERGED] ♻️ moving some components from common.tsx to separate files #3622

Closed
opened 2026-02-28 20:44:21 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1248
Author: @MatissJanis
Created: 7/1/2023
Status: Merged
Merged: 7/2/2023
Merged by: @MatissJanis

Base: masterHead: matiss/moving-common


📝 Commits (1)

  • 2e94888 ♻️ moving some components from common.tsx to separate files

📊 Changes

9 files changed (+269 additions, -217 deletions)

View changed files

📝 packages/desktop-client/src/components/common.tsx (+8 -217)
packages/desktop-client/src/components/common/Block.tsx (+20 -0)
packages/desktop-client/src/components/common/Card.tsx (+41 -0)
packages/desktop-client/src/components/common/HoverTarget.tsx (+54 -0)
packages/desktop-client/src/components/common/InlineField.tsx (+45 -0)
packages/desktop-client/src/components/common/Label.tsx (+31 -0)
packages/desktop-client/src/components/common/Select.tsx (+40 -0)
packages/desktop-client/src/components/common/TextOneLine.tsx (+24 -0)
upcoming-release-notes/1248.md (+6 -0)

📄 Description

This is direct copy & paste with no changes. Just moving things a bit to reduce the size of the massive common.tsx file


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1248 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 7/1/2023 **Status:** ✅ Merged **Merged:** 7/2/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/moving-common` --- ### 📝 Commits (1) - [`2e94888`](https://github.com/actualbudget/actual/commit/2e9488862e0ac45d702d6ecc61abc8b55f354831) :recycle: moving some components from common.tsx to separate files ### 📊 Changes **9 files changed** (+269 additions, -217 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/common.tsx` (+8 -217) ➕ `packages/desktop-client/src/components/common/Block.tsx` (+20 -0) ➕ `packages/desktop-client/src/components/common/Card.tsx` (+41 -0) ➕ `packages/desktop-client/src/components/common/HoverTarget.tsx` (+54 -0) ➕ `packages/desktop-client/src/components/common/InlineField.tsx` (+45 -0) ➕ `packages/desktop-client/src/components/common/Label.tsx` (+31 -0) ➕ `packages/desktop-client/src/components/common/Select.tsx` (+40 -0) ➕ `packages/desktop-client/src/components/common/TextOneLine.tsx` (+24 -0) ➕ `upcoming-release-notes/1248.md` (+6 -0) </details> ### 📄 Description This is direct copy & paste with no changes. Just moving things a bit to reduce the size of the massive common.tsx file --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:44:21 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3622