[PR #5414] [MERGED] Schedules with the same amount and date are now handled properly #36116

New Issue

Closed

opened 2026-04-20 22:59:58 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-20 22:59:58 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5414
Author: @Triscal
Created: 7/28/2025
Status: ✅ Merged
Merged: 9/17/2025
Merged by: @youngcw

Base: master ← Head: schedule-matching-improvements

---

📝 Commits (10+)

• dad5f55 minor typescript updates
• 407672a [autofix.ci] apply automated fixes
• ca89d8c more typescript changes
• f85ec57 Merge branch 'schedule-matching-improvements' of https://github.com/Triscal/actual-josh-dev into schedule-matching-improvements
• 10782c3 [autofix.ci] apply automated fixes
• 597d93d Another typescript
• e8d1a33 Merge branch 'schedule-matching-improvements' of https://github.com/Triscal/actual-josh-dev into schedule-matching-improvements
• 4df4c63 fixes
• 3e246b2 [autofix.ci] apply automated fixes
• e22570a fixed test

📊 Changes

32 files changed (+132 additions, -2 deletions)

View changed files

📝 packages/desktop-client/e2e/schedules.test.ts (+66 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-full-list-of-schedules-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-full-list-of-schedules-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-full-list-of-schedules-3-chromium-linux.png (+0 -0)
➖ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.png (+0 -0)
➖ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png (+0 -0)
➖ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-10-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-11-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-12-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-13-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-14-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-15-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-16-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-17-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-18-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-19-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-20-chromium-linux.png (+0 -0)

...and 12 more files

📄 Description

Reproduction steps for bug:

1. Create two schedules each on the same day, with the same payee and the same amount within the same account.
2. Try to post both transactions/schedules.

Alternative reproduction steps:

1. Create two schedules each on the same day, with the same payee and the same amount within the same account.
2. Add a rule to each schedule that adds a different note.
3. View the pending transactions in the account list.

On this branch you will not be able to reproduce the bug.

Partially handles: https://github.com/actualbudget/actual/issues/5296

Essentially the issue ended up being that all rules were run on both transactions, this would mean that because the account, payee, date, and amount are the same. Then both transactions were believed to be the same one.

We set a schedule ID on those transactions, so I pulled in that schedule and then rule associated with it and only ran that rule. If there is no schedule associated, the old behaviour is retained.

I also added a test to prevent regressions.

This does leave some questions:

• Should a transaction created by a schedule only have that schedules rule run on it?
• Should a rule that is linked to a schedule only run on transactions linked to that schedule?

The answer to the first question is:

• Any rules associated with other schedules will not be run.
• Rules that are not associated with any schedules will be run.

The answer to the other question is not determined / impacted by this code. I think this is the right choice right now, if a user manually enters a transaction we do not currently have a way to tell which rule / schedule they want to apply to it. We could add some UI in the future to allow a user to choose, but that's out of scope right now.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5414 **Author:** [@Triscal](https://github.com/Triscal) **Created:** 7/28/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `schedule-matching-improvements` --- ### 📝 Commits (10+) - [`dad5f55`](https://github.com/actualbudget/actual/commit/dad5f5575207c315fd778e7aa3e7674bbbfed0aa) minor typescript updates - [`407672a`](https://github.com/actualbudget/actual/commit/407672ad408cbf33ecf34a5f354d9172fa2d20a3) [autofix.ci] apply automated fixes - [`ca89d8c`](https://github.com/actualbudget/actual/commit/ca89d8c229175b792b97cf3d52b625348fa4b2c5) more typescript changes - [`f85ec57`](https://github.com/actualbudget/actual/commit/f85ec5773a3820b9eda395d941478a4c8cd055f7) Merge branch 'schedule-matching-improvements' of https://github.com/Triscal/actual-josh-dev into schedule-matching-improvements - [`10782c3`](https://github.com/actualbudget/actual/commit/10782c3f26ddd911e201f910ce0d380f21169dd7) [autofix.ci] apply automated fixes - [`597d93d`](https://github.com/actualbudget/actual/commit/597d93d1824d06f93c79a6e6c9a8663cbc31b4c1) Another typescript - [`e8d1a33`](https://github.com/actualbudget/actual/commit/e8d1a3382f03af6abd5cd7b9cceaaf22468ca2fd) Merge branch 'schedule-matching-improvements' of https://github.com/Triscal/actual-josh-dev into schedule-matching-improvements - [`4df4c63`](https://github.com/actualbudget/actual/commit/4df4c63848da8352ea04b359d45613162c4c5750) fixes - [`3e246b2`](https://github.com/actualbudget/actual/commit/3e246b21de84bdb276efb7aacfc207af01468025) [autofix.ci] apply automated fixes - [`e22570a`](https://github.com/actualbudget/actual/commit/e22570ad0b8a0961e7ed426e05e7e8d5d71ef8e3) fixed test ### 📊 Changes **32 files changed** (+132 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/schedules.test.ts` (+66 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-full-list-of-schedules-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-full-list-of-schedules-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-full-list-of-schedules-3-chromium-linux.png` (+0 -0) ➖ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.png` (+0 -0) ➖ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png` (+0 -0) ➖ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-10-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-11-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-12-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-13-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-14-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-15-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-16-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-17-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-18-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-19-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-two-new-schedules-posts-both-transactions-and-later-completes-one-20-chromium-linux.png` (+0 -0) _...and 12 more files_ </details> ### 📄 Description Reproduction steps for [bug](https://github.com/actualbudget/actual/issues/5296): 1. Create two schedules each on the same day, with the same payee and the same amount within the same account. 3. Try to post both transactions/schedules. Alternative reproduction steps: 1. Create two schedules each on the same day, with the same payee and the same amount within the same account. 2. Add a rule to each schedule that adds a different note. 3. View the pending transactions in the account list. On this branch you will not be able to reproduce the bug. <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Partially handles: https://github.com/actualbudget/actual/issues/5296 Essentially the issue ended up being that all rules were run on both transactions, this would mean that because the account, payee, date, and amount are the same. Then both transactions were believed to be the same one. We set a schedule ID on those transactions, so I pulled in that schedule and then rule associated with it and only ran that rule. If there is no schedule associated, the old behaviour is retained. I also added a test to prevent regressions. This does leave some questions: - Should a transaction created by a schedule only have that schedules rule run on it? - Should a rule that is linked to a schedule only run on transactions linked to that schedule? The answer to the first question is: - Any rules associated with other schedules will **not** be run. - Rules that are not associated with any schedules **will** be run. The answer to the other question is not determined / impacted by this code. I think this is the right choice right now, if a user manually enters a transaction we do not currently have a way to tell which rule / schedule they want to apply to it. We could add some UI in the future to allow a user to choose, but that's out of scope right now. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-20 22:59:58 -05:00

GiteaMirror closed this issue 2026-04-20 23:00:00 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

dependabot/npm_and_yarn/npm_and_yarn-cd62b4b37a

api-browser-custom-data-dir

tabedzki/feat/replacing-month-picker-with-day-picker

delay-initial-sync-until-loaded

jfdoming/mobile-app-build

cross-version-sync-compat

jfdoming/api-tokens-part-1

jfdoming/api-tokens-part-2

jfdoming/api-tokens-part-3

jfdoming/mobile-app-updates

claude/budget-version-migration-compat-151jlr

claude/worker-error-serialization-9iqtl7

claude/react-table-library-research-afx83z

claude/issue-8401-regression-test-9nw9l3

jfdoming/mobile-app-foundation-part-1

jfdoming/mobile-app-scaffold

release

ai-fix-cleanup-def-8290

claude/relaxed-shannon-jusywa

claude/fervent-keller-s6f2fq

claude/determined-feynman-st1y9z

claude/wizardly-einstein-vi2wce

claude/sweet-albattani-7nseio

feat/bank-sync-per-budget-file

claude/affectionate-cannon-y0kc82

claude/dependabot-findings-m9pgmb

claude/mac-app-ios-publish-zjs1lz

claude/vigilant-tesla-aiiyos

depot-migrate-secrets-1781296330308

claude/quirky-cerf-v5qck7

claude/animation-removal-alternative-2etfh1

claude/netlify-preview-comments-consolidate-9XPYa

osc/7391-error-boundaries-reports

claude/pensive-dijkstra-7DYui

claude/server-app-version-mismatch-HTCGv

claude/pr-8027-review-feedback-mELuO

claude/zealous-wozniak-e5pO0

claude/intelligent-heisenberg-BSHJq

claude/translation-download-refactor-jFRsO

claude/mobile-performance-ideas-G9PAO

claude/github-issue-7988-5A5ly

blacksmith-migration-ff70d2d

claude/great-mayer-KRvOk

claude/react-native-ios-compilation-fcJh5

claude/serene-goldberg-58xv0

claude/kind-euler-LVG3K

release-automation/edge-nightly

7710-bundle-migrations

claude/fix-docker-build-error-WMfed

claude/llm-compatible-release-notes-t20Nr

7710-tests-tdd

cursor/transaction-table-rewrite-f077

claude/plan-ci-secure-context-OtEe1

claude/fix-issue-7667-DPXi3

cursor/resolve-pr-7449-ee11

claude/fix-typescript-build-error-JPtZ5

copilot/add-repository-configs-to-packages

worktree-compressed-drifting-ritchie

claude/api-consumer-verification-kfz1K

pr-7454

claude/fix-issue-7410-LLLQ4

revert-7281-generate-icons

react-query-useSchedules

copilot/sub-pr-6140

package-upgrades

v26.7.0

v26.6.0

v26.5.2

v26.5.1

v26.5.0

v26.4.0

v26.3.0

v26.2.1

v26.2.0

v26.1.0

v25.12.0

v25.11.0

v25.10.0

v25.9.0

v25.8.0

v25.7.1

v25.7.0

v25.6.1

v25.6.0

v25.5.0

v25.4.0

v25.3.1

v25.3.0

v25.2.1

v25.2.0

v25.1.0

v24.12.0

v24.11.0

v24.10.1

v24.10.0

v24.9.0

v24.8.0

v24.7.0

v24.6.0

v24.5.0

v24.4.0

v24.3.0

v24.2.0

v24.1.0

v23.12.0

v23.11.0

v23.10.0

v23.9.0

v23.8.1

v23.8.0

v23.7.2

v23.7.1

v23.7.0

v23.6.0

v23.5.0

v23.4.2

v23.4.1

v23.4.0

v23.3.2

v23.3.0

v23.2.9

v23.2.5

v23.1.12

v22.12.9

Labels

Clear labels

AI generated

API

bank sync

budgeting

bug

can’t replicate

dependencies

docker

documentation

electron

experimental feature

feature

feedback

goal templates

good first issue

help wanted

importers

maintenance

needs info

needs testing

needs triage

needs votes

openid

payees

pull-request

Mirrored from GitHub Pull Request

regression

reports

responsive

rules

schedules

server

✨ merged

split transactions

tech debt

tech-support

theme

transaction import

transaction reconciliation

transactions

translations

upstream

user interface

✅ approved

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/actual#36116