github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 09:38:37 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #5398] [MERGED] Use null as tag color by default (fallback to theme color) and stricter tag validation #36110

New Issue
Closed
opened 2026-04-20 22:59:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 22:59:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5398
Author: @pogman-code
Created: 7/26/2025
Status: ✅ Merged
Merged: 8/4/2025
Merged by: @youngcw

Base: master ← Head: master

📝 Commits (4)

  • 04081d4 Use null as tag color by default (fallback to theme color) and stricter tag validation
  • 6c0972b Set ColorPicker's defaultValue props
  • e2177fe Set default tag color in first position
  • 84f591c Make ColorSwatchPicker configurable

📊 Changes

4 files changed (+118 additions, -58 deletions)

View changed files

📝 packages/component-library/src/ColorPicker.tsx (+94 -50)
📝 packages/desktop-client/src/components/tags/TagCreationRow.tsx (+14 -7)
📝 packages/desktop-client/src/style/tags.ts (+4 -1)
➕ upcoming-release-notes/5398.md (+6 -0)

📄 Description

As noted by @youngcw in the following comment: https://github.com/actualbudget/actual/pull/5387#issuecomment-3119812921

Tags used theme.noteTagDefault as default value, while not being impactful, it is not very elegant and has the same result as saving null to DB, since it would fallback the theme color anyway.

In addition, I changed isTagValid to check that the color string is valid too.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5398 **Author:** [@pogman-code](https://github.com/pogman-code) **Created:** 7/26/2025 **Status:** ✅ Merged **Merged:** 8/4/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`04081d4`](https://github.com/actualbudget/actual/commit/04081d40095e614679ea3b0287955dba6b89f76b) Use null as tag color by default (fallback to theme color) and stricter tag validation - [`6c0972b`](https://github.com/actualbudget/actual/commit/6c0972b476e808f63639c8342766772339f48428) Set ColorPicker's defaultValue props - [`e2177fe`](https://github.com/actualbudget/actual/commit/e2177fed1f3ad8653aaed968d28266009f729627) Set default tag color in first position - [`84f591c`](https://github.com/actualbudget/actual/commit/84f591c1a5194ae5801dbe237b1a8a053a130952) Make ColorSwatchPicker configurable ### 📊 Changes **4 files changed** (+118 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/src/ColorPicker.tsx` (+94 -50) 📝 `packages/desktop-client/src/components/tags/TagCreationRow.tsx` (+14 -7) 📝 `packages/desktop-client/src/style/tags.ts` (+4 -1) ➕ `upcoming-release-notes/5398.md` (+6 -0) </details> ### 📄 Description As noted by @youngcw in the following comment: https://github.com/actualbudget/actual/pull/5387#issuecomment-3119812921 Tags used `theme.noteTagDefault` as default value, while not being impactful, it is not very elegant and has the same result as saving `null` to DB, since it would fallback the theme color anyway. In addition, I changed `isTagValid` to check that the `color` string is valid too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:59:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#36110
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?