github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1223] [MERGED] Lint tweaks #3605

New Issue
Closed
opened 2026-02-28 20:44:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:44:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1223
Author: @Shazib
Created: 6/28/2023
Status: ✅ Merged
Merged: 6/30/2023
Merged by: @j-f1

Base: master ← Head: lint-tweaks

📝 Commits (7)

  • 70fb2c3 yarn.lock
  • 95f570e Revert "yarn.lock"
  • be45e9a Update linting
  • e1dc5ba Release notes
  • f51e95f Merge branch 'actualbudget:master' into lint-tweaks
  • 0d6b60d Merge branch 'master' into lint-tweaks
  • c9cbd5c Merge branch 'master' into lint-tweaks

📊 Changes

6 files changed (+14 additions, -12 deletions)

View changed files

📝 .eslintignore (+1 -0)
📝 .eslintrc.js (+0 -11)
📝 package.json (+2 -0)
📝 packages/loot-core/src/server/main.ts (+3 -0)
➕ upcoming-release-notes/1223.md (+6 -0)
📝 yarn.lock (+2 -1)

📄 Description

I didnt manage to repro the issue discussed in discord but I have made these tweaks, would love some feedback

  • The override to only look at src for loot-core is no longer relevant as we only do a single lint.
  • Not linting the icons saves a bit of time.
  • Added an option for 'verbose' linting, which is helpful becuase it logs time at the end.
  • I don't know if the eslint-plugin-import dep needs to be in package.json or not, but i've added it.
  • Re-enabled linting main.ts with relevant disable flags.

I have a suspicion that maybe the import rule sometimes messes up because all of the platform specific files are excluded from the checks (**/*.{testing,electron,browser,web,api}.ts), in this case it may be best to switch this rule off for now if other people keep seeing issues.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1223 **Author:** [@Shazib](https://github.com/Shazib) **Created:** 6/28/2023 **Status:** ✅ Merged **Merged:** 6/30/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `lint-tweaks` --- ### 📝 Commits (7) - [`70fb2c3`](https://github.com/actualbudget/actual/commit/70fb2c3261931903d54f6800a44ad47741215d63) yarn.lock - [`95f570e`](https://github.com/actualbudget/actual/commit/95f570e00950111f2bec9c45e98a6fc8cd59c8d6) Revert "yarn.lock" - [`be45e9a`](https://github.com/actualbudget/actual/commit/be45e9ab673e64ddd4f8bd7864019b939b255955) Update linting - [`e1dc5ba`](https://github.com/actualbudget/actual/commit/e1dc5ba81fb5e167aabb401f0442baceddd32c57) Release notes - [`f51e95f`](https://github.com/actualbudget/actual/commit/f51e95f9e468785f58f931940fc4874cc5990ebf) Merge branch 'actualbudget:master' into lint-tweaks - [`0d6b60d`](https://github.com/actualbudget/actual/commit/0d6b60d91d4fff7c5332a885da43c2e17b6374bc) Merge branch 'master' into lint-tweaks - [`c9cbd5c`](https://github.com/actualbudget/actual/commit/c9cbd5c2b158eaf30918b1ec09274b133d2d422f) Merge branch 'master' into lint-tweaks ### 📊 Changes **6 files changed** (+14 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `.eslintignore` (+1 -0) 📝 `.eslintrc.js` (+0 -11) 📝 `package.json` (+2 -0) 📝 `packages/loot-core/src/server/main.ts` (+3 -0) ➕ `upcoming-release-notes/1223.md` (+6 -0) 📝 `yarn.lock` (+2 -1) </details> ### 📄 Description I didnt manage to repro the issue discussed in discord but I have made these tweaks, would love some feedback - The override to only look at `src` for `loot-core` is no longer relevant as we only do a single lint. - Not linting the icons saves a bit of time. - Added an option for 'verbose' linting, which is helpful becuase it logs time at the end. - I don't know if the `eslint-plugin-import` dep needs to be in `package.json` or not, but i've added it. - Re-enabled linting `main.ts` with relevant disable flags. I have a _suspicion_ that maybe the import rule sometimes messes up because all of the platform specific files are excluded from the checks (`**/*.{testing,electron,browser,web,api}.ts`), in this case it may be best to switch this rule off for now if other people keep seeing issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:44:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?