github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1208] [MERGED] Move YNAB4/5 import code into loot-core #3593

New Issue
Closed
opened 2026-02-28 20:43:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:43:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1208
Author: @j-f1
Created: 6/27/2023
Status: ✅ Merged
Merged: 7/30/2023
Merged by: @j-f1

Base: master ← Head: jed/inline-import

📝 Commits (10+)

  • c1cca87 Move importers into loot-core
  • 4825ff3 Reorganize the code a bit
  • a642e35 Remove the switch and make importers behave the same
  • 2fac80c Port YNAB4 importer to TS
  • a6dc3f2 Lint fixes
  • c5ee31f Sprinkle some types into the DB so the typecheck passes?
  • 2bc41dc Add release note
  • 5f84356 Fix type check error
  • a5957cf Port YNAB5 importer to TS
  • 0757ffc Fixes for type check

📊 Changes

24 files changed (+533 additions, -645 deletions)

View changed files

➖ packages/import-ynab4/README.md (+0 -4)
➖ packages/import-ynab4/index.js (+0 -17)
➖ packages/import-ynab4/package.json (+0 -29)
➖ packages/import-ynab5/README.md (+0 -86)
➖ packages/import-ynab5/example.json (+0 -174)
➖ packages/import-ynab5/index.js (+0 -17)
➖ packages/import-ynab5/package.json (+0 -27)
📝 packages/loot-core/package.json (+2 -1)
📝 packages/loot-core/src/platform/server/sqlite/index.d.ts (+10 -7)
📝 packages/loot-core/src/platform/server/sqlite/index.electron.ts (+19 -11)
📝 packages/loot-core/src/platform/server/sqlite/index.web.ts (+6 -6)
📝 packages/loot-core/src/server/cloud-storage.ts (+1 -1)
📝 packages/loot-core/src/server/db/index.ts (+2 -2)
➕ packages/loot-core/src/server/importers/actual.ts (+46 -0)
➕ packages/loot-core/src/server/importers/index.ts (+56 -0)
➕ packages/loot-core/src/server/importers/ynab4-types.d.ts (+165 -0)
📝 packages/loot-core/src/server/importers/ynab4.ts (+64 -91)
➕ packages/loot-core/src/server/importers/ynab5-types.d.ts (+75 -0)
📝 packages/loot-core/src/server/importers/ynab5.ts (+51 -59)
📝 packages/loot-core/src/server/main.ts (+2 -76)

...and 4 more files

📄 Description

This cleans up the directory structure a bit and helps keep related functionality together. The code still uses @actual-app/api — I’m not sure if it would make sense to port to calling the underlying handlers directly?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1208 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/27/2023 **Status:** ✅ Merged **Merged:** 7/30/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/inline-import` --- ### 📝 Commits (10+) - [`c1cca87`](https://github.com/actualbudget/actual/commit/c1cca871686de39d80cb9c73fb5a67bfc1a7718f) Move importers into loot-core - [`4825ff3`](https://github.com/actualbudget/actual/commit/4825ff39eeee6e37e7a0436739190e4d13f14b01) Reorganize the code a bit - [`a642e35`](https://github.com/actualbudget/actual/commit/a642e35bb719af70aaf3bd0dee4ef26a8344b7fd) Remove the switch and make importers behave the same - [`2fac80c`](https://github.com/actualbudget/actual/commit/2fac80c8b508b3d95b5d4713c1d0be2f97aaf8ba) Port YNAB4 importer to TS - [`a6dc3f2`](https://github.com/actualbudget/actual/commit/a6dc3f2bec3a54f52bd82ce8088499cc883b6003) Lint fixes - [`c5ee31f`](https://github.com/actualbudget/actual/commit/c5ee31fd909892809e8bf660bf588acff52d57ff) Sprinkle some types into the DB so the typecheck passes? - [`2bc41dc`](https://github.com/actualbudget/actual/commit/2bc41dcd1318ce80f5922e959558a1af5de2a1ab) Add release note - [`5f84356`](https://github.com/actualbudget/actual/commit/5f843561601ff1b87b18cae68912bf16ebef9604) Fix type check error - [`a5957cf`](https://github.com/actualbudget/actual/commit/a5957cf436c61e8954f9e167d9ad0252dae3649b) Port YNAB5 importer to TS - [`0757ffc`](https://github.com/actualbudget/actual/commit/0757ffc0d593a10bb68b58c4e53fd34b4d953b5d) Fixes for type check ### 📊 Changes **24 files changed** (+533 additions, -645 deletions) <details> <summary>View changed files</summary> ➖ `packages/import-ynab4/README.md` (+0 -4) ➖ `packages/import-ynab4/index.js` (+0 -17) ➖ `packages/import-ynab4/package.json` (+0 -29) ➖ `packages/import-ynab5/README.md` (+0 -86) ➖ `packages/import-ynab5/example.json` (+0 -174) ➖ `packages/import-ynab5/index.js` (+0 -17) ➖ `packages/import-ynab5/package.json` (+0 -27) 📝 `packages/loot-core/package.json` (+2 -1) 📝 `packages/loot-core/src/platform/server/sqlite/index.d.ts` (+10 -7) 📝 `packages/loot-core/src/platform/server/sqlite/index.electron.ts` (+19 -11) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.ts` (+6 -6) 📝 `packages/loot-core/src/server/cloud-storage.ts` (+1 -1) 📝 `packages/loot-core/src/server/db/index.ts` (+2 -2) ➕ `packages/loot-core/src/server/importers/actual.ts` (+46 -0) ➕ `packages/loot-core/src/server/importers/index.ts` (+56 -0) ➕ `packages/loot-core/src/server/importers/ynab4-types.d.ts` (+165 -0) 📝 `packages/loot-core/src/server/importers/ynab4.ts` (+64 -91) ➕ `packages/loot-core/src/server/importers/ynab5-types.d.ts` (+75 -0) 📝 `packages/loot-core/src/server/importers/ynab5.ts` (+51 -59) 📝 `packages/loot-core/src/server/main.ts` (+2 -76) _...and 4 more files_ </details> ### 📄 Description This cleans up the directory structure a bit and helps keep related functionality together. The code still uses `@actual-app/api` — I’m not sure if it would make sense to port to calling the underlying handlers directly? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:43:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3593
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?