github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1202] [MERGED] Run ESLint at the top level once #3587

New Issue
Closed
opened 2026-02-28 20:43:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:43:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1202
Author: @j-f1
Created: 6/26/2023
Status: ✅ Merged
Merged: 6/26/2023
Merged by: @j-f1

Base: master ← Head: jed/there-can-only-be-one

📝 Commits (2)

  • 171e4a2 Run ESLint at the top level once
  • 4ec3cd2 Fix lint issues in .eslintrc.js

📊 Changes

20 files changed (+52 additions, -54 deletions)

View changed files

➕ .eslintignore (+26 -0)
📝 .eslintrc.js (+23 -17)
📝 package.json (+1 -1)
➖ packages/api/.eslintignore (+0 -2)
📝 packages/api/package.json (+0 -1)
➖ packages/crdt/.eslintignore (+0 -1)
📝 packages/crdt/package.json (+0 -1)
➖ packages/desktop-client/.eslintignore (+0 -6)
📝 packages/desktop-client/package.json (+1 -2)
➖ packages/desktop-electron/.eslintignore (+0 -2)
📝 packages/desktop-electron/package.json (+0 -1)
📝 packages/eslint-plugin-actual/package.json (+0 -1)
➖ packages/import-ynab4/.eslintignore (+0 -1)
📝 packages/import-ynab4/package.json (+0 -3)
➖ packages/import-ynab5/.eslintignore (+0 -1)
📝 packages/import-ynab5/package.json (+0 -3)
➖ packages/loot-core/.eslintignore (+0 -3)
📝 packages/loot-core/package.json (+0 -1)
➖ packages/node-libofx/.eslintignore (+0 -3)
📝 packages/node-libofx/package.json (+1 -4)

📄 Description

This significantly speeds up yarn lint for me. It also ensures we’re listing all source files in the project, including the .eslintrc files and any other files that may be present.

$ git checkout master
$ time yarn lint
## sequence shortened for space reasons
[@actual-app/api]: Process exited (exit code 0), completed in 1s 858ms
[@actual-app/crdt]: Process exited (exit code 0), completed in 6s 394ms
[@actual-app/web]: Process exited (exit code 0), completed in 14s 337ms
[desktop-electron]: Process exited (exit code 0), completed in 1s 967ms
[eslint-plugin-actual]: Process exited (exit code 0), completed in 1s 494ms
[@actual-app/import-ynab4]: Process exited (exit code 0), completed in 1s 421ms
[@actual-app/import-ynab5]: Process exited (exit code 0), completed in 1s 240ms
[loot-core]: Process exited (exit code 0), completed in 20s 26ms
[node-libofx]: Process exited (exit code 0), completed in 1s 606ms
Done in 50s 352ms
________________________________________________________
Executed in   51.74 secs    fish           external
   usr time   77.83 secs   91.00 micros   77.83 secs
   sys time    7.83 secs  961.00 micros    7.83 secs

$ git checkout this-pr
$ time yarn lint
________________________________________________________
Executed in   27.50 secs    fish           external
   usr time   43.71 secs  120.00 micros   43.71 secs
   sys time    4.02 secs  934.00 micros    4.02 secs

---

<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1202 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/26/2023 **Status:** ✅ Merged **Merged:** 6/26/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/there-can-only-be-one` --- ### 📝 Commits (2) - [`171e4a2`](https://github.com/actualbudget/actual/commit/171e4a24ffb57c824f1bdf90a4840949d7e4c8d4) Run ESLint at the top level once - [`4ec3cd2`](https://github.com/actualbudget/actual/commit/4ec3cd25ca0809a830359a564204c355ae357539) Fix lint issues in .eslintrc.js ### 📊 Changes **20 files changed** (+52 additions, -54 deletions) <details> <summary>View changed files</summary> ➕ `.eslintignore` (+26 -0) 📝 `.eslintrc.js` (+23 -17) 📝 `package.json` (+1 -1) ➖ `packages/api/.eslintignore` (+0 -2) 📝 `packages/api/package.json` (+0 -1) ➖ `packages/crdt/.eslintignore` (+0 -1) 📝 `packages/crdt/package.json` (+0 -1) ➖ `packages/desktop-client/.eslintignore` (+0 -6) 📝 `packages/desktop-client/package.json` (+1 -2) ➖ `packages/desktop-electron/.eslintignore` (+0 -2) 📝 `packages/desktop-electron/package.json` (+0 -1) 📝 `packages/eslint-plugin-actual/package.json` (+0 -1) ➖ `packages/import-ynab4/.eslintignore` (+0 -1) 📝 `packages/import-ynab4/package.json` (+0 -3) ➖ `packages/import-ynab5/.eslintignore` (+0 -1) 📝 `packages/import-ynab5/package.json` (+0 -3) ➖ `packages/loot-core/.eslintignore` (+0 -3) 📝 `packages/loot-core/package.json` (+0 -1) ➖ `packages/node-libofx/.eslintignore` (+0 -3) 📝 `packages/node-libofx/package.json` (+1 -4) </details> ### 📄 Description This significantly speeds up `yarn lint` for me. It also ensures we’re listing all source files in the project, including the `.eslintrc` files and any other files that may be present. ```shellsession $ git checkout master $ time yarn lint ## sequence shortened for space reasons [@actual-app/api]: Process exited (exit code 0), completed in 1s 858ms [@actual-app/crdt]: Process exited (exit code 0), completed in 6s 394ms [@actual-app/web]: Process exited (exit code 0), completed in 14s 337ms [desktop-electron]: Process exited (exit code 0), completed in 1s 967ms [eslint-plugin-actual]: Process exited (exit code 0), completed in 1s 494ms [@actual-app/import-ynab4]: Process exited (exit code 0), completed in 1s 421ms [@actual-app/import-ynab5]: Process exited (exit code 0), completed in 1s 240ms [loot-core]: Process exited (exit code 0), completed in 20s 26ms [node-libofx]: Process exited (exit code 0), completed in 1s 606ms Done in 50s 352ms ________________________________________________________ Executed in 51.74 secs fish external usr time 77.83 secs 91.00 micros 77.83 secs sys time 7.83 secs 961.00 micros 7.83 secs $ git checkout this-pr $ time yarn lint ________________________________________________________ Executed in 27.50 secs fish external usr time 43.71 secs 120.00 micros 43.71 secs sys time 4.02 secs 934.00 micros 4.02 secs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:43:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3587
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?