github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 00:13:45 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1191] [CLOSED] Codesigning windows builds...RFC? #3580

New Issue
Closed
opened 2026-02-28 20:43:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:43:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1191
Author: @Shazib
Created: 6/25/2023
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (5)

  • 7d9cbd8 Attempt to add codesigning to windows electron
  • 53e3877 Merge branch 'actualbudget:master' into master
  • 5efbe3c Bump electron package version to match
  • 6893e4f Add Release Notes
  • 669b41c Merge branch 'actualbudget:master' into master

📊 Changes

3 files changed (+25 additions, -3 deletions)

View changed files

📝 .github/workflows/build.yml (+18 -2)
📝 packages/desktop-electron/package.json (+1 -1)
➕ upcoming-release-notes/1191.md (+6 -0)

📄 Description

Adding code-signing to windows builds.

This is all handled by electron-builder so all we need to do is supply it with the certificate details. There are two new github org secrets that need to be set before it will work. So I think maintainers will need to create this cert and upload it, I guess we might need to buy one from a cert authority? I am just using one I created locally. According to electron-builder the more the cert is used the more trust it will build up and stop showing the warning.

The new secrets are WIN_CERT_BASE64 and WIN_CERT_PASS

I will remove the workflow_dispatch: before this PR is merged, its just there for testing atm.

Slightly related, the version in desktop-electron/package.json is out of sync, so whatever process updates this perhaps needs a review.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1191 **Author:** [@Shazib](https://github.com/Shazib) **Created:** 6/25/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`7d9cbd8`](https://github.com/actualbudget/actual/commit/7d9cbd88320d66a4f6e0d29a283350e22bbcb3ba) Attempt to add codesigning to windows electron - [`53e3877`](https://github.com/actualbudget/actual/commit/53e38770253f4e39f851fe291d377f5d8b9e4602) Merge branch 'actualbudget:master' into master - [`5efbe3c`](https://github.com/actualbudget/actual/commit/5efbe3c1e3df34c07542270081139a74d3975c70) Bump electron package version to match - [`6893e4f`](https://github.com/actualbudget/actual/commit/6893e4f49783c7e99dddcde8a3e392725a36cc8c) Add Release Notes - [`669b41c`](https://github.com/actualbudget/actual/commit/669b41cfceddbcb9f72b7b8fdeb2b6a545dd9470) Merge branch 'actualbudget:master' into master ### 📊 Changes **3 files changed** (+25 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+18 -2) 📝 `packages/desktop-electron/package.json` (+1 -1) ➕ `upcoming-release-notes/1191.md` (+6 -0) </details> ### 📄 Description Adding code-signing to windows builds. This is all handled by electron-builder so all we need to do is supply it with the certificate details. There are two new github org secrets that need to be set before it will work. So I think maintainers will need to create this cert and upload it, I guess we might need to buy one from a cert authority? I am just using one I created locally. According to [electron-builder](https://www.electron.build/code-signing.html) the more the cert is used the more trust it will build up and stop showing the warning. The new secrets are `WIN_CERT_BASE64` and `WIN_CERT_PASS` I will remove the `workflow_dispatch:` before this PR is merged, its just there for testing atm. Slightly related, the version in `desktop-electron/package.json` is out of sync, so whatever process updates this perhaps needs a review. ![image](https://github.com/actualbudget/actual/assets/4405777/e21f964b-46c3-416c-81a6-8a7a0b7e72b4) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:43:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3580
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?